Audit and eliminate redundant #include directives in arm target files.
authorzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Mon, 11 May 2009 04:46:21 +0000 (04:46 +0000)
committerzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Mon, 11 May 2009 04:46:21 +0000 (04:46 +0000)
git-svn-id: svn://svn.berlios.de/openocd/trunk@1714 b42882b7-edfa-0310-969c-e2dbd0fdcd60

30 files changed:
src/target/arm11.c
src/target/arm11.h
src/target/arm11_dbgtap.c
src/target/arm720t.c
src/target/arm720t.h
src/target/arm7_9_common.c
src/target/arm7_9_common.h
src/target/arm7tdmi.c
src/target/arm7tdmi.h
src/target/arm920t.c
src/target/arm920t.h
src/target/arm926ejs.c
src/target/arm926ejs.h
src/target/arm966e.c
src/target/arm966e.h
src/target/arm9tdmi.c
src/target/arm9tdmi.h
src/target/arm_adi_v5.c
src/target/arm_disassembler.c
src/target/arm_jtag.c
src/target/arm_jtag.h
src/target/arm_simulator.c
src/target/arm_simulator.h
src/target/armv4_5.c
src/target/armv4_5_cache.c
src/target/armv4_5_cache.h
src/target/armv4_5_mmu.c
src/target/armv4_5_mmu.h
src/target/armv7m.c
src/target/armv7m.h

index 1ac952da9cd2d7c6c3fd5384c0c30ebf084fb605..18c3bd5c459bb72ed38fa8c4e5cb0c5029664056 100644 (file)
 #endif
 
 #include "arm11.h"
-#include "jtag.h"
-#include "log.h"
 
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index 1a890d063e78238bf777e6e67675de3a725e91de..4f75a62e6d629bd51ead53a1fd50543c64334d60 100644 (file)
 #ifndef ARM11_H
 #define ARM11_H
 
-#include "target.h"
-#include "register.h"
 #include "embeddedice.h"
-#include "arm_jtag.h"
-#include "types.h"
 
 #define asizeof(x)     (sizeof(x) / sizeof((x)[0]))
 
index fa127c640b0737622f1e8ac715cab4f4a452c469..0a86bc083764cbb08fc1122514e6f2b015b62d65 100644 (file)
 #endif
 
 #include "arm11.h"
-#include "jtag.h"
-#include "log.h"
 
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define JTAG_DEBUG(expr ...)   DEBUG(expr)
index b04a17f7eb1b2c72b4bbf4f47c7662ca5986b42e..0dbfdb41b663ff3c3445790a8546eb79b2c75f35 100644 (file)
 #endif
 
 #include "arm720t.h"
-#include "jtag.h"
-#include "log.h"
 #include "time_support.h"
 
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index f91f150a2f4e092b1da47dffdaf84462285c8206..10ac6535d79fda78e8b4368050e0f73a4615905b 100644 (file)
 #ifndef ARM720T_H
 #define ARM720T_H
 
-#include "target.h"
-#include "register.h"
-#include "embeddedice.h"
-#include "arm_jtag.h"
 #include "arm7tdmi.h"
 #include "armv4_5_mmu.h"
-#include "armv4_5_cache.h"
 
 #define        ARM720T_COMMON_MAGIC 0xa720a720
 
index 6a7b77c4ae441eb58868db154ae2bf3340c90767..a1b21030c2691ce13680142252ba07de0606f0fa 100644 (file)
 #include "config.h"
 #endif
 
-#include "replacements.h"
-
 #include "embeddedice.h"
-#include "target.h"
 #include "target_request.h"
-#include "armv4_5.h"
-#include "arm_jtag.h"
-#include "jtag.h"
-#include "log.h"
 #include "arm7_9_common.h"
-#include "breakpoints.h"
 #include "time_support.h"
 #include "arm_simulator.h"
 
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-
-#include <sys/stat.h>
-#include <sys/time.h>
-#include <errno.h>
 
 int arm7_9_debug_entry(target_t *target);
 int arm7_9_enable_sw_bkpts(struct target_s *target);
index d5b0487fece70f532ed6797c901a14dacec37335..04e29e05808904a6b30b7efe00d9398f3e8edd98 100644 (file)
 #ifndef ARM7_9_COMMON_H
 #define ARM7_9_COMMON_H
 
-#include "armv4_5.h"
-#include "arm_jtag.h"
 #include "breakpoints.h"
-#include "target.h"
-
 #include "etm.h"
 
 #define        ARM7_9_COMMON_MAGIC 0x0a790a79
index 098b3732f2dbe798479032339fbafc280fa36f37..116109d37fb5d9aaf4231ec1cad4ef34fb220d26 100644 (file)
 
 #include "arm7tdmi.h"
 
-#include "arm7_9_common.h"
-#include "register.h"
-#include "target.h"
-#include "armv4_5.h"
-#include "embeddedice.h"
-#include "etm.h"
-#include "log.h"
-#include "jtag.h"
-#include "arm_jtag.h"
-
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index 3624af6e9b6db6a06dae87478f6ae49246f42616..b3ece44ec35cdbf6a4843f2f49383668c3dffade 100644 (file)
 #ifndef ARM7TDMI_H
 #define ARM7TDMI_H
 
-#include "target.h"
-#include "register.h"
-#include "armv4_5.h"
 #include "embeddedice.h"
-#include "arm_jtag.h"
-#include "arm7_9_common.h"
 
 #define        ARM7TDMI_COMMON_MAGIC 0x00a700a7
 
index af26a2fca998cb5b19ffe06f5074a8467c46d32e..cd3129b06f1dcfd069ff22d3f8c607113b429aaa 100644 (file)
 #endif
 
 #include "arm920t.h"
-#include "jtag.h"
-#include "log.h"
 #include "time_support.h"
 
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index e1aab347bfebfca501ddd86e3803cc16f70eeea6..3f60901b6f9177d7d3948ec4908f2d16ac8a0a8a 100644 (file)
 #ifndef ARM920T_H
 #define ARM920T_H
 
-#include "target.h"
-#include "register.h"
-#include "embeddedice.h"
-#include "arm_jtag.h"
 #include "arm9tdmi.h"
 #include "armv4_5_mmu.h"
-#include "armv4_5_cache.h"
 
 #define        ARM920T_COMMON_MAGIC 0xa920a920
 
index c943f2fccdad9f04f25fb6767b34baaf335f731a..6233c7999d5b8ad8f00a94038182446cf24207d9 100644 (file)
 #endif
 
 #include "arm926ejs.h"
-#include "jtag.h"
-#include "log.h"
 #include "time_support.h"
 
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index ba5fcc13480288df55d34ef05df7b349b1130802..54796512daca612b9bf03d7d358b4b5a43db521d 100644 (file)
 #ifndef ARM926EJS_H
 #define ARM926EJS_H
 
-#include "target.h"
-#include "register.h"
-#include "embeddedice.h"
-#include "arm_jtag.h"
 #include "arm9tdmi.h"
 #include "armv4_5_mmu.h"
-#include "armv4_5_cache.h"
 
 #define        ARM926EJS_COMMON_MAGIC 0xa926a926
 
index 758b5f11cd37e6adcec40ba1fcfbbc9c9a500d43..effc272822ce8bd536c239b0635bd09902072339 100644 (file)
 
 #include "arm966e.h"
 
-#include "arm7_9_common.h"
-#include "register.h"
-#include "target.h"
-#include "armv4_5.h"
-#include "embeddedice.h"
-#include "log.h"
-#include "jtag.h"
-#include "arm_jtag.h"
-
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index b98c022489e7dc653cfd160149316bc2b3cf819f..995a79727f268eac5f3d5c117c722c045cc70e9e 100644 (file)
 #ifndef ARM966E_H
 #define ARM966E_H
 
-#include "target.h"
-#include "register.h"
-#include "embeddedice.h"
-#include "arm_jtag.h"
 #include "arm9tdmi.h"
 
 #define        ARM966E_COMMON_MAGIC 0x20f920f9
index e0a311397b9b7e30f953d2b64a7adc8d8fcacda5..63846cf29acba45756d4d281d25821fd86a857ea 100644 (file)
 
 #include "arm9tdmi.h"
 
-#include "arm7_9_common.h"
-#include "register.h"
-#include "target.h"
-#include "armv4_5.h"
-#include "embeddedice.h"
-#include "etm.h"
-#include "etb.h"
-#include "log.h"
-#include "jtag.h"
-#include "arm_jtag.h"
-
-#include <stdlib.h>
-#include <string.h>
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index fc650914a254543c1f0a20ce7e2b9ce4dee4491e..5c1a9f9ce4d14db1d2f66a47ee1fe1087732fa2d 100644 (file)
 #ifndef ARM9TDMI_H
 #define ARM9TDMI_H
 
-#include "target.h"
-#include "register.h"
-#include "armv4_5.h"
 #include "embeddedice.h"
-#include "arm_jtag.h"
-#include "arm7_9_common.h"
 
 #define        ARM9TDMI_COMMON_MAGIC 0x00a900a9
 
index fb30989a397d2a257f81e5fe8d97392d4c949e25..3c9461ae041302bfa6dba1fc0566da738ee61ee5 100644 (file)
 #include "config.h"
 #endif
 
-#include "replacements.h"
-
 #include "arm_adi_v5.h"
-#include "jtag.h"
-#include "log.h"
 #include "time_support.h"
-#include <stdlib.h>
-#include <string.h>
 
 /*
  * Transaction Mode:
index d222c47c15d31c4e0f5f1728a438c86cda99135c..dcff7a743c6f6fa3d9e5424c6f340b8ed1c9b0a4 100644 (file)
 #endif
 
 #include "arm_disassembler.h"
-
 #include "log.h"
 
-#include <string.h>
 
 /* textual represenation of the condition field */
 /* ALways (default) is ommitted (empty string) */
index ad57cef940198a5e9fd8c28cf8ff4037054ec4c2..0c1c36c8242ddb8d5f33a3f180196087a180c1a2 100644 (file)
 
 #include "arm_jtag.h"
 
-#include "binarybuffer.h"
-#include "log.h"
-#include "jtag.h"
-
-#include <stdlib.h>
 
 #if 0
 #define _ARM_JTAG_SCAN_N_CHECK_
index fff3e79e405c44bb8dd01a70b1a54589d81ab940..c76ba4a8cab50f16d6c81c6c5bd6b3c79729fe2e 100644 (file)
@@ -23,7 +23,6 @@
 #ifndef ARM_JTAG
 #define ARM_JTAG
 
-#include "types.h"
 #include "jtag.h"
 
 typedef struct arm_jtag_s
index b21ea4a8865cf5b15c210e5a4f03141dd481c2bb..00fbb2d78fdb9bb8fa77a2b14f10a21f505a91ff 100644 (file)
 #include "config.h"
 #endif
 
-#include "target.h"
 #include "armv4_5.h"
 #include "arm_disassembler.h"
 #include "arm_simulator.h"
 #include "log.h"
 #include "binarybuffer.h"
 
-#include <string.h>
 
 u32 arm_shift(u8 shift, u32 Rm, u32 shift_amount, u8 *carry)
 {
index 7894873043a75184ddf407f84d2ff3f134c9c6a6..730e6ccb852f62cabd202caad0eafc8b28dde947 100644 (file)
 #ifndef ARM_SIMULATOR_H
 #define ARM_SIMULATOR_H
 
-#include "target.h"
 #include "types.h"
 
-extern int arm_simulate_step(target_t *target, u32 *dry_run_pc);
+struct target_s;
 
+extern int arm_simulate_step(struct target_s *target, u32 *dry_run_pc);
 
 #define ERROR_ARM_SIMULATOR_NOT_IMPLEMENTED    (-700)
 
index 1144c7f12508f5636dd9756b292e838336fe937c..14aec0198c805bbd27b05721966d1a9255ca08a4 100644 (file)
 #include "config.h"
 #endif
 
-#include "replacements.h"
-
-#include "arm_disassembler.h"
-
 #include "armv4_5.h"
-
-#include "target.h"
-#include "register.h"
-#include "log.h"
+#include "arm_disassembler.h"
 #include "binarybuffer.h"
-#include "command.h"
 
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
 
 bitfield_desc_t armv4_5_psr_bitfield_desc[] =
 {
index 127420dc44ddaeacb0dbe202b343708a30615585..e6f08894c6d4ba74b7c8d52b6d412fd0fd544303 100644 (file)
@@ -22,9 +22,7 @@
 #endif
 
 #include "armv4_5_cache.h"
-
 #include "log.h"
-#include "command.h"
 
 int armv4_5_identify_cache(u32 cache_type_reg, armv4_5_cache_common_t *cache)
 {
index 03b9593527014cc0c3283a2d48f44b8d61fd252c..0a6e88ae560f78bcfa3a082588a585bc7fed6ea7 100644 (file)
@@ -21,7 +21,8 @@
 #define ARMV4_5_CACHE_H
 
 #include "types.h"
-#include "command.h"
+
+struct command_context_s;
 
 typedef struct armv4_5_cachesize_s
 {
index b108196e034ae809fc34d553167ee733de24eea0..cc8fb3a23a5fa022abc5d3fc0c0da896f491ecc2 100644 (file)
 #include "config.h"
 #endif
 
-#include "arm7_9_common.h"
 #include "log.h"
-#include "command.h"
 #include "armv4_5_mmu.h"
-#include "target.h"
 
-#include <stdlib.h>
 
 u32 armv4mmu_translate_va(target_t *target, armv4_5_mmu_common_t *armv4_5_mmu, u32 va, int *type, u32 *cb, int *domain, u32 *ap);
 
index b0a87ebbed9f8cd45c66524895af1f273eebb617..100beca93da407f00cedbf55e310280d6494647e 100644 (file)
@@ -21,6 +21,7 @@
 #define ARMV4_5_MMU_H
 
 #include "armv4_5_cache.h"
+#include "target.h"
 
 typedef struct armv4_5_mmu_common_s
 {
index 712b5ae341f4b1b28e9f2898bab52a485521d541..a73e60eaea975ff2839a85477c428246b428beae 100644 (file)
 #include "config.h"
 #endif
 
-#include "replacements.h"
-
 #include "armv7m.h"
-#include "register.h"
-#include "target.h"
-#include "log.h"
-#include "jtag.h"
-#include "arm_jtag.h"
-
-#include <stdlib.h>
-#include <string.h>
+
 
 #if 0
 #define _DEBUG_INSTRUCTION_EXECUTION_
index 35afe11f7efe934abd50025518b8d7503248b393..cb7bb5cbfae4d0bc952af8df389437c35a9e4c03 100644 (file)
@@ -26,9 +26,6 @@
 #ifndef ARMV7M_COMMON_H
 #define ARMV7M_COMMON_H
 
-#include "register.h"
-#include "target.h"
-#include "arm_jtag.h"
 #include "arm_adi_v5.h"
 
 /* define for enabling armv7 gdb workarounds */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)