Test the incoming debug_level, rather than the current.
authorAlan Bowman <alan.michael.bowman@gmail.com>
Wed, 25 Jul 2012 18:58:11 +0000 (19:58 +0100)
committerØyvind Harboe <oyvindharboe@gmail.com>
Fri, 27 Jul 2012 09:50:34 +0000 (09:50 +0000)
The existing code tests the current debug_level for validity, allowing
the user to set it too high and never change it after that.  The new
behaviour is to test the debug_level that the user has requested.

Change-Id: I85726a2e606c8d137e9b1cfe76fee865084844b1
Signed-off-by: Alan Bowman <alan.michael.bowman@gmail.com>
Reviewed-on: http://openocd.zylin.com/764
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/helper/log.c

index 74fdd65..ff84dbf 100644 (file)
@@ -225,7 +225,7 @@ COMMAND_HANDLER(handle_debug_level_command)
        if (CMD_ARGC == 1) {
                int new_level;
                COMMAND_PARSE_NUMBER(int, CMD_ARGV[0], new_level);
-               if ((debug_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) {
+               if ((new_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) {
                        LOG_ERROR("level must be between %d and %d", LOG_LVL_SILENT, LOG_LVL_DEBUG);
                        return ERROR_COMMAND_SYNTAX_ERROR;
                }