From: Alan Bowman Date: Wed, 25 Jul 2012 18:58:11 +0000 (+0100) Subject: Test the incoming debug_level, rather than the current. X-Git-Tag: v0.6.0-rc1~28 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=8cf671ea7be52096a629f08bd59492275bd3dcfb Test the incoming debug_level, rather than the current. The existing code tests the current debug_level for validity, allowing the user to set it too high and never change it after that. The new behaviour is to test the debug_level that the user has requested. Change-Id: I85726a2e606c8d137e9b1cfe76fee865084844b1 Signed-off-by: Alan Bowman Reviewed-on: http://openocd.zylin.com/764 Tested-by: jenkins Reviewed-by: Øyvind Harboe --- diff --git a/src/helper/log.c b/src/helper/log.c index 74fdd65726..ff84dbf005 100644 --- a/src/helper/log.c +++ b/src/helper/log.c @@ -225,7 +225,7 @@ COMMAND_HANDLER(handle_debug_level_command) if (CMD_ARGC == 1) { int new_level; COMMAND_PARSE_NUMBER(int, CMD_ARGV[0], new_level); - if ((debug_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) { + if ((new_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) { LOG_ERROR("level must be between %d and %d", LOG_LVL_SILENT, LOG_LVL_DEBUG); return ERROR_COMMAND_SYNTAX_ERROR; }