coding style: prototype of functions with no parameters 21/5621/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 6 May 2019 10:31:57 +0000 (12:31 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 9 May 2020 13:39:59 +0000 (14:39 +0100)
Functions that have no parameters should use "void" as parameter
in the function declaration.

Issue identified and fixed by script checkpatch from Linux kernel
v5.1 using the command

find src/ -type f -exec ./tools/scripts/checkpatch.pl \
-q --types FUNCTION_WITHOUT_ARGS --fix-inplace -f {} \;

Change-Id: If104ac75b44e939ec86155ff7b5720f2e33c6b39
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5621
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Tested-by: jenkins
src/helper/log.c
src/jtag/core.c
src/jtag/drivers/arm-jtag-ew.c
src/jtag/interface.c
src/jtag/minidummy/minidummy.c
src/jtag/zy1000/zy1000.c

index ae26df5..380f548 100644 (file)
@@ -401,7 +401,7 @@ char *alloc_printf(const char *format, ...)
  * fast when invoked more often than every 500ms.
  *
  */
-void keep_alive()
+void keep_alive(void)
 {
        current_time = timeval_ms();
        if (current_time-last_time > 1000) {
@@ -436,7 +436,7 @@ void keep_alive()
 }
 
 /* reset keep alive timer without sending message */
-void kept_alive()
+void kept_alive(void)
 {
        current_time = timeval_ms();
        last_time = current_time;
index f12ab59..884a743 100644 (file)
@@ -1872,7 +1872,7 @@ void jtag_set_verify(bool enable)
        jtag_verify = enable;
 }
 
-bool jtag_will_verify()
+bool jtag_will_verify(void)
 {
        return jtag_verify;
 }
@@ -1882,7 +1882,7 @@ void jtag_set_verify_capture_ir(bool enable)
        jtag_verify_capture_ir = enable;
 }
 
-bool jtag_will_verify_capture_ir()
+bool jtag_will_verify_capture_ir(void)
 {
        return jtag_verify_capture_ir;
 }
index d35e151..405278b 100644 (file)
@@ -683,7 +683,7 @@ static int armjtagew_tap_execute(void)
 /****************************************************************************
  * JLink USB low-level functions */
 
-static struct armjtagew *armjtagew_usb_open()
+static struct armjtagew *armjtagew_usb_open(void)
 {
        usb_init();
 
index de132bb..56bbf6e 100644 (file)
@@ -45,7 +45,7 @@ void tap_set_state_impl(tap_state_t new_state)
        state_follower = new_state;
 }
 
-tap_state_t tap_get_state()
+tap_state_t tap_get_state(void)
 {
        return state_follower;
 }
@@ -64,7 +64,7 @@ void tap_set_end_state(tap_state_t new_end_state)
        end_state_follower = new_end_state;
 }
 
-tap_state_t tap_get_end_state()
+tap_state_t tap_get_end_state(void)
 {
        return end_state_follower;
 }
index 7d5e6a9..7ee2067 100644 (file)
@@ -83,7 +83,7 @@ int interface_jtag_add_plain_dr_scan(int num_bits, const uint8_t *out_bits,
        return ERROR_OK;
 }
 
-int interface_jtag_add_tlr()
+int interface_jtag_add_tlr(void)
 {
        /* synchronously do the operation here */
 
index 48a3d4d..37af2f7 100644 (file)
@@ -486,7 +486,7 @@ int interface_jtag_add_plain_dr_scan(int num_bits,
        return ERROR_OK;
 }
 
-int interface_jtag_add_tlr()
+int interface_jtag_add_tlr(void)
 {
        setCurrentState(TAP_RESET);
        return ERROR_OK;