coding style: add missing space when split strings 20/5620/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 6 May 2019 10:18:30 +0000 (12:18 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 9 May 2020 13:39:44 +0000 (14:39 +0100)
Long strings are split across few lines; usually split occurs at
the white space between two words.
Check that the space between the two words is still present.
While there, adjust the amount of space between words.

Issue identified by checkpatch script from Linux kernel v5.1 using
the command

find src/ -type f -exec ./tools/scripts/checkpatch.pl \
-q --types MISSING_SPACE -f {} \;

Change-Id: I28b9a65564195ba967051add53d1c848c7b8fb30
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5620
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Tested-by: jenkins
src/flash/nor/at91sam3.c
src/flash/nor/at91sam4.c
src/helper/command.c
src/rtos/ChibiOS.c
src/rtos/linux.c
src/target/nds32_cmd.c
src/target/riscv/riscv.c
src/target/target.c

index b51e0972a65aa864d5884e76bd1bd5998831f651..c9ffa653b314faf10a2ff61df43fe4ee537b9019 100644 (file)
@@ -3726,7 +3726,7 @@ static const struct command_registration at91sam3_exec_command_handlers[] = {
                .name = "info",
                .handler = sam3_handle_info_command,
                .mode = COMMAND_EXEC,
-               .help = "Print information about the current at91sam3 chip"
+               .help = "Print information about the current at91sam3 chip "
                        "and its flash configuration.",
                .usage = "",
        },
index 135fc99bfbf80a38ccea437a7978ce7ec25ad7f0..5b56c42415035bcd2fd2599583477736e7c8d6cd 100644 (file)
@@ -3206,7 +3206,7 @@ static const struct command_registration at91sam4_exec_command_handlers[] = {
                .name = "info",
                .handler = sam4_handle_info_command,
                .mode = COMMAND_EXEC,
-               .help = "Print information about the current at91sam4 chip"
+               .help = "Print information about the current at91sam4 chip "
                        "and its flash configuration.",
                .usage = "",
        },
index 0882ecd586e9a5db71711355593d58534424c5a9..4422b4abe9b21e029c6c193b724241289eefbf87 100644 (file)
@@ -1219,9 +1219,9 @@ static const struct command_registration command_subcommand_handlers[] = {
                .mode = COMMAND_ANY,
                .jim_handler = jim_command_mode,
                .usage = "[command_name ...]",
-               .help = "Returns the command modes allowed by a  command:"
-                       "'any', 'config', or 'exec'.  If no command is"
-                       "specified, returns the current command mode.  "
+               .help = "Returns the command modes allowed by a command: "
+                       "'any', 'config', or 'exec'. If no command is "
+                       "specified, returns the current command mode. "
                        "Returns 'unknown' if an unknown command is given. "
                        "Command can be multiple tokens.",
        },
index 8839acc9a61f44c3938bcbfb769c00dc93184594..08b234fa918a37d92fdbb6eaf052db4983b1e176 100644 (file)
@@ -200,7 +200,7 @@ static int ChibiOS_update_memory_signature(struct rtos *rtos)
        /* Currently, we have the inherent assumption that all address pointers
         * are 32 bit wide. */
        if (signature->ch_ptrsize != sizeof(uint32_t)) {
-               LOG_ERROR("ChibiOS/RT target memory signature claims an address"
+               LOG_ERROR("ChibiOS/RT target memory signature claims an address "
                                  "width unequal to 32 bits!");
                free(signature);
                return -1;
index 0f18d171ce6b12ad2794c3b00acad4ba9268c3ae..e85a3bdf8d0899a9287ecff862e890e5ed5848b1 100644 (file)
@@ -1379,8 +1379,8 @@ static int linux_thread_packet(struct connection *connection, char const *packet
                                                 target->rtos->
                                                 current_threadid)
                                && (target->rtos->current_threadid != -1))
-                                       LOG_WARNING("WARNING! current GDB thread do not match"
-                                                       "current thread running."
+                                       LOG_WARNING("WARNING! current GDB thread do not match "
+                                                       "current thread running. "
                                                        "Switch thread in GDB to threadid %d",
                                                        (int)ct->threadid);
 
index 7bf7e60c760279b5241d5a676f37fc26f1b07d64..d7d040e4b963a0205a8257e9292ebd902f43cbde 100644 (file)
@@ -1007,7 +1007,7 @@ static const struct command_registration nds32_exec_command_handlers[] = {
                .handler = handle_nds32_global_stop_command,
                .mode = COMMAND_ANY,
                .usage = "['on'|'off']",
-               .help = "turn on/off global stop. After turning on, every load/store"
+               .help = "turn on/off global stop. After turning on, every load/store "
                         "instructions will be stopped to check memory access.",
        },
        {
index 7ad1ccde97d248268e5a3247b066ffd1f1b7cc2e..b5fd22b481e690258a2d7c480cd7370f3baec9d6 100644 (file)
@@ -1858,13 +1858,13 @@ static const struct command_registration riscv_exec_command_handlers[] = {
                .name = "test_sba_config_reg",
                .handler = riscv_test_sba_config_reg,
                .mode = COMMAND_ANY,
-               .usage = "riscv test_sba_config_reg legal_address num_words"
+               .usage = "riscv test_sba_config_reg legal_address num_words "
                        "illegal_address run_sbbusyerror_test[on/off]",
-               .help = "Perform a series of tests on the SBCS register."
-                       "Inputs are a legal, 128-byte aligned address and a number of words to"
-                       "read/write starting at that address (i.e., address range [legal address,"
-                       "legal_address+word_size*num_words) must be legally readable/writable)"
-                       ", an illegal, 128-byte aligned address for error flag/handling cases,"
+               .help = "Perform a series of tests on the SBCS register. "
+                       "Inputs are a legal, 128-byte aligned address and a number of words to "
+                       "read/write starting at that address (i.e., address range [legal address, "
+                       "legal_address+word_size*num_words) must be legally readable/writable)"
+                       "an illegal, 128-byte aligned address for error flag/handling cases, "
                        "and whether sbbusyerror test should be run."
        },
        {
index 538831b5b300aa45581d6339dd1bb42c45ac73b7..b0deadb0b034c19f54fa55f4d6825389e49127e9 100644 (file)
@@ -6232,7 +6232,7 @@ static const struct command_registration target_exec_command_handlers[] = {
                .name = "halt",
                .handler = handle_halt_command,
                .mode = COMMAND_EXEC,
-               .help = "request target to halt, then wait up to the specified"
+               .help = "request target to halt, then wait up to the specified "
                        "number of milliseconds (default 5000) for it to complete",
                .usage = "[milliseconds]",
        },
@@ -6248,7 +6248,7 @@ static const struct command_registration target_exec_command_handlers[] = {
                .handler = handle_reset_command,
                .mode = COMMAND_EXEC,
                .usage = "[run|halt|init]",
-               .help = "Reset all targets into the specified mode."
+               .help = "Reset all targets into the specified mode. "
                        "Default reset mode is run, if not given.",
        },
        {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)