Remove register_callbacks from pld_device structure, using an array
of command_registration records instead.
struct pld_device *p, *c;
/* register pld specific commands */
struct pld_device *p, *c;
/* register pld specific commands */
- if (pld_drivers[i]->register_commands(CMD_CTX) != ERROR_OK)
- {
- LOG_ERROR("couldn't register '%s' commands", CMD_ARGV[0]);
- exit(-1);
+ int retval;
+ if (pld_drivers[i]->commands) {
+ retval = register_commands(CMD_CTX, NULL,
+ pld_drivers[i]->commands);
+ if (ERROR_OK != retval)
+ {
+ LOG_ERROR("couldn't register '%s' commands", CMD_ARGV[0]);
+ return ERROR_FAIL;
+ }
}
c = malloc(sizeof(struct pld_device));
c->driver = pld_drivers[i];
c->next = NULL;
}
c = malloc(sizeof(struct pld_device));
c->driver = pld_drivers[i];
c->next = NULL;
- int retval = CALL_COMMAND_HANDLER(pld_drivers[i]->pld_device_command, c);
+ retval = CALL_COMMAND_HANDLER(pld_drivers[i]->pld_device_command, c);
if (ERROR_OK != retval)
{
LOG_ERROR("'%s' driver rejected pld device", CMD_ARGV[0]);
if (ERROR_OK != retval)
{
LOG_ERROR("'%s' driver rejected pld device", CMD_ARGV[0]);
{
char *name;
__PLD_DEVICE_COMMAND((*pld_device_command));
{
char *name;
__PLD_DEVICE_COMMAND((*pld_device_command));
- int (*register_commands)(struct command_context *cmd_ctx);
+ const struct command_registration *commands;
int (*load)(struct pld_device *pld_device, const char *filename);
};
int (*load)(struct pld_device *pld_device, const char *filename);
};
COMMAND_REGISTRATION_DONE
};
COMMAND_REGISTRATION_DONE
};
-static int virtex2_register_commands(struct command_context *cmd_ctx)
-{
- return register_commands(cmd_ctx, NULL, virtex2_command_handler);
-}
-
struct pld_driver virtex2_pld = {
.name = "virtex2",
struct pld_driver virtex2_pld = {
.name = "virtex2",
- .register_commands = &virtex2_register_commands,
+ .commands = virtex2_command_handler,
.pld_device_command = &virtex2_pld_device_command,
.load = &virtex2_load,
};
.pld_device_command = &virtex2_pld_device_command,
.load = &virtex2_load,
};
Linking to existing account procedure
If you already have an account and want to add another login method
you
MUST first sign in with your existing account and
then change URL to read
https://review.openocd.org/login/?link
to get to this page again but this time it'll work for linking. Thank you.
SSH host keys fingerprints
1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=.. |
|+o.. . |
|*.o . . |
|+B . . . |
|Bo. = o S |
|Oo.+ + = |
|oB=.* = . o |
| =+=.+ + E |
|. .=o . o |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)