Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: d031b5d)
avr32_regs: add missing error propagation
authorØyvind Harboe <oyvind.harboe@zylin.com>
Thu, 3 Nov 2011 20:51:31 +0000 (21:51 +0100)
committerSpencer Oliver <spen@spen-soft.co.uk>
Fri, 4 Nov 2011 09:05:15 +0000 (09:05 +0000)
Change-Id: Ie8b141dd534d73eccfc045069d5f628bd1eea88e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/166
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/target/avr32_regs.c patch | blob | history

diff --git a/src/target/avr32_regs.c b/src/target/avr32_regs.c
index eb283fc30882ea3d39d4a6194e2c61a099abdcae..e3761adcc2e30e64812c0595f3ead96b88da1e3b 100644 (file)
--- a/src/target/avr32_regs.c
+++ b/src/target/avr32_regs.c
@@ -97,6 +97,9 @@ int avr32_jtag_write_regs(struct avr32_jtag *jtag_info, uint32_t *regs)
        int i, retval;
 
        retval = avr32_jtag_write_reg(jtag_info, 0, regs[AVR32_REG_SR]);
+       if (retval != ERROR_OK)
+               return retval;
+
        /* Restore Status reg */
        retval = avr32_jtag_exec(jtag_info, MTSR(0, 0));
        if (retval != ERROR_OK)
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)