dap_dp_init: remove loop 93/3193/16
authorJiri Kastner <cz172638@gmail.com>
Fri, 11 Nov 2016 09:50:13 +0000 (10:50 +0100)
committerPaul Fertser <fercerpav@gmail.com>
Thu, 8 Dec 2016 12:25:52 +0000 (12:25 +0000)
current loop sounds to me like 'we don't know what we do, let's do it ten times, maybe we will have luck'.
should be enough to 'ping' debug port using reading CRTL_STAT.

tested on cortex-a8, snapdragon, jetson k1, cortex-r5, cortex-r4

Change-Id: Ibc62ac1eca06c141f4fccd5de7b11350ca1f35fd
Signed-off-by: Jiri Kastner <cz172638@gmail.com>
Tested-by: Jiri Kastner <cz172638@gmail.com>
Reviewed-on: http://openocd.zylin.com/3193
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Liviu Dudau <liviu@dudau.co.uk>
Reviewed-by: Paul Fertser <fercerpav@gmail.com>
src/target/arm_adi_v5.c

index f58afdc..39f2b39 100644 (file)
@@ -612,60 +612,58 @@ int dap_dp_init(struct adiv5_dap *dap)
        dap->select = DP_SELECT_INVALID;
        dap->last_read = NULL;
 
-       for (size_t i = 0; i < 10; i++) {
+       for (size_t i = 0; i < 30; i++) {
                /* DP initialization */
 
-               retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
-               if (retval != ERROR_OK)
-                       continue;
-
-               retval = dap_queue_dp_write(dap, DP_CTRL_STAT, SSTICKYERR);
-               if (retval != ERROR_OK)
-                       continue;
+               retval = dap_dp_read_atomic(dap, DP_CTRL_STAT, NULL);
+               if (retval == ERROR_OK)
+                       break;
+       }
 
-               retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
-               if (retval != ERROR_OK)
-                       continue;
+       retval = dap_queue_dp_write(dap, DP_CTRL_STAT, SSTICKYERR);
+       if (retval != ERROR_OK)
+               return retval;
 
-               dap->dp_ctrl_stat = CDBGPWRUPREQ | CSYSPWRUPREQ;
-               retval = dap_queue_dp_write(dap, DP_CTRL_STAT, dap->dp_ctrl_stat);
-               if (retval != ERROR_OK)
-                       continue;
+       retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
+       if (retval != ERROR_OK)
+               return retval;
 
-               /* Check that we have debug power domains activated */
-               LOG_DEBUG("DAP: wait CDBGPWRUPACK");
-               retval = dap_dp_poll_register(dap, DP_CTRL_STAT,
-                                             CDBGPWRUPACK, CDBGPWRUPACK,
-                                             DAP_POWER_DOMAIN_TIMEOUT);
-               if (retval != ERROR_OK)
-                       continue;
+       dap->dp_ctrl_stat = CDBGPWRUPREQ | CSYSPWRUPREQ;
+       retval = dap_queue_dp_write(dap, DP_CTRL_STAT, dap->dp_ctrl_stat);
+       if (retval != ERROR_OK)
+               return retval;
 
-               LOG_DEBUG("DAP: wait CSYSPWRUPACK");
-               retval = dap_dp_poll_register(dap, DP_CTRL_STAT,
-                                             CSYSPWRUPACK, CSYSPWRUPACK,
-                                             DAP_POWER_DOMAIN_TIMEOUT);
-               if (retval != ERROR_OK)
-                       continue;
+       /* Check that we have debug power domains activated */
+       LOG_DEBUG("DAP: wait CDBGPWRUPACK");
+       retval = dap_dp_poll_register(dap, DP_CTRL_STAT,
+                                     CDBGPWRUPACK, CDBGPWRUPACK,
+                                     DAP_POWER_DOMAIN_TIMEOUT);
+       if (retval != ERROR_OK)
+               return retval;
 
-               retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
-               if (retval != ERROR_OK)
-                       continue;
+       LOG_DEBUG("DAP: wait CSYSPWRUPACK");
+       retval = dap_dp_poll_register(dap, DP_CTRL_STAT,
+                                     CSYSPWRUPACK, CSYSPWRUPACK,
+                                     DAP_POWER_DOMAIN_TIMEOUT);
+       if (retval != ERROR_OK)
+               return retval;
 
-               /* With debug power on we can activate OVERRUN checking */
-               dap->dp_ctrl_stat = CDBGPWRUPREQ | CSYSPWRUPREQ | CORUNDETECT;
-               retval = dap_queue_dp_write(dap, DP_CTRL_STAT, dap->dp_ctrl_stat);
-               if (retval != ERROR_OK)
-                       continue;
-               retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
-               if (retval != ERROR_OK)
-                       continue;
+       retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
+       if (retval != ERROR_OK)
+               return retval;
 
-               retval = dap_run(dap);
-               if (retval != ERROR_OK)
-                       continue;
+       /* With debug power on we can activate OVERRUN checking */
+       dap->dp_ctrl_stat = CDBGPWRUPREQ | CSYSPWRUPREQ | CORUNDETECT;
+       retval = dap_queue_dp_write(dap, DP_CTRL_STAT, dap->dp_ctrl_stat);
+       if (retval != ERROR_OK)
+               return retval;
+       retval = dap_queue_dp_read(dap, DP_CTRL_STAT, NULL);
+       if (retval != ERROR_OK)
+               return retval;
 
-               break;
-       }
+       retval = dap_run(dap);
+       if (retval != ERROR_OK)
+               return retval;
 
        return retval;
 }