jtag/drivers/usb_common: return oocd error values 99/4699/3
authorAntonio Borneo <borneo.antonio@gmail.com>
Thu, 4 Oct 2018 16:24:25 +0000 (18:24 +0200)
committerTomas Vanek <vanekt@fbl.cz>
Tue, 8 Jan 2019 10:02:43 +0000 (10:02 +0000)
Where possible, keep the same style for returning error.

Change-Id: I3a04220c0b9f129a36e9fe83038b7c19dd57fe61
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4699
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/jtag/drivers/usb_common.c

index 54be6a6..1b7602d 100644 (file)
@@ -19,6 +19,7 @@
 #include "config.h"
 #endif
 #include "usb_common.h"
+#include "log.h"
 
 
 static bool jtag_usb_match(struct usb_device *dev,
@@ -45,10 +46,12 @@ int jtag_usb_open(const uint16_t vids[], const uint16_t pids[],
                                continue;
 
                        *out = usb_open(dev);
-                       if (NULL == *out)
-                               return -errno;
-                       return 0;
+                       if (NULL == *out) {
+                               LOG_ERROR("usb_open() failed with %s", usb_strerror());
+                               return ERROR_FAIL;
+                       }
+                       return ERROR_OK;
                }
        }
-       return -ENODEV;
+       return ERROR_FAIL;
 }