There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
# Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.
Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/136
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
18 files changed:
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x1f0f0f0f
}
set _CPUTAPID 0x1f0f0f0f
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0032409d
}
set _CPUTAPID 0x0032409d
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
set _CPUTAPID 0xffffffff
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0792603f
}
reset_config trst_and_srst separate trst_push_pull srst_open_drain
set _CPUTAPID 0x0792603f
}
reset_config trst_and_srst separate trst_push_pull srst_open_drain
jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID
adapter_nsrst_delay 300
jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID
adapter_nsrst_delay 300
set _CHIPNAME avr32
set _ENDIAN big
set _CHIPNAME avr32
set _ENDIAN big
-# force an error till we get a good number
set _CPUTAPID 0x21e8203f
jtag_nsrst_delay 100
set _CPUTAPID 0x21e8203f
jtag_nsrst_delay 100
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x1181501d
}
set _CPUTAPID 0x1181501d
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x01f2401d
}
set _CPUTAPID 0x01f2401d
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x01f2801d
}
set _CPUTAPID 0x01f2801d
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
set _CPUTAPID 0xffffffff
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
set _CPUTAPID 0xffffffff
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x30938053
}
set _CPUTAPID 0x30938053
}
if { [info exists CPUTAPID] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID] } {
set _CPUTAPID $CPUTAPID
} else {
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
set _CPUTAPID 0xffffffff
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0032409d
}
set _CPUTAPID 0x0032409d
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926f0f
}
set _CPUTAPID 0x07926f0f
}
if { [info exists ETBTAPID ] } {
set _ETBTAPID $ETBTAPID
} else {
if { [info exists ETBTAPID ] } {
set _ETBTAPID $ETBTAPID
} else {
- # force an error till we get a good number
set _ETBTAPID 0x2b900f0f
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
set _ETBTAPID 0x2b900f0f
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07b76f0f
}
set _CPUTAPID 0x07b76f0f
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x08630001
}
set _CPUTAPID 0x08630001
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926031
}
set _CPUTAPID 0x07926031
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926031
}
set _CPUTAPID 0x07926031
}
Linking to existing account procedure
If you already have an account and want to add another login method
you
MUST first sign in with your existing account and
then change URL to read
https://review.openocd.org/login/?link
to get to this page again but this time it'll work for linking. Thank you.
SSH host keys fingerprints
1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=.. |
|+o.. . |
|*.o . . |
|+B . . . |
|Bo. = o S |
|Oo.+ + = |
|oB=.* = . o |
| =+=.+ + E |
|. .=o . o |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)