src/{server,pld,svf,xsvf}: remove 'extern' keyword
authorZachary T Welch <zw@superlucidity.net>
Mon, 9 Nov 2009 11:38:34 +0000 (03:38 -0800)
committerZachary T Welch <zw@superlucidity.net>
Mon, 9 Nov 2009 17:44:33 +0000 (09:44 -0800)
Removes 'extern' keyword from function declarations in header filess.

src/pld/pld.h
src/server/gdb_server.h
src/server/server.h
src/server/tcl_server.h
src/server/telnet_server.h
src/svf/svf.h
src/xsvf/xsvf.h

index e4cfc07157859b06dee56ea7e8281ccf48d44dcf..c6d3c9248feefdc74e2a26a686ef9eb7eaca0c45 100644 (file)
@@ -39,9 +39,11 @@ typedef struct pld_device_s
        struct pld_device_s *next;
 } pld_device_t;
 
-extern int pld_register_commands(struct command_context_s *cmd_ctx);
-extern int pld_init(struct command_context_s *cmd_ctx);
-extern pld_device_t *get_pld_device_by_num(int num);
+int pld_register_commands(struct command_context_s *cmd_ctx);
+
+int pld_init(struct command_context_s *cmd_ctx);
+
+pld_device_t *get_pld_device_by_num(int num);
 
 #define ERROR_PLD_DEVICE_INVALID       (-1000)
 #define ERROR_PLD_FILE_LOAD_FAILED     (-1001)
index ea981f31640f1fd12b9c7d60100f651bced6ec1e..4e334bc0b6b85a15376cdfe9f3cbd9b79b1c71e5 100644 (file)
@@ -54,8 +54,8 @@ typedef struct gdb_service_s
        struct target_s *target;
 } gdb_service_t;
 
-extern int gdb_init(void);
-extern int gdb_register_commands(command_context_t *command_context);
+int gdb_init(void);
+int gdb_register_commands(command_context_t *command_context);
 
 #define ERROR_GDB_BUFFER_TOO_SMALL (-800)
 #define ERROR_GDB_TIMEOUT (-801)
index dab28eca3dfe09bd47d8946f5e24e810a4415545..d4f1b6b5a5ce47627253aec0a78713a777acef16 100644 (file)
@@ -69,11 +69,17 @@ typedef struct service_s
        struct service_s *next;
 } service_t;
 
-extern int add_service(char *name, enum connection_type type, unsigned short port, int max_connections, new_connection_handler_t new_connection_handler, input_handler_t input_handler, connection_closed_handler_t connection_closed_handler, void *priv);
-extern int server_init(void);
-extern int server_quit(void);
-extern int server_loop(command_context_t *command_context);
-extern int server_register_commands(command_context_t *context);
+int add_service(char *name, enum connection_type type, unsigned short port,
+               int max_connections, new_connection_handler_t new_connection_handler,
+               input_handler_t in_handler, connection_closed_handler_t close_handler,
+               void *priv);
+
+int server_init(void);
+int server_quit(void);
+
+int server_loop(command_context_t *command_context);
+
+int server_register_commands(command_context_t *context);
 
 int server_port_command(struct command_context_s *cmd_ctx,
                char *cmd, char **args, int argc, unsigned short *port);
index c90dc8e92b9208ea5fa58b260bbe0e7abf3baada..d6c9e10b1cabd5356d8111a231fc2f6e4ffedec3 100644 (file)
@@ -22,7 +22,7 @@
 
 #include "server.h"
 
-extern int tcl_init(void);
-extern int tcl_register_commands(command_context_t *cmd_ctx);
+int tcl_init(void);
+int tcl_register_commands(command_context_t *cmd_ctx);
 
 #endif /* _TCL_SERVER_H_ */
index 541d720d4b8ee2918c8a9cd847f3801cad01cb05..8f0d24abfe4e5c10e191c391df6105bde7aceeb7 100644 (file)
@@ -68,7 +68,7 @@ typedef struct telnet_service_s
        char *banner;
 } telnet_service_t;
 
-extern int telnet_init(char *banner);
-extern int telnet_register_commands(command_context_t *command_context);
+int telnet_init(char *banner);
+int telnet_register_commands(command_context_t *command_context);
 
 #endif /* TELNET_SERVER_H */
index 83123fc3b65ff1d5928733ea5bdb2a990f8d7373..329fea93b1a9f4d2337554a0858d56862f39c20b 100644 (file)
@@ -22,7 +22,7 @@
 
 #include "command.h"
 
-extern int svf_register_commands(struct command_context_s *cmd_ctx);
+int svf_register_commands(struct command_context_s *cmd_ctx);
 
 /**
  * svf_add_statemove() moves from the current state to @a goal_state.
@@ -35,7 +35,7 @@ extern int svf_register_commands(struct command_context_s *cmd_ctx);
  * SVF specification for single-argument STATE commands (and also used
  * for various other state transitions).
  */
-extern int svf_add_statemove(tap_state_t goal_state);
+int svf_add_statemove(tap_state_t goal_state);
 
 /**
  * svf_tap_state_is_stable() returns true for stable non-SHIFT states
@@ -43,6 +43,6 @@ extern int svf_add_statemove(tap_state_t goal_state);
  * @param state The TAP state in question
  * @return true iff the state is stable and not a SHIFT state.
  */
-extern bool svf_tap_state_is_stable(tap_state_t state);
+bool svf_tap_state_is_stable(tap_state_t state);
 
 #endif /* SVF_H */
index 017af882ed6569c4991d6a6c21910395a8d0ca23..93cccf0ae0d28104b09e82a2e7f99be4e344d5d5 100644 (file)
@@ -22,7 +22,7 @@
 
 #include "command.h"
 
-extern int xsvf_register_commands(struct command_context_s *cmd_ctx);
+int xsvf_register_commands(struct command_context_s *cmd_ctx);
 
 #define ERROR_XSVF_EOF (-200)
 #define ERROR_XSVF_FAILED      (-201)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)