pld_device_t -> struct pld_device
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 16:15:00 +0000 (08:15 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 19:58:08 +0000 (11:58 -0800)
Remove misleading typedef and redundant suffix from struct pld_device.

src/pld/pld.c
src/pld/pld.h
src/pld/virtex2.c

index 119d75d49234b19de7b9f7a016311e7f454edf30..e0a7eac596d9f7b2b1de37ccf441c877da302bb7 100644 (file)
@@ -36,12 +36,12 @@ static struct pld_driver *pld_drivers[] =
        NULL,
 };
 
-static pld_device_t *pld_devices;
+static struct pld_device *pld_devices;
 static command_t *pld_cmd;
 
-pld_device_t *get_pld_device_by_num(int num)
+struct pld_device *get_pld_device_by_num(int num)
 {
-       pld_device_t *p;
+       struct pld_device *p;
        int i = 0;
 
        for (p = pld_devices; p; p = p->next)
@@ -72,7 +72,7 @@ COMMAND_HANDLER(handle_pld_device_command)
        {
                if (strcmp(args[0], pld_drivers[i]->name) == 0)
                {
-                       pld_device_t *p, *c;
+                       struct pld_device *p, *c;
 
                        /* register pld specific commands */
                        if (pld_drivers[i]->register_commands(cmd_ctx) != ERROR_OK)
@@ -81,7 +81,7 @@ COMMAND_HANDLER(handle_pld_device_command)
                                exit(-1);
                        }
 
-                       c = malloc(sizeof(pld_device_t));
+                       c = malloc(sizeof(struct pld_device));
                        c->driver = pld_drivers[i];
                        c->next = NULL;
 
@@ -122,7 +122,7 @@ COMMAND_HANDLER(handle_pld_device_command)
 
 COMMAND_HANDLER(handle_pld_devices_command)
 {
-       pld_device_t *p;
+       struct pld_device *p;
        int i = 0;
 
        if (!pld_devices)
@@ -143,7 +143,7 @@ COMMAND_HANDLER(handle_pld_load_command)
 {
        int retval;
        struct timeval start, end, duration;
-       pld_device_t *p;
+       struct pld_device *p;
 
        gettimeofday(&start, NULL);
 
index 2b88d9dae5fcd2bf9818a882e8e3f05bc55c94e5..4c4c64a77649fc02884adbfbb6827b2c2d8e8334 100644 (file)
 
 #include "command.h"
 
-struct pld_device_s;
+struct pld_device;
 
 #define __PLD_DEVICE_COMMAND(name) \
-               COMMAND_HELPER(name, struct pld_device_s *pld)
+               COMMAND_HELPER(name, struct pld_device *pld)
 
 struct pld_driver
 {
        char *name;
        __PLD_DEVICE_COMMAND((*pld_device_command));
        int (*register_commands)(struct command_context_s *cmd_ctx);
-       int (*load)(struct pld_device_s *pld_device, const char *filename);
+       int (*load)(struct pld_device *pld_device, const char *filename);
 };
 
 #define PLD_DEVICE_COMMAND_HANDLER(name) static __PLD_DEVICE_COMMAND(name)
 
-typedef struct pld_device_s
+struct pld_device
 {
        struct pld_driver *driver;
        void *driver_priv;
-       struct pld_device_s *next;
-} pld_device_t;
+       struct pld_device *next;
+};
 
 int pld_register_commands(struct command_context_s *cmd_ctx);
 
 int pld_init(struct command_context_s *cmd_ctx);
 
-pld_device_t *get_pld_device_by_num(int num);
+struct pld_device *get_pld_device_by_num(int num);
 
 #define ERROR_PLD_DEVICE_INVALID       (-1000)
 #define ERROR_PLD_FILE_LOAD_FAILED     (-1001)
index 2e5a841468d03a682406bced42c2f280f31eceb6..e2ebb04143ec4b9a63b2d74c6586747d064bf447 100644 (file)
@@ -49,7 +49,7 @@ static int virtex2_set_instr(struct jtag_tap *tap, uint32_t new_instr)
        return ERROR_OK;
 }
 
-static int virtex2_send_32(struct pld_device_s *pld_device,
+static int virtex2_send_32(struct pld_device *pld_device,
                int num_words, uint32_t *words)
 {
        struct virtex2_pld_device *virtex2_info = pld_device->driver_priv;
@@ -82,7 +82,7 @@ static __inline__ void virtexflip32(jtag_callback_data_t arg)
        *((uint32_t *)in) = flip_u32(le_to_h_u32(in), 32);
 }
 
-static int virtex2_receive_32(struct pld_device_s *pld_device,
+static int virtex2_receive_32(struct pld_device *pld_device,
                int num_words, uint32_t *words)
 {
        struct virtex2_pld_device *virtex2_info = pld_device->driver_priv;
@@ -109,7 +109,7 @@ static int virtex2_receive_32(struct pld_device_s *pld_device,
        return ERROR_OK;
 }
 
-static int virtex2_read_stat(struct pld_device_s *pld_device, uint32_t *status)
+static int virtex2_read_stat(struct pld_device *pld_device, uint32_t *status)
 {
        uint32_t data[5];
 
@@ -131,7 +131,7 @@ static int virtex2_read_stat(struct pld_device_s *pld_device, uint32_t *status)
        return ERROR_OK;
 }
 
-static int virtex2_load(struct pld_device_s *pld_device, const char *filename)
+static int virtex2_load(struct pld_device *pld_device, const char *filename)
 {
        struct virtex2_pld_device *virtex2_info = pld_device->driver_priv;
        struct xilinx_bit_file bit_file;
@@ -179,7 +179,7 @@ static int virtex2_load(struct pld_device_s *pld_device, const char *filename)
 
 COMMAND_HANDLER(virtex2_handle_read_stat_command)
 {
-       pld_device_t *device;
+       struct pld_device *device;
        struct virtex2_pld_device *virtex2_info;
        uint32_t status;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)