SERVER: fix clang warning
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 23 Oct 2011 04:16:26 +0000 (12:16 +0800)
committerØyvind Harboe <oyvindharboe@gmail.com>
Sun, 23 Oct 2011 15:17:09 +0000 (15:17 +0000)
The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I0b9d0b419d9c8b7a8c755e048d5faf72d1658ba2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/87
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/server/server.c

index bb60fc5..a7fddf6 100644 (file)
@@ -487,7 +487,8 @@ int server_loop(struct command_context *command_context)
                                {
                                        if ((FD_ISSET(c->fd, &read_fds)) || c->input_pending)
                                        {
-                                               if ((retval = service->input(c)) != ERROR_OK)
+                                               retval = service->input(c);
+                                               if (retval != ERROR_OK)
                                                {
                                                        struct connection *next = c->next;
                                                        if (service->type == CONNECTION_PIPE)