Michael Fischer spotted a problem in the reset routines for srst_pulls_trst. It is...
authoroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Fri, 9 May 2008 18:38:51 +0000 (18:38 +0000)
committeroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Fri, 9 May 2008 18:38:51 +0000 (18:38 +0000)
Embedded ICE registers are now set up after SRST pulls TRST.

git-svn-id: svn://svn.berlios.de/openocd/trunk@650 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/target/target.c

index 3e9cce5b06e104f2d34dad5b7204ca32c651902a..d5e4ea56ef2812635b3c983e4c0488277e287766 100644 (file)
@@ -298,6 +298,16 @@ int target_process_reset(struct command_context_s *cmd_ctx)
        if ((retval = jtag_init_reset(cmd_ctx)) != ERROR_OK)
                return retval;
        
+       /* First time this is executed after launching OpenOCD, it will read out 
+        * the type of CPU, etc. and init Embedded ICE registers in host
+        * memory. 
+        * 
+        * It will also set up ICE registers in the target.
+        * 
+        * However, if we assert TRST later, we need to set up the registers again. 
+        * 
+        * For the "reset halt/init" case we must only set up the registers here.
+        */
        if ((retval = target_examine(cmd_ctx)) != ERROR_OK)
                return retval;
        
@@ -384,6 +394,13 @@ int target_process_reset(struct command_context_s *cmd_ctx)
                target = target->next;
        }
        
+       if (jtag_reset_config & RESET_SRST_PULLS_TRST)
+       {
+               /* If TRST was asserted we need to set up registers again */
+               if ((retval = target_examine(cmd_ctx)) != ERROR_OK)
+                       return retval;
+       }
+       
        if ((retval = jtag_execute_queue()) != ERROR_OK)
        {
                LOG_WARNING("JTAG communication failed while deasserting reset.");

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)