drivers: Rename 'libusb1_common' to 'libusb_helper' 34/5434/4
authorMarc Schink <dev@zapb.de>
Wed, 5 Feb 2020 15:07:48 +0000 (16:07 +0100)
committerOleksij Rempel <linux@rempel-privat.de>
Tue, 3 Mar 2020 09:12:02 +0000 (09:12 +0000)
The name 'common' does not make sense anymore. While at it,
remove some unnecessary #includes.

Change-Id: If9798a5cce179438d89428a598d8ca05c8e5f20c
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/5434
Tested-by: jenkins
Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
14 files changed:
src/jtag/aice/aice_interface.c
src/jtag/aice/aice_usb.c
src/jtag/drivers/Makefile.am
src/jtag/drivers/ft232r.c
src/jtag/drivers/kitprog.c
src/jtag/drivers/libusb_common.h [deleted file]
src/jtag/drivers/libusb_helper.c [moved from src/jtag/drivers/libusb1_common.c with 99% similarity]
src/jtag/drivers/libusb_helper.h [moved from src/jtag/drivers/libusb1_common.h with 95% similarity]
src/jtag/drivers/opendous.c
src/jtag/drivers/openjtag.c
src/jtag/drivers/osbdm.c
src/jtag/drivers/stlink_usb.c
src/jtag/drivers/usb_blaster/ublast2_access_libusb.c
src/jtag/drivers/usb_blaster/ublast_access.h

index f9bd87eeb370348c6b9f0adbeae21213c34fc00a..90871a1386d18028f48cfc1f0f9588ee88ccf4cb 100644 (file)
@@ -25,7 +25,6 @@
 #include <transport/transport.h>
 #include <target/target.h>
 #include <jtag/aice/aice_transport.h>
-#include <jtag/drivers/libusb_common.h>
 #include "aice_usb.h"
 
 #define AICE_KHZ_TO_SPEED_MAP_SIZE     16
index 8c3a629a037a1064b541eeef19d805d5b30b9fa1..5fefdd0b4e5336ef8d740e161e642ffd3bf94980 100644 (file)
@@ -19,7 +19,7 @@
 #include "config.h"
 #endif
 
-#include <jtag/drivers/libusb_common.h>
+#include <jtag/drivers/libusb_helper.h>
 #include <helper/log.h>
 #include <helper/time_support.h>
 #include <target/target.h>
index 47b19470ee35408d6861912c20957b1ae9464d7f..aea09b38ce3c402a15700f40396637e4fd5067d9 100644 (file)
@@ -22,7 +22,7 @@ DRIVERFILES += %D%/driver.c
 DRIVERFILES += %D%/jtag_usb_common.c
 
 if USE_LIBUSB1
-DRIVERFILES += %D%/libusb1_common.c
+DRIVERFILES += %D%/libusb_helper.c
 %C%_libocdjtagdrivers_la_CPPFLAGS += $(LIBUSB1_CFLAGS)
 %C%_libocdjtagdrivers_la_LIBADD += $(LIBUSB1_LIBS)
 endif
@@ -168,8 +168,7 @@ DRIVERHEADERS = \
        %D%/bitbang.h \
        %D%/bitq.h \
        %D%/jtag_usb_common.h \
-       %D%/libusb1_common.h \
-       %D%/libusb_common.h \
+       %D%/libusb_helper.h \
        %D%/minidriver_imp.h \
        %D%/mpsse.h \
        %D%/rlink.h \
index 8fe63bb35c0c821f3f60a9b5bc68b19817f83796..4812362a375ef2bc0cd86b5af97f8e77f7485a84 100644 (file)
@@ -29,7 +29,7 @@
 #include <jtag/interface.h>
 #include <jtag/commands.h>
 #include <helper/time_support.h>
-#include "libusb1_common.h"
+#include "libusb_helper.h"
 
 /* system includes */
 #include <string.h>
index e26f5aa9248ab420d88815566658501ba2a40383..0c1e74c42cb65c03345f51e08a71c0db88ecfa76 100644 (file)
@@ -43,7 +43,7 @@
 #include <jtag/swd.h>
 #include <jtag/commands.h>
 
-#include "libusb_common.h"
+#include "libusb_helper.h"
 
 #define VID 0x04b4
 #define PID 0xf139
diff --git a/src/jtag/drivers/libusb_common.h b/src/jtag/drivers/libusb_common.h
deleted file mode 100644 (file)
index 47aca5d..0000000
+++ /dev/null
@@ -1,25 +0,0 @@
-/***************************************************************************
- *   Copyright (C) 2011 by Mauro Gamba <maurillo71@gmail.com>              *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
- ***************************************************************************/
-
-#ifndef OPENOCD_JTAG_DRIVERS_LIBUSB_COMMON_H
-#define OPENOCD_JTAG_DRIVERS_LIBUSB_COMMON_H
-
-#ifdef HAVE_LIBUSB1
-#include "libusb1_common.h"
-#endif
-
-#endif /* OPENOCD_JTAG_DRIVERS_LIBUSB_COMMON_H */
similarity index 99%
rename from src/jtag/drivers/libusb1_common.c
rename to src/jtag/drivers/libusb_helper.c
index 607b6d4aa907b14359c51c1537d7d0461f8b9633..5a8129cb93d08b641f70f5ee8f972326824a5fc8 100644 (file)
@@ -21,7 +21,7 @@
 #include "config.h"
 #endif
 #include <jtag/drivers/jtag_usb_common.h>
-#include "libusb1_common.h"
+#include "libusb_helper.h"
 #include "log.h"
 
 /*
similarity index 95%
rename from src/jtag/drivers/libusb1_common.h
rename to src/jtag/drivers/libusb_helper.h
index b132e26ae6ca5a1b38882c139284e19bc2945ad9..46e4954e7895d282fe999ef28f0565fa6f9a22c4 100644 (file)
@@ -17,8 +17,8 @@
  *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
-#ifndef OPENOCD_JTAG_DRIVERS_LIBUSB1_COMMON_H
-#define OPENOCD_JTAG_DRIVERS_LIBUSB1_COMMON_H
+#ifndef OPENOCD_JTAG_DRIVERS_LIBUSB_HELPER_H
+#define OPENOCD_JTAG_DRIVERS_LIBUSB_HELPER_H
 
 #include <libusb.h>
 
@@ -55,4 +55,4 @@ int jtag_libusb_choose_interface(struct libusb_device_handle *devh,
                int bclass, int subclass, int protocol, int trans_type);
 int jtag_libusb_get_pid(struct libusb_device *dev, uint16_t *pid);
 
-#endif /* OPENOCD_JTAG_DRIVERS_LIBUSB1_COMMON_H */
+#endif /* OPENOCD_JTAG_DRIVERS_LIBUSB_HELPER_H */
index 18d9543083baa2a18bc655edfc6448a477fccc89..7298a2a109e8c7b73f20076827993e77684e4195 100644 (file)
@@ -32,7 +32,7 @@
 
 #include <jtag/interface.h>
 #include <jtag/commands.h>
-#include "libusb_common.h"
+#include "libusb_helper.h"
 #include <string.h>
 #include <time.h>
 
index 3bfcccf6eb485a20f4a3a8314ff34e380ed96bfc..7b07813d89c9f65860c29f760735f67a7e1cb041 100644 (file)
@@ -45,7 +45,7 @@
 
 #include <jtag/interface.h>
 #include <jtag/commands.h>
-#include "libusb_common.h"
+#include "libusb_helper.h"
 
 static enum {
        OPENJTAG_VARIANT_STANDARD,
index 30c46234e7caf88fc51dd98bb572fe309fccbd6e..aea126d0d34e0d13996b07462290658c41ee26cc 100644 (file)
@@ -23,7 +23,7 @@
 #include <helper/binarybuffer.h>
 #include <helper/command.h>
 #include <jtag/interface.h>
-#include "libusb_common.h"
+#include "libusb_helper.h"
 
 struct sequence {
        int len;
index a186dfdef414951aeb1b7b6b3ec6c2c2d686d8e5..ca7a4df4e8a4c8dcb7fcfdefea1489adb86cacd5 100644 (file)
@@ -41,7 +41,7 @@
 
 #include <target/cortex_m.h>
 
-#include "libusb_common.h"
+#include "libusb_helper.h"
 
 #ifdef HAVE_LIBUSB1
 #define USE_LIBUSB_ASYNCIO
index 34fbb89525c68eafa6a410f28f8fb30744fcf32a..4f7ee6300740547431e3b9a4e4bdfe896d246223 100644 (file)
@@ -23,7 +23,7 @@
 #endif
 #include <jtag/interface.h>
 #include <jtag/commands.h>
-#include <libusb_common.h>
+#include <libusb_helper.h>
 #include <target/image.h>
 
 #include "ublast_access.h"
index 5178ae10bac0caa37d93af86a7a57b6f925554ea..ad20d65d4f576ca3f2bb7d5687223659d5018582 100644 (file)
@@ -28,8 +28,6 @@
 #ifndef OPENOCD_JTAG_DRIVERS_USB_BLASTER_UBLAST_ACCESS_H
 #define OPENOCD_JTAG_DRIVERS_USB_BLASTER_UBLAST_ACCESS_H
 
-#include <libusb_common.h>
-
 /* Low level flags */
 #define COPY_TDO_BUFFER                (1 << 0)
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)