src/jtag/drivers/ftdi: fix swd pin comment and links 08/4908/3
authorDiego Herranz <diegoherranz@diegoherranz.com>
Wed, 13 Feb 2019 08:33:17 +0000 (08:33 +0000)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Tue, 5 Mar 2019 08:04:47 +0000 (08:04 +0000)
- TDI/DO is not pin 2 and in fact, we don't even need to mention which
pin number it is. "TDI/DO pin" is descriptive enough.

- FT2232D link didn't work anymore. It could have been updated to the
current working FT2232D link but changed to link the FT2232H instead
which is the latest generation and the most commonly used these days.

- Taking advantage of the change, link to the MPSSE document updated.
It still worked but through a redirection, so updated just in case the
redirection stops working.

Change-Id: Ia7d01bbcac2158026831edb010a6b50f58351e42
Signed-off-by: Diego Herranz <diegoherranz@diegoherranz.com>
Reviewed-on: http://openocd.zylin.com/4908
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
src/jtag/drivers/ftdi.c

index b709d28..e7f3c3d 100644 (file)
  *
  * This code uses information contained in the MPSSE specification which was
  * found here:
- * http://www.ftdichip.com/Documents/AppNotes/AN2232C-01_MPSSE_Cmnd.pdf
+ * https://www.ftdichip.com/Support/Documents/AppNotes/AN2232C-01_MPSSE_Cmnd.pdf
  * Hereafter this is called the "MPSSE Spec".
  *
- * The datasheet for the ftdichip.com's FT2232D part is here:
- * http://www.ftdichip.com/Documents/DataSheets/DS_FT2232D.pdf
+ * The datasheet for the ftdichip.com's FT2232H part is here:
+ * https://www.ftdichip.com/Support/Documents/DataSheets/ICs/DS_FT2232H.pdf
  *
  * Also note the issue with code 0x4b (clock data to TMS) noted in
  * http://developer.intra2net.com/mailarchive/html/libftdi/2009/msg00292.html
@@ -1055,7 +1055,7 @@ static void ftdi_swd_swdio_en(bool enable)
                if (oe->data_mask)
                        ftdi_set_signal(oe, enable ? '1' : '0');
                else {
-                       /* Sets TDI/DO pin (pin 2) to input during rx when both pins are connected
+                       /* Sets TDI/DO pin to input during rx when both pins are connected
                           to SWDIO */
                        if (enable)
                                direction |= jtag_direction_init & 0x0002U;