NOR/CORE: fix clang warning
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 23 Oct 2011 04:12:57 +0000 (12:12 +0800)
committerØyvind Harboe <oyvindharboe@gmail.com>
Sun, 23 Oct 2011 14:37:48 +0000 (14:37 +0000)
The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I10338a249bcfeff87d8596f7e17f209e26b41678
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/86
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/flash/nor/core.c

index 4b5fe7d..7f40bbf 100644 (file)
@@ -344,7 +344,8 @@ int default_flash_blank_check(struct flash_bank *bank)
                uint32_t address = bank->base + bank->sectors[i].offset;
                uint32_t size = bank->sectors[i].size;
 
-               if ((retval = target_blank_check_memory(target, address, size, &blank)) != ERROR_OK)
+               retval = target_blank_check_memory(target, address, size, &blank);
+               if (retval != ERROR_OK)
                {
                        fast_check = 0;
                        break;