flash: nor: jtagspi: fix jtagspi_read_status() warning 38/4338/2
authorPaul Fertser <fercerpav@gmail.com>
Sun, 14 Jan 2018 16:28:20 +0000 (19:28 +0300)
committerPaul Fertser <fercerpav@gmail.com>
Tue, 30 Jan 2018 07:36:51 +0000 (07:36 +0000)
Clang static analyzer says that in certain cases "Assigned value is
garbage or undefined" there.

Change-Id: Ib35a4cf7a553ba9461270a0dc4c4b9b205091e73
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/4338
Tested-by: jenkins
src/flash/nor/jtagspi.c

index a05ff37..a73812d 100644 (file)
@@ -224,9 +224,10 @@ static int jtagspi_probe(struct flash_bank *bank)
 static void jtagspi_read_status(struct flash_bank *bank, uint32_t *status)
 {
        uint8_t buf;
-       jtagspi_cmd(bank, SPIFLASH_READ_STATUS, NULL, &buf, -8);
-       *status = buf;
-       /* LOG_DEBUG("status=0x%08" PRIx32, *status); */
+       if (jtagspi_cmd(bank, SPIFLASH_READ_STATUS, NULL, &buf, -8) == ERROR_OK) {
+               *status = buf;
+               /* LOG_DEBUG("status=0x%08" PRIx32, *status); */
+       }
 }
 
 static int jtagspi_wait(struct flash_bank *bank, int timeout_ms)