Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 4532dc7)
TARGET/ARM920T: fix compile warning
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 12 Jun 2010 03:01:24 +0000 (11:01 +0800)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Sat, 12 Jun 2010 10:07:53 +0000 (12:07 +0200)
Commit 0538081246fafbfb74d554bb1b758412534aa254
introduces a compile time warning:
arm920t.c: In function ‘arm920t_write_memory’:
arm920t.c:567: warning: ‘retval’ may be used uninitialized in this function

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/arm920t.c patch | blob | history

diff --git a/src/target/arm920t.c b/src/target/arm920t.c
index 317519607e3c051d9b3e5ef98fd7081d7c70cb10..03aa233df6f5eee4a210a3ec8fbd4354937a8ec2 100644 (file)
--- a/src/target/arm920t.c
+++ b/src/target/arm920t.c
@@ -592,7 +592,7 @@ int arm920t_write_memory(struct target *target, uint32_t address,
                /*
                 * We need physical address and cb
                 */
-               int retval = armv4_5_mmu_translate_va(target, &arm920t->armv4_5_mmu,
+               retval = armv4_5_mmu_translate_va(target, &arm920t->armv4_5_mmu,
                                address, &type, &cb, &domain, &ap, &pa);
                if (retval != ERROR_OK)
                        return retval;
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)