zy1000: fix bug in end state of DCC writes
authorØyvind Harboe <oyvind.harboe@zylin.com>
Fri, 19 Mar 2010 13:27:19 +0000 (14:27 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Fri, 19 Mar 2010 13:27:19 +0000 (14:27 +0100)
Introduced in latest commits, found by code inspection &
GCC warning.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/jtag/zy1000/zy1000.c

index 9b8b48043dae52d088bbe5cecd7255728517ea37..a844dc3a0f26a05350ccf9ee0b9e26c129e3362f 100644 (file)
@@ -775,7 +775,7 @@ int interface_jtag_add_pathmove(int num_states, const tap_state_t *path)
 
        uint8_t seq[16];
        memset(seq, 0, sizeof(seq));
-       assert(num_states < (sizeof(seq) * 8));
+       assert(num_states < (int)((sizeof(seq) * 8)));
 
        while (num_states)
        {
@@ -850,7 +850,7 @@ void embeddedice_write_dcc(struct jtag_tap *tap, int reg_addr, uint8_t *buffer,
        } else
        {
                tap_state_t end_state = TAP_IDLE;
-               tap_state_t shift_end_state;
+               tap_state_t shift_end_state = TAP_DRSHIFT;
                if (post_bits == 0)
                        shift_end_state = end_state;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)