Audit and eliminate redundant #include directives from src/jtag.
[openocd.git] / src / jtag / ep93xx.c
index f2e176fd33ce45770753c92a65835ec00fac3f55..1f422314827b59d526b5f1c2c72df147eaaf31da 100644 (file)
@@ -21,7 +21,6 @@
 #include "config.h"
 #endif
 
-#include "log.h"
 #include "jtag.h"
 #include "bitbang.h"
 
 #define SRST_BIT       32
 #define VCC_BIT                64
 
-/* system includes */
-#include <string.h>
-#include <stdlib.h>
-#include <stdio.h>
 #include <sys/mman.h>
-#include <unistd.h>
-#include <fcntl.h>
 
 static u8 output_value = 0x0;
 static int dev_mem_fd;
@@ -49,21 +42,21 @@ static volatile u8 *gpio_data_direction_register;
 
 /* low level command set
  */
-int ep93xx_read(void);
-void ep93xx_write(int tck, int tms, int tdi);
-void ep93xx_reset(int trst, int srst);
+static int ep93xx_read(void);
+static void ep93xx_write(int tck, int tms, int tdi);
+static void ep93xx_reset(int trst, int srst);
 
-int ep93xx_speed(int speed);
-int ep93xx_register_commands(struct command_context_s *cmd_ctx);
-int ep93xx_init(void);
-int ep93xx_quit(void);
+static int ep93xx_speed(int speed);
+static int ep93xx_register_commands(struct command_context_s *cmd_ctx);
+static int ep93xx_init(void);
+static int ep93xx_quit(void);
 
 struct timespec ep93xx_zzzz;
 
 jtag_interface_t ep93xx_interface = 
 {
        .name = "ep93xx",
-       
+
        .execute_queue = bitbang_execute_queue,
 
        .speed = ep93xx_speed,  
@@ -72,64 +65,64 @@ jtag_interface_t ep93xx_interface =
        .quit = ep93xx_quit,
 };
 
-bitbang_interface_t ep93xx_bitbang =
+static bitbang_interface_t ep93xx_bitbang =
 {
        .read = ep93xx_read,
        .write = ep93xx_write,
        .reset = ep93xx_reset,
-       .blink = 0;
+       .blink = 0,
 };
 
-int ep93xx_read(void)
+static int ep93xx_read(void)
 {
        return !!(*gpio_data_register & TDO_BIT);
 }
 
-void ep93xx_write(int tck, int tms, int tdi)
+static void ep93xx_write(int tck, int tms, int tdi)
 {
        if (tck)
                output_value |= TCK_BIT;
        else
-               output_value &= TCK_BIT;
+               output_value &= ~TCK_BIT;
        
        if (tms)
                output_value |= TMS_BIT;
        else
-               output_value &= TMS_BIT;
+               output_value &= ~TMS_BIT;
        
        if (tdi)
                output_value |= TDI_BIT;
        else
-               output_value &= TDI_BIT;
+               output_value &= ~TDI_BIT;
 
        *gpio_data_register = output_value;
-       nanosleep(ep93xx_zzzz);
+       nanosleep(&ep93xx_zzzz, NULL);
 }
 
 /* (1) assert or (0) deassert reset lines */
-void ep93xx_reset(int trst, int srst)
+static void ep93xx_reset(int trst, int srst)
 {
        if (trst == 0)
                output_value |= TRST_BIT;
        else if (trst == 1)
-               output_value &= TRST_BIT;
+               output_value &= ~TRST_BIT;
 
        if (srst == 0)
                output_value |= SRST_BIT;
        else if (srst == 1)
-               output_value &= SRST_BIT;
+               output_value &= ~SRST_BIT;
        
        *gpio_data_register = output_value;
-       nanosleep(ep93xx_zzzz);
+       nanosleep(&ep93xx_zzzz, NULL);
 }
 
-int ep93xx_speed(int speed)
+static int ep93xx_speed(int speed)
 {
-       
+
        return ERROR_OK;
 }
 
-int ep93xx_register_commands(struct command_context_s *cmd_ctx)
+static int ep93xx_register_commands(struct command_context_s *cmd_ctx)
 {
 
        return ERROR_OK;
@@ -156,7 +149,7 @@ static int set_gonk_mode(void)
        return ERROR_OK;
 }
 
-int ep93xx_init(void)
+static int ep93xx_init(void)
 {
        int ret;
 
@@ -209,8 +202,8 @@ int ep93xx_init(void)
        gpio_data_register = gpio_controller + 0x08;
        gpio_data_direction_register = gpio_controller + 0x18;
 
-       printf("gpio_data_register      = %p\n", gpio_data_register);
-        printf("gpio_data_direction_reg = %p\n", gpio_data_direction_register); 
+       LOG_INFO("gpio_data_register      = %p\n", gpio_data_register);
+       LOG_INFO("gpio_data_direction_reg = %p\n", gpio_data_direction_register); 
        /*
         * Configure bit 0 (TDO) as an input, and bits 1-5 (TDI, TCK
         * TMS, TRST, SRST) as outputs.  Drive TDI and TCK low, and
@@ -218,7 +211,7 @@ int ep93xx_init(void)
         */
        output_value = TMS_BIT | TRST_BIT | SRST_BIT | VCC_BIT;
        *gpio_data_register = output_value;
-       nanosleep(ep93xx_zzzz);
+       nanosleep(&ep93xx_zzzz, NULL);
 
        /*
         * Configure the direction register.  1 = output, 0 = input.
@@ -226,11 +219,11 @@ int ep93xx_init(void)
        *gpio_data_direction_register =
                TDI_BIT | TCK_BIT | TMS_BIT | TRST_BIT | SRST_BIT | VCC_BIT;
 
-       nanosleep(ep93xx_zzzz);
+       nanosleep(&ep93xx_zzzz, NULL);
        return ERROR_OK;
 }
 
-int ep93xx_quit(void)
+static int ep93xx_quit(void)
 {
 
        return ERROR_OK;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)