zwelch [Mon, 8 Jun 2009 10:55:24 +0000 (10:55 +0000)]
Extend handle_jtag_n{s,t}rst_delay_command routines:
- Add support to display the reset delays too, like the other commands.
- Always show the values, so users can see if they are being redundant.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2113
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 10:55:13 +0000 (10:55 +0000)]
Add accessors to retrieve values of jtag_n{s,t}rst_delay variables.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2112
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 10:54:52 +0000 (10:54 +0000)]
Update JTAG reset delay command handlers:
- Fixes for error handling:
- Return a syntax error instead of calling exit(-1).
- Return error when more than one argument is provided too.
- Remove useless braces and indent after the if/return statements.
- Wrap function arguments to fit in 80 columns.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2111
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 10:54:41 +0000 (10:54 +0000)]
Cleanup the handle_jtag_khz_command routine:
- Separate retval assignments from logical tests.
- Simplify logical tests.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2110
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 10:54:06 +0000 (10:54 +0000)]
Simplify logic in handle_jtag_speed_command.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2109
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Mon, 8 Jun 2009 06:18:13 +0000 (06:18 +0000)]
David Brownell <david-b@pacbell.net> Bugfix: $target_name cget/configure -work-area-backup commands
should return the "is it backed up?" flag, not the work area size.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2108
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Mon, 8 Jun 2009 06:16:43 +0000 (06:16 +0000)]
David Brownell <david-b@pacbell.net>
- Don't let disabled TAPs be set as the current target
- Improve "targets" output:
* Remove undesirable "chain position" number; we discourage using them
* TAP and Target column updates:
+ make them long enough for current usage
+ improve labels, removing guesswork
+ "TapName" label patches scan_chain output
* Highlight the "current" target
* Display "tap disabled" as a new pseudo-state
* Update docs accordingly
git-svn-id: svn://svn.berlios.de/openocd/trunk@2107
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 04:35:19 +0000 (04:35 +0000)]
Adjust whitespace in configure script: use two spaces for indent.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2106
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 04:35:05 +0000 (04:35 +0000)]
Reorder configure script macros:
- Check for a compiler before looking for libraries or header files.
- Initialize automake before calling other AM_ macros.
- Disable libtool shared libraries by default.
- Remove checks for unused C++, Fortran, and Java compilers.
- Remove redundant AC_CANONICAL_HOST; called by AC_PROG_LIBTOOL.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2105
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 04:34:45 +0000 (04:34 +0000)]
Rework parallel port configure script option handling:
- Move AC_ARG_ENABLE for secondary parallel port options:
- These macros cause their configure options to appear unconditionally,
so they should not be placed inside conditional logic.
- Groups them with primary parallel port driver option.
- Update these options to show '-' instead of '_'; both still work.
- Update command help text to show host architecture/OS requirements.
- Display a warning when these options have been provided and the
configure script will ignore the setting that the user specified.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2104
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 01:14:04 +0000 (01:14 +0000)]
Move minidummy source file, as was supposed to happen in last commit.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2103
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Mon, 8 Jun 2009 00:42:15 +0000 (00:42 +0000)]
Finish off the dummy minidriver integration:
- Try to disambiguates minidriver options from "standard" driver options.
- Make minidummy symbols more explict about being a minidriver.
- Move minidummy.c into minidummy directory to put it with its header.
In configure.in:
- Improve configuration option to allow new minidriver implementations:
- Change option from --enable-minidummy to --enable-minidriver-dummy.
- Move it to the end of the list of options.
- Provides a clear pattern for future minidrivers.
- Update handling of HAVE_JTAG_MINIDRIVER_H:
- Check for external jtag_minidriver.h only with --enable-ecosboard.
- Otherwise, define it when --enable-minidriver-dummy is provided.
- Add check to ensure only one minidriver is enabled.
- When a minidriver is enabled, warn user that standard drivers are not built.
- Use proper AC_DEFINE semantics with MINIDRIVER_DUMMY.
In src/jtag/Makefile.am:
- Restructure handling of minidummy source files.
- Include minidummy driver header in the distribution.
In src/jtag/jtag.c:
- Restructure preprocessor logic to include:
- only one minidriver, or
- all configured standard drivers.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2102
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:49:14 +0000 (23:49 +0000)]
Fix reference warning in JTAG primer, add another external reference.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2101
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:35:29 +0000 (23:35 +0000)]
David Brownell <david-b@pacbell.net>:
Let disabled targets be ignored during normal operation:
- In target_examine(), ignore disabled TAPs
- Reset handling must not poke at them either:
* fail $target_name arp_* operations on disabled TAPs
* in startup.tcl, don't even issue the arp_* wait ops
ZW: removed superfluous braces from the patch to target.c.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2100
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:21:41 +0000 (23:21 +0000)]
David Brownell <david-b@pacbell.net>:
Clarify docs for the evb_lm3s811 layout: works in
two modes, not just one.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2099
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:20:30 +0000 (23:20 +0000)]
Fix regression in mdw output; identified by Magnus Lundin.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2098
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:14:58 +0000 (23:14 +0000)]
David Brownell <david-b@pacbell.net>:
Rework chapter 12 (CPU configuration) to use @deffn, match
the code more closely, and present things more clearly.
Includes the *current* list of targets.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2097
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 23:10:50 +0000 (23:10 +0000)]
David Brownell <david-b@pacbell.net>:
Various minor tweaks for the User's guide.
- Fix various minor (but repeated) typographic goofs;
- Talk about TAP "declaration" not "creation" (they exist
even if OpenOCD never learns about their board);
- Encourage board.cfg for reset config, not target.cfg
- Fill in some missing information (e.g. x16_as_x8)
- Add a cross reference to the FAQ on TAP ordering;
- Unclutter the concept index a bit (re core-specific commands)
- Provide a bit more info about TAP states
git-svn-id: svn://svn.berlios.de/openocd/trunk@2096
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Sun, 7 Jun 2009 19:10:51 +0000 (19:10 +0000)]
retire endstate command
git-svn-id: svn://svn.berlios.de/openocd/trunk@2095
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 18:39:11 +0000 (18:39 +0000)]
Set svn:eol-style properties on new minidummy driver files.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2094
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 18:38:13 +0000 (18:38 +0000)]
Fix regressions in previous series of cleanp, caused by r2092.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2093
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Sun, 7 Jun 2009 13:55:29 +0000 (13:55 +0000)]
minidriver build test driver "minidriver"
git-svn-id: svn://svn.berlios.de/openocd/trunk@2092
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:24:27 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Improve variable type: change device_count to unsigned.
- Improves jtag_tap_count_enabled() API too (now returns unsigned).
git-svn-id: svn://svn.berlios.de/openocd/trunk@2091
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:24:20 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Limit scope: move tap and bit_count variables to point of first use.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2090
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:24:12 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor TAP ID matching into new helper function.
- Simplifies the main jtag_examine_chain loop logic considerably.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2089
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:24:03 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Minor whitespace and style cleanups in body of jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2088
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:23:50 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Add helper to check for the terminating ID during jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2087
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:23:40 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor end-of-chain verfication into new helper routine.
- Change 'unexpected' local variable name to 'triggered' and type to bool.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2086
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:23:30 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor output of accepted/incorrect/expected TAP IDs into static helper.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2085
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:23:13 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor initial chain examination check into new static helper.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2084
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:23:03 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor JTAG chain examination into static helper function.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2083
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:22:53 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logical test of expected_id count.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2082
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:22:42 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logic test for unexpected TAP (no IDs).
git-svn-id: svn://svn.berlios.de/openocd/trunk@2081
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:22:34 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logic test for tap in jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2080
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:22:25 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Move definition of maximum JTAG chain size closer to its only uses.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2079
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 05:22:09 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Move JTAG EXTRACT macros out from the middle of jtag_examine_chain.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2078
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Sun, 7 Jun 2009 03:48:21 +0000 (03:48 +0000)]
Clean up handle_endstate_command():
- Merge declaration of state with first use.
- Unindent and remove unnecessary 'else' block.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2077
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Fri, 5 Jun 2009 08:35:24 +0000 (08:35 +0000)]
David Brownell <david-b@pacbell.net> target/at91rm9200.cfg cleanup
git-svn-id: svn://svn.berlios.de/openocd/trunk@2075
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Fri, 5 Jun 2009 06:43:09 +0000 (06:43 +0000)]
remove hacks no longer required to build OpenOCD w/eCos
git-svn-id: svn://svn.berlios.de/openocd/trunk@2074
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Fri, 5 Jun 2009 06:42:20 +0000 (06:42 +0000)]
remove unused include file: strings.h
git-svn-id: svn://svn.berlios.de/openocd/trunk@2073
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Fri, 5 Jun 2009 06:41:54 +0000 (06:41 +0000)]
remove unused include file: inttypes.h
git-svn-id: svn://svn.berlios.de/openocd/trunk@2072
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Fri, 5 Jun 2009 06:37:21 +0000 (06:37 +0000)]
remove unused include file: inttypes.h
git-svn-id: svn://svn.berlios.de/openocd/trunk@2071
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:43:43 +0000 (00:43 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_NextEnabledTap' as 'jtag_tap_next_enabled.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2069
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:43:32 +0000 (00:43 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_NumEnabledTaps' as 'jtag_tap_count_enabled.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2068
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:43:23 +0000 (00:43 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_NumTotalTaps' as 'jtag_tap_count.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2067
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:43:12 +0000 (00:43 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByJimObj' as 'jtag_tap_by_jim_obj.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2066
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:42:52 +0000 (00:42 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByString' as 'jtag_tap_by_string.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2065
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:42:39 +0000 (00:42 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByAbsPosition' as 'jtag_tap_by_abs_position.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2064
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:42:32 +0000 (00:42 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_TapByPosition' as 'jtag_tap_by_position.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2063
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:42:25 +0000 (00:42 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_AllTaps' as 'jtag_all_taps.'
git-svn-id: svn://svn.berlios.de/openocd/trunk@2062
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:42:17 +0000 (00:42 +0000)]
Eliminate MixedCaps symbol from public JTAG TAP API:
- Purely mechanical transformations to the source files.
- Rename 'jtag_all_taps' as '__jtag_all_taps.'
- Frees original symbol name to rename the accessor function.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2061
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:06:34 +0000 (00:06 +0000)]
Add accessors for jtag_verify; use them in jim command handler.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2060
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:04:12 +0000 (00:04 +0000)]
Add accessors for reset delays; use them in jim command handlers.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2059
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Fri, 5 Jun 2009 00:02:00 +0000 (00:02 +0000)]
Add accessors for speed_khz; use them in jim command handler.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2058
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 23:52:58 +0000 (23:52 +0000)]
Add jtag_get_flush_queue_count accessor to help future factoring.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2057
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 23:49:52 +0000 (23:49 +0000)]
Clean up the JTAG TAP creation handler:
- Factor jtag_tap_init() helper out of the end of jim_newtap_cmd.
- Factor jtag_tap_free() helper out of the error case in jim_newtap_cmd.
- Invert test to improve indentation at the end of jim_newtap_cmd.
- Improve whitespace in the newly factored functions.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2056
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 23:26:58 +0000 (23:26 +0000)]
Clean up the core JTAG TAP APIs:
- Move jtag_tap_name to same location as other TAP functions; export it.
- Factor new jtag_tap_add() from jim_newtap_cmd(); appends TAP to global list.
- Move static chain position counter to global; use in jtag_NumTotalTaps().
- Use jtag_AllTaps for reading tap list, instead of accessing global directly.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2055
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 22:43:34 +0000 (22:43 +0000)]
Change hasKHz to use bool type.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2054
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 22:41:21 +0000 (22:41 +0000)]
Add missing static keywords in JTAG source file.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2053
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 20:05:32 +0000 (20:05 +0000)]
unbreak arm11. TAP_INVALID is used to communicate inband that a special state should be used to lower level fn's in ARM11 code.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2052
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
ntfreak [Thu, 4 Jun 2009 13:45:50 +0000 (13:45 +0000)]
- add support for different TAR autotincrement sizes as per ARM ADI spec.
- set TAR size to 12 bits for Cortex-M3.
- Original patch submitted by Magnus Lundin [lundin@mlu.mine.nu].
git-svn-id: svn://svn.berlios.de/openocd/trunk@2051
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 13:18:07 +0000 (13:18 +0000)]
Rename jtag_add_end_state to jtag_set_end_state since "add" implies that
this fn has something to do with the queue, which it does not as such.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2050
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 13:14:07 +0000 (13:14 +0000)]
Introduce jtag_get_end_state() fn to clarify code a bit.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2049
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 13:05:57 +0000 (13:05 +0000)]
tiny bit of encapsulation of global end state. No longer expose it as a global variable.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2048
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 12:52:54 +0000 (12:52 +0000)]
do not modify global end state from jtag_add_xxx()
git-svn-id: svn://svn.berlios.de/openocd/trunk@2047
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 12:42:21 +0000 (12:42 +0000)]
remove unused code.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2046
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 12:12:38 +0000 (12:12 +0000)]
no longer use jtag_add_xxx() to set end state to TAP_DRPAUSE
git-svn-id: svn://svn.berlios.de/openocd/trunk@2045
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 12:06:31 +0000 (12:06 +0000)]
no longer use jtag_add_xxx() to set end state to TAP_IDLE. Same must be done for TAP_DRPAUSE
git-svn-id: svn://svn.berlios.de/openocd/trunk@2044
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 11:42:34 +0000 (11:42 +0000)]
use assert() to catch TAP_INVALID passed to jtag_add_xxx() fn's.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2043
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 11:33:36 +0000 (11:33 +0000)]
remove TAP_INVALID as argument to jtag_add_xxx() fn's
git-svn-id: svn://svn.berlios.de/openocd/trunk@2042
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 07:05:22 +0000 (07:05 +0000)]
jtag_add_end_state() now returns the value of the global variable and does not modify the global variable if passed TAP_INVALID. This patch has no effect on the current code and is just to prepare upcoming patches.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2041
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Thu, 4 Jun 2009 06:56:22 +0000 (06:56 +0000)]
JTAG_TRST_ASSERTED event cleanup. More clear where and when it is invoked and some duplicate(harmless) invocations avoided.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2040
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 01:22:23 +0000 (01:22 +0000)]
David Brownell <david-b@pacbell.net>:
Update the "General Commands" (a.k.a. "random stuff") chapter,
and associated chunks of other text:
- Switch to @deffn and review everything that's documented
- Improve descriptions of reset events, with reference to
the setup.tcl code which issues them.
- Move one zy1000-specific command to that driver's doc.
- There is no "script" command; remove its doc.
NOTE: Some things missing from this bit of work are:
1- Reviewing the code to catch various *missing* functions,
mostly from "target.c"
2- Alphabetizing and organizing. This chapter is a real
grab-bag with no evident focus or structural principle.
3- Hole-filling and bugfixing with respect to messaging/logging.
Example, what principle could possibly justify the tcl command
output going into the server output/log instead of just the
telnet session?
4- Not just for this chapter ... but there should be a section
with descriptions of all the supported image file formats,
so every image command can just reference that section.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2039
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 01:17:27 +0000 (01:17 +0000)]
David Brownell <david-b@pacbell.net>:
Remove pernicious whitespace from ft2232 driver; as usual,
end-of-line noise, but here also much line-internal stuff.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2038
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 01:16:43 +0000 (01:16 +0000)]
David Brownell <david-b@pacbell.net>:
Minor cleanup of FT2232:
- make Olimex glue warn about Olimex issues instead of JTAGkey issues;
- make some data static+const;
- don't export some internal symbols.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2037
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 00:56:41 +0000 (00:56 +0000)]
David Brownell <david-b@pacbell.net>:
Remove pernicious whitespace from src/jtag/*c files; mostly
the end-of-line flavor for now, although there's more.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2036
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 00:54:25 +0000 (00:54 +0000)]
David Brownell <david-b@pacbell.net>:
Convert the Interface/Dongle Config chapter's section
on drivers to use the @deffn syntax, and integrate the
presentation of the driver-specific commands with the
relevant driver. Alphabetize.
Cross-checked against the code ... several adapters were
not listed, and a few commands weren't.
(Maintainers for the versaloon and zy1000 drivers would be
good candidates to add the commands missing from those
sections...)
git-svn-id: svn://svn.berlios.de/openocd/trunk@2035
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Thu, 4 Jun 2009 00:51:02 +0000 (00:51 +0000)]
David Brownell <david-b@pacbell.net>:
Convert the str9xpec driver info to use @deffn; alphabetize;
add the missing part_id command.
Convert the mflash support to use @deffn; alphabetize.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2034
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Wed, 3 Jun 2009 16:36:01 +0000 (16:36 +0000)]
use assert() for obscure check on illegal arguments upon trst being asserted while commands are queued
git-svn-id: svn://svn.berlios.de/openocd/trunk@2033
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Wed, 3 Jun 2009 12:12:21 +0000 (12:12 +0000)]
remove unused code path.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2032
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Wed, 3 Jun 2009 07:55:56 +0000 (07:55 +0000)]
catchup with jtag refactoring.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2031
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 07:06:37 +0000 (07:06 +0000)]
Move JTAG command handling implementation into its own source file.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2030
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 06:29:09 +0000 (06:29 +0000)]
Finish JTAG header file modularization; command factoring follows.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2029
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
oharboe [Wed, 3 Jun 2009 06:27:57 +0000 (06:27 +0000)]
added missing extern to jtag_command_queue definition.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2028
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 06:08:07 +0000 (06:08 +0000)]
Move JTAG command APIs into new jtag/commands.h header file.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2027
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 04:44:38 +0000 (04:44 +0000)]
Improve remaining documentation that was causing Doxygen warnings.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2026
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 04:37:51 +0000 (04:37 +0000)]
Improve in-source documentation that was causing Doxygen warnings.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2025
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 02:57:55 +0000 (02:57 +0000)]
Add architectural introduction to the JTAG module in The Manual.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2024
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 02:56:20 +0000 (02:56 +0000)]
Improve logger script to expose warnings and errors in the output.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2023
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 02:17:26 +0000 (02:17 +0000)]
Improve doxygen markup of PATCHES file, link to new primer.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2022
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 02:12:44 +0000 (02:12 +0000)]
Add draft of Patching Primer in The Manual; update primer page.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2021
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 02:11:09 +0000 (02:11 +0000)]
Update TODO file with more content and better style.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2020
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 01:51:04 +0000 (01:51 +0000)]
Enable or add doxygen comments to the public JTAG API.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2019
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 01:39:04 +0000 (01:39 +0000)]
Update documentationf or jtag_interface structure members.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2018
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 01:29:01 +0000 (01:29 +0000)]
Remove vestigal tap_transition type from public jtag API.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2017
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 01:26:01 +0000 (01:26 +0000)]
Remove interface.h from public JTAG header, include it where required.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2016
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 01:23:48 +0000 (01:23 +0000)]
Expose tap_state_by_name TAP helper available in public API.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2015
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 00:59:13 +0000 (00:59 +0000)]
David Brownell <david-b@pacbell.net>:
Update docs for most of the remaining commands in jtag.c:
- switch to @deffn
- these are just the "low level" JTAG commands
- resolve much goofage!
* remove docs for non-existent commands
* add missing docs for some existing commands
* fix incorrect docs for some commands
- just index TAP states overall, not individually
- current name is "RUN/IDLE" not "IDLE"
Cross checked against the source.
This also creates an "Interface Drivers" section, analagous to how
(NOR) Flash and NAND drivers are presented; that's not yet sorted.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2014
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 00:56:50 +0000 (00:56 +0000)]
David Brownell <david-b@pacbell.net>:
Rework the TAP creation documentation.
- Try to use "TAP" not "tap" everywhere; it's an acronym.
- Update the associated "target config files" section:
* reference the "TAP Creation" chapter for details
* simplify: reference interesting multi-tap config files
* let's not forget CPU configuration (*before* workspace setup)
* streamline it a bit
* move that workspace-vs-mmu issue to a better location
- Clean up TAP creation doc mess
* switch to @deffn
* (re)organize the remaining stuff
* reference the "Config File Guidelines" chapter
- Tweak the "Target Configuration" chapter
* rename as "CPU configuration"; unconfuse vs. target/*.cfg
* bring out that it's not just there for GDB
* move TAP events to the TAP chapter, where they belong (bugfix)
git-svn-id: svn://svn.berlios.de/openocd/trunk@2013
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
zwelch [Wed, 3 Jun 2009 00:45:21 +0000 (00:45 +0000)]
Move the JTAG cable interface API implementation
- Cloned the src/jtag/jtag.c file to src/jtag/interface.c.
- For each for of those files, deleted the contents of the other.
- Add new source file to automake input.
git-svn-id: svn://svn.berlios.de/openocd/trunk@2012
b42882b7-edfa-0310-969c-
e2dbd0fdcd60
Linking to existing account procedure
If you already have an account and want to add another login method
you
MUST first sign in with your existing account and
then change URL to read
https://review.openocd.org/login/?link
to get to this page again but this time it'll work for linking. Thank you.
SSH host keys fingerprints
1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=.. |
|+o.. . |
|*.o . . |
|+B . . . |
|Bo. = o S |
|Oo.+ + = |
|oB=.* = . o |
| =+=.+ + E |
|. .=o . o |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)