ARM semihosting: fix writing to stdout
[openocd.git] / src / target / target.c
index 70fd8f2b71c6a1b96092c0b0c5a190e1a0150f63..1eb65a62e0f40f3938062a03b2957e0be955f4da 100644 (file)
 #include "config.h"
 #endif
 
+#include <helper/time_support.h>
+#include <jtag/jtag.h>
+
 #include "target.h"
 #include "target_type.h"
 #include "target_request.h"
 #include "breakpoints.h"
-#include "time_support.h"
 #include "register.h"
 #include "trace.h"
 #include "image.h"
-#include "jtag.h"
-
 
-static int jim_mcrmrc(Jim_Interp *interp, int argc, Jim_Obj *const *argv);
 
-static int target_array2mem(Jim_Interp *interp, struct target *target, int argc, Jim_Obj *const *argv);
-static int target_mem2array(Jim_Interp *interp, struct target *target, int argc, Jim_Obj *const *argv);
+static int target_array2mem(Jim_Interp *interp, struct target *target,
+               int argc, Jim_Obj *const *argv);
+static int target_mem2array(Jim_Interp *interp, struct target *target,
+               int argc, Jim_Obj *const *argv);
 
 /* targets */
 extern struct target_type arm7tdmi_target;
@@ -65,6 +66,8 @@ extern struct target_type cortexa8_target;
 extern struct target_type arm11_target;
 extern struct target_type mips_m4k_target;
 extern struct target_type avr_target;
+extern struct target_type dsp563xx_target;
+extern struct target_type testee_target;
 
 struct target_type *target_types[] =
 {
@@ -83,6 +86,8 @@ struct target_type *target_types[] =
        &arm11_target,
        &mips_m4k_target,
        &avr_target,
+       &dsp563xx_target,
+       &testee_target,
        NULL,
 };
 
@@ -90,7 +95,7 @@ struct target *all_targets = NULL;
 struct target_event_callback *target_event_callbacks = NULL;
 struct target_timer_callback *target_timer_callbacks = NULL;
 
-const Jim_Nvp nvp_assert[] = {
+static const Jim_Nvp nvp_assert[] = {
        { .name = "assert", NVP_ASSERT },
        { .name = "deassert", NVP_DEASSERT },
        { .name = "T", NVP_ASSERT },
@@ -100,7 +105,7 @@ const Jim_Nvp nvp_assert[] = {
        { .name = NULL, .value = -1 }
 };
 
-const Jim_Nvp nvp_error_target[] = {
+static const Jim_Nvp nvp_error_target[] = {
        { .value = ERROR_TARGET_INVALID, .name = "err-invalid" },
        { .value = ERROR_TARGET_INIT_FAILED, .name = "err-init-failed" },
        { .value = ERROR_TARGET_TIMEOUT, .name = "err-timeout" },
@@ -145,6 +150,7 @@ static const Jim_Nvp nvp_target_event[] = {
        { .value = TARGET_EVENT_RESET_START, .name = "reset-start" },
 
        { .value = TARGET_EVENT_RESET_ASSERT_PRE,    .name = "reset-assert-pre" },
+       { .value = TARGET_EVENT_RESET_ASSERT,        .name = "reset-assert" },
        { .value = TARGET_EVENT_RESET_ASSERT_POST,   .name = "reset-assert-post" },
        { .value = TARGET_EVENT_RESET_DEASSERT_PRE,  .name = "reset-deassert-pre" },
        { .value = TARGET_EVENT_RESET_DEASSERT_POST, .name = "reset-deassert-post" },
@@ -152,8 +158,8 @@ static const Jim_Nvp nvp_target_event[] = {
        { .value = TARGET_EVENT_RESET_HALT_POST,     .name = "reset-halt-post" },
        { .value = TARGET_EVENT_RESET_WAIT_PRE,      .name = "reset-wait-pre" },
        { .value = TARGET_EVENT_RESET_WAIT_POST,     .name = "reset-wait-post" },
-       { .value = TARGET_EVENT_RESET_INIT , .name = "reset-init" },
-       { .value = TARGET_EVENT_RESET_END, .name = "reset-end" },
+       { .value = TARGET_EVENT_RESET_INIT,          .name = "reset-init" },
+       { .value = TARGET_EVENT_RESET_END,           .name = "reset-end" },
 
        { .value = TARGET_EVENT_EXAMINE_START, .name = "examine-start" },
        { .value = TARGET_EVENT_EXAMINE_END, .name = "examine-end" },
@@ -177,7 +183,7 @@ static const Jim_Nvp nvp_target_event[] = {
        { .name = NULL, .value = -1 }
 };
 
-const Jim_Nvp nvp_target_state[] = {
+static const Jim_Nvp nvp_target_state[] = {
        { .name = "unknown", .value = TARGET_UNKNOWN },
        { .name = "running", .value = TARGET_RUNNING },
        { .name = "halted",  .value = TARGET_HALTED },
@@ -186,7 +192,7 @@ const Jim_Nvp nvp_target_state[] = {
        { .name = NULL, .value = -1 },
 };
 
-const Jim_Nvp nvp_target_debug_reason [] = {
+static const Jim_Nvp nvp_target_debug_reason [] = {
        { .name = "debug-request"            , .value = DBG_REASON_DBGRQ },
        { .name = "breakpoint"               , .value = DBG_REASON_BREAKPOINT },
        { .name = "watchpoint"               , .value = DBG_REASON_WATCHPOINT },
@@ -197,7 +203,7 @@ const Jim_Nvp nvp_target_debug_reason [] = {
        { .name = NULL, .value = -1 },
 };
 
-const Jim_Nvp nvp_target_endian[] = {
+static const Jim_Nvp nvp_target_endian[] = {
        { .name = "big",    .value = TARGET_BIG_ENDIAN },
        { .name = "little", .value = TARGET_LITTLE_ENDIAN },
        { .name = "be",     .value = TARGET_BIG_ENDIAN },
@@ -205,7 +211,7 @@ const Jim_Nvp nvp_target_endian[] = {
        { .name = NULL,     .value = -1 },
 };
 
-const Jim_Nvp nvp_reset_modes[] = {
+static const Jim_Nvp nvp_reset_modes[] = {
        { .name = "unknown", .value = RESET_UNKNOWN },
        { .name = "run"    , .value = RESET_RUN },
        { .name = "halt"   , .value = RESET_HALT },
@@ -213,6 +219,19 @@ const Jim_Nvp nvp_reset_modes[] = {
        { .name = NULL     , .value = -1 },
 };
 
+const char *debug_reason_name(struct target *t)
+{
+       const char *cp;
+
+       cp = Jim_Nvp_value2name_simple(nvp_target_debug_reason,
+                       t->debug_reason)->name;
+       if (!cp) {
+               LOG_ERROR("Invalid debug reason: %d", (int)(t->debug_reason));
+               cp = "(*BUG*unknown*BUG*)";
+       }
+       return cp;
+}
+
 const char *
 target_state_name( struct target *t )
 {
@@ -446,18 +465,23 @@ int target_process_reset(struct command_context *cmd_ctx, enum target_reset_mode
        jtag_poll_set_enabled(false);
 
        sprintf(buf, "ocd_process_reset %s", n->name);
-       retval = Jim_Eval(interp, buf);
+       retval = Jim_Eval(cmd_ctx->interp, buf);
 
        jtag_poll_set_enabled(save_poll);
 
        if (retval != JIM_OK) {
-               Jim_PrintErrorMessage(interp);
+               Jim_PrintErrorMessage(cmd_ctx->interp);
                return ERROR_FAIL;
        }
 
        /* We want any events to be processed before the prompt */
        retval = target_call_timer_callbacks_now();
 
+       struct target *target;
+       for (target = all_targets; target; target = target->next) {
+               target->type->check_reset(target);
+       }
+
        return retval;
 }
 
@@ -480,6 +504,12 @@ static int default_examine(struct target *target)
        return ERROR_OK;
 }
 
+/* no check by default */
+static int default_check_reset(struct target *target)
+{
+       return ERROR_OK;
+}
+
 int target_examine_one(struct target *target)
 {
        return target->type->examine(target);
@@ -520,7 +550,7 @@ int target_examine(void)
        }
        return retval;
 }
-const char *target_get_name(struct target *target)
+const char *target_type_name(struct target *target)
 {
        return target->type->name;
 }
@@ -554,7 +584,7 @@ static int target_soft_reset_halt_imp(struct target *target)
        }
        if (!target->type->soft_reset_halt_imp) {
                LOG_ERROR("Target %s does not support soft_reset_halt",
-                               target->cmd_name);
+                               target_name(target));
                return ERROR_FAIL;
        }
        return target->type->soft_reset_halt_imp(target);
@@ -603,6 +633,10 @@ int target_bulk_write_memory(struct target *target,
 int target_add_breakpoint(struct target *target,
                struct breakpoint *breakpoint)
 {
+       if (target->state != TARGET_HALTED) {
+               LOG_WARNING("target %s is not halted", target->cmd_name);
+               return ERROR_TARGET_NOT_HALTED;
+       }
        return target->type->add_breakpoint(target, breakpoint);
 }
 int target_remove_breakpoint(struct target *target,
@@ -614,6 +648,10 @@ int target_remove_breakpoint(struct target *target,
 int target_add_watchpoint(struct target *target,
                struct watchpoint *watchpoint)
 {
+       if (target->state != TARGET_HALTED) {
+               LOG_WARNING("target %s is not halted", target->cmd_name);
+               return ERROR_TARGET_NOT_HALTED;
+       }
        return target->type->add_watchpoint(target, watchpoint);
 }
 int target_remove_watchpoint(struct target *target,
@@ -654,216 +692,150 @@ static void target_reset_examined(struct target *target)
        target->examined = false;
 }
 
-
-
-static int default_mrc(struct target *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm, uint32_t *value)
+static int
+err_read_phys_memory(struct target *target, uint32_t address,
+               uint32_t size, uint32_t count, uint8_t *buffer)
 {
        LOG_ERROR("Not implemented: %s", __func__);
        return ERROR_FAIL;
 }
 
-static int default_mcr(struct target *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm, uint32_t value)
+static int
+err_write_phys_memory(struct target *target, uint32_t address,
+               uint32_t size, uint32_t count, uint8_t *buffer)
 {
        LOG_ERROR("Not implemented: %s", __func__);
        return ERROR_FAIL;
 }
 
-static int arm_cp_check(struct target *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm)
-{
-       /* basic check */
-       if (!target_was_examined(target))
-       {
-               LOG_ERROR("Target not examined yet");
-               return ERROR_FAIL;
-       }
-
-       if ((cpnum <0) || (cpnum > 15))
-       {
-               LOG_ERROR("Illegal co-processor %d", cpnum);
-               return ERROR_FAIL;
-       }
-
-       if (op1 > 7)
-       {
-               LOG_ERROR("Illegal op1");
-               return ERROR_FAIL;
-       }
-
-       if (op2 > 7)
-       {
-               LOG_ERROR("Illegal op2");
-               return ERROR_FAIL;
-       }
-
-       if (CRn > 15)
-       {
-               LOG_ERROR("Illegal CRn");
-               return ERROR_FAIL;
-       }
-
-       if (CRm > 15)
-       {
-               LOG_ERROR("Illegal CRm");
-               return ERROR_FAIL;
-       }
-
-       return ERROR_OK;
-}
+static int handle_target(void *priv);
 
-int target_mrc(struct target *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm, uint32_t *value)
+static int target_init_one(struct command_context *cmd_ctx,
+               struct target *target)
 {
-       int retval;
-
-       retval = arm_cp_check(target, cpnum, op1, op2, CRn, CRm);
-       if (retval != ERROR_OK)
-               return retval;
+       target_reset_examined(target);
 
-       return target->type->mrc(target, cpnum, op1, op2, CRn, CRm, value);
-}
+       struct target_type *type = target->type;
+       if (type->examine == NULL)
+               type->examine = default_examine;
 
-int target_mcr(struct target *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm, uint32_t value)
-{
-       int retval;
+       if (type->check_reset== NULL)
+               type->check_reset = default_check_reset;
 
-       retval = arm_cp_check(target, cpnum, op1, op2, CRn, CRm);
-       if (retval != ERROR_OK)
+       int retval = type->init_target(cmd_ctx, target);
+       if (ERROR_OK != retval)
+       {
+               LOG_ERROR("target '%s' init failed", target_name(target));
                return retval;
+       }
 
-       return target->type->mcr(target, cpnum, op1, op2, CRn, CRm, value);
-}
-
-static int
-err_read_phys_memory(struct target *target, uint32_t address,
-               uint32_t size, uint32_t count, uint8_t *buffer)
-{
-       LOG_ERROR("Not implemented: %s", __func__);
-       return ERROR_FAIL;
-}
-
-static int
-err_write_phys_memory(struct target *target, uint32_t address,
-               uint32_t size, uint32_t count, uint8_t *buffer)
-{
-       LOG_ERROR("Not implemented: %s", __func__);
-       return ERROR_FAIL;
-}
+       /**
+        * @todo get rid of those *memory_imp() methods, now that all
+        * callers are using target_*_memory() accessors ... and make
+        * sure the "physical" paths handle the same issues.
+        */
+       /* a non-invasive way(in terms of patches) to add some code that
+        * runs before the type->write/read_memory implementation
+        */
+       type->write_memory_imp = target->type->write_memory;
+       type->write_memory = target_write_memory_imp;
 
-int target_init(struct command_context *cmd_ctx)
-{
-       struct target *target;
-       int retval;
+       type->read_memory_imp = target->type->read_memory;
+       type->read_memory = target_read_memory_imp;
 
-       for (target = all_targets; target; target = target->next) {
-               struct target_type *type = target->type;
+       type->soft_reset_halt_imp = target->type->soft_reset_halt;
+       type->soft_reset_halt = target_soft_reset_halt_imp;
 
-               target_reset_examined(target);
-               if (target->type->examine == NULL)
-               {
-                       target->type->examine = default_examine;
-               }
+       type->run_algorithm_imp = target->type->run_algorithm;
+       type->run_algorithm = target_run_algorithm_imp;
 
-               if ((retval = target->type->init_target(cmd_ctx, target)) != ERROR_OK)
+       /* Sanity-check MMU support ... stub in what we must, to help
+        * implement it in stages, but warn if we need to do so.
+        */
+       if (type->mmu)
+       {
+               if (type->write_phys_memory == NULL)
                {
-                       LOG_ERROR("target '%s' init failed", target_get_name(target));
-                       return retval;
+                       LOG_ERROR("type '%s' is missing write_phys_memory",
+                                       type->name);
+                       type->write_phys_memory = err_write_phys_memory;
                }
-
-               /**
-                * @todo MCR/MRC are ARM-specific; don't require them in
-                * all targets, or for ARMs without coprocessors.
-                */
-               if (target->type->mcr == NULL)
-               {
-                       target->type->mcr = default_mcr;
-               } else
+               if (type->read_phys_memory == NULL)
                {
-                       /* FIX! multiple targets will generally register global commands
-                        * multiple times. Only register this one if *one* of the
-                        * targets need the command. Hmm... make it a command on the
-                        * Jim Tcl target object?
-                        */
-                       register_jim(cmd_ctx, "mcr", jim_mcrmrc, "write coprocessor <cpnum> <op1> <op2> <CRn> <CRm> <value>");
+                       LOG_ERROR("type '%s' is missing read_phys_memory",
+                                       type->name);
+                       type->read_phys_memory = err_read_phys_memory;
                }
-
-               if (target->type->mrc == NULL)
-               {
-                       target->type->mrc = default_mrc;
-               } else
+               if (type->virt2phys == NULL)
                {
-                       register_jim(cmd_ctx, "mrc", jim_mcrmrc, "read coprocessor <cpnum> <op1> <op2> <CRn> <CRm>");
+                       LOG_ERROR("type '%s' is missing virt2phys", type->name);
+                       type->virt2phys = identity_virt2phys;
                }
-
-
-               /**
-                * @todo get rid of those *memory_imp() methods, now that all
-                * callers are using target_*_memory() accessors ... and make
-                * sure the "physical" paths handle the same issues.
-                */
-
-               /* a non-invasive way(in terms of patches) to add some code that
-                * runs before the type->write/read_memory implementation
-                */
-               target->type->write_memory_imp = target->type->write_memory;
-               target->type->write_memory = target_write_memory_imp;
-               target->type->read_memory_imp = target->type->read_memory;
-               target->type->read_memory = target_read_memory_imp;
-               target->type->soft_reset_halt_imp = target->type->soft_reset_halt;
-               target->type->soft_reset_halt = target_soft_reset_halt_imp;
-               target->type->run_algorithm_imp = target->type->run_algorithm;
-               target->type->run_algorithm = target_run_algorithm_imp;
-
-               /* Sanity-check MMU support ... stub in what we must, to help
-                * implement it in stages, but warn if we need to do so.
-                */
-               if (type->mmu) {
-                       if (type->write_phys_memory == NULL) {
-                               LOG_ERROR("type '%s' is missing %s",
-                                               type->name,
-                                               "write_phys_memory");
-                               type->write_phys_memory = err_write_phys_memory;
-                       }
-                       if (type->read_phys_memory == NULL) {
-                               LOG_ERROR("type '%s' is missing %s",
-                                               type->name,
-                                               "read_phys_memory");
-                               type->read_phys_memory = err_read_phys_memory;
-                       }
-                       if (type->virt2phys == NULL) {
-                               LOG_ERROR("type '%s' is missing %s",
-                                               type->name,
-                                               "virt2phys");
-                               type->virt2phys = identity_virt2phys;
-                       }
-
+       }
+       else
+       {
                /* Make sure no-MMU targets all behave the same:  make no
                 * distinction between physical and virtual addresses, and
                 * ensure that virt2phys() is always an identity mapping.
                 */
-               } else {
-                       if (type->write_phys_memory
-                                       || type->read_phys_memory
-                                       || type->virt2phys)
-                               LOG_WARNING("type '%s' has broken MMU hooks",
-                                               type->name);
-
-                       type->mmu = no_mmu;
-                       type->write_phys_memory = type->write_memory;
-                       type->read_phys_memory = type->read_memory;
-                       type->virt2phys = identity_virt2phys;
+               if (type->write_phys_memory || type->read_phys_memory
+                               || type->virt2phys)
+               {
+                       LOG_WARNING("type '%s' has bad MMU hooks", type->name);
                }
+
+               type->mmu = no_mmu;
+               type->write_phys_memory = type->write_memory;
+               type->read_phys_memory = type->read_memory;
+               type->virt2phys = identity_virt2phys;
        }
+       return ERROR_OK;
+}
+
+int target_init(struct command_context *cmd_ctx)
+{
+       struct target *target;
+       int retval;
 
-       if (all_targets)
+       for (target = all_targets; target; target = target->next)
        {
-               if ((retval = target_register_user_commands(cmd_ctx)) != ERROR_OK)
-                       return retval;
-               if ((retval = target_register_timer_callback(handle_target, 100, 1, NULL)) != ERROR_OK)
+               retval = target_init_one(cmd_ctx, target);
+               if (ERROR_OK != retval)
                        return retval;
        }
 
+       if (!all_targets)
+               return ERROR_OK;
+
+       retval = target_register_user_commands(cmd_ctx);
+       if (ERROR_OK != retval)
+               return retval;
+
+       retval = target_register_timer_callback(&handle_target,
+                       100, 1, cmd_ctx->interp);
+       if (ERROR_OK != retval)
+               return retval;
+
        return ERROR_OK;
 }
 
+COMMAND_HANDLER(handle_target_init_command)
+{
+       if (CMD_ARGC != 0)
+               return ERROR_COMMAND_SYNTAX_ERROR;
+
+       static bool target_initialized = false;
+       if (target_initialized)
+       {
+               LOG_INFO("'target init' has already been called");
+               return ERROR_OK;
+       }
+       target_initialized = true;
+
+       LOG_DEBUG("Initializing targets...");
+       return target_init(CMD_CTX);
+}
+
 int target_register_event_callback(int (*callback)(struct target *target, enum target_event event, void *priv), void *priv)
 {
        struct target_event_callback **callbacks_p = &target_event_callbacks;
@@ -1687,8 +1659,8 @@ DumpTargets:
                command_print(CMD_CTX, "%2d%c %-18s %-10s %-6s %-18s %s",
                                          target->target_number,
                                          marker,
-                                         target->cmd_name,
-                                         target_get_name(target),
+                                         target_name(target),
+                                         target_type_name(target),
                                          Jim_Nvp_value2name_simple(nvp_target_endian,
                                                                target->endianness)->name,
                                          target->tap->dotted_name,
@@ -1777,8 +1749,9 @@ static void target_call_event_callbacks_all(enum target_event e) {
 }
 
 /* process target state changes */
-int handle_target(void *priv)
+static int handle_target(void *priv)
 {
+       Jim_Interp *interp = (Jim_Interp *)priv;
        int retval = ERROR_OK;
 
        /* we do not want to recurse here... */
@@ -1794,6 +1767,7 @@ int handle_target(void *priv)
                int did_something = 0;
                if (runSrstAsserted)
                {
+                       LOG_INFO("Waking up GDB, srst asserted detected.");
                        target_call_event_callbacks_all(TARGET_EVENT_GDB_HALT);
                        Jim_Eval(interp, "srst_asserted");
                        did_something = 1;
@@ -1805,6 +1779,7 @@ int handle_target(void *priv)
                }
                if (runPowerDropout)
                {
+                       LOG_INFO("Waking up GDB, power dropout detected.");
                        target_call_event_callbacks_all(TARGET_EVENT_GDB_HALT);
                        Jim_Eval(interp, "power_dropout");
                        did_something = 1;
@@ -1847,6 +1822,14 @@ int handle_target(void *priv)
                        /* polling may fail silently until the target has been examined */
                        if ((retval = target_poll(target)) != ERROR_OK)
                        {
+                               /* FIX!!!!! If we add a LOG_INFO() here to output a line in GDB
+                                * *why* we are aborting GDB, then we'll spam telnet when the
+                                * poll is failing persistently.
+                                *
+                                * If we could implement an event that detected the
+                                * target going from non-pollable to pollable, we could issue
+                                * an error only upon the transition.
+                                */
                                target_call_event_callbacks(target, TARGET_EVENT_GDB_HALT);
                                return retval;
                        }
@@ -2197,11 +2180,12 @@ static void handle_md_output(struct command_context *cmd_ctx,
        const char *value_fmt;
        switch (size) {
        case 4: value_fmt = "%8.8x "; break;
-       case 2: value_fmt = "%4.2x "; break;
+       case 2: value_fmt = "%4.4x "; break;
        case 1: value_fmt = "%2.2x "; break;
        default:
+               /* "can't happen", caller checked */
                LOG_ERROR("invalid memory read size: %u", size);
-               exit(-1);
+               return;
        }
 
        for (unsigned i = 0; i < count; i++)
@@ -2530,7 +2514,7 @@ COMMAND_HANDLER(handle_dump_image_command)
        if ((ERROR_OK == retval) && (duration_measure(&bench) == ERROR_OK))
        {
                command_print(CMD_CTX,
-                               "dumped %zu bytes in %fs (%0.3f kb/s)", fileio.size,
+                               "dumped %ld bytes in %fs (%0.3f kb/s)", (long)fileio.size,
                                duration_elapsed(&bench), duration_kbps(&bench, fileio.size));
        }
 
@@ -3002,7 +2986,8 @@ static void writeGmon(uint32_t *samples, uint32_t sampleNum, const char *filenam
        fclose(f);
 }
 
-/* profiling samples the CPU PC as quickly as OpenOCD is able, which will be used as a random sampling of PC */
+/* profiling samples the CPU PC as quickly as OpenOCD is able,
+ * which will be used as a random sampling of PC */
 COMMAND_HANDLER(handle_profile_command)
 {
        struct target *target = get_current_target(CMD_CTX);
@@ -3018,6 +3003,12 @@ COMMAND_HANDLER(handle_profile_command)
 
        timeval_add_time(&timeout, offset, 0);
 
+       /**
+        * @todo: Some cores let us sample the PC without the
+        * annoying halt/resume step; for example, ARMv7 PCSR.
+        * Provide a way to use that more efficient mechanism.
+        */
+
        command_print(CMD_CTX, "Starting profiling. Halting and resuming the target as often as we can...");
 
        static const int maxSample = 10000;
@@ -3145,7 +3136,6 @@ static int target_mem2array(Jim_Interp *interp, struct target *target, int argc,
        uint32_t count;
        uint32_t v;
        const char *varname;
-       uint8_t buffer[4096];
        int  n, e, retval;
        uint32_t i;
 
@@ -3227,14 +3217,20 @@ static int target_mem2array(Jim_Interp *interp, struct target *target, int argc,
 
        /* index counter */
        n = 0;
+
+       size_t buffersize = 4096;
+       uint8_t *buffer = malloc(buffersize);
+       if (buffer == NULL)
+               return JIM_ERR;
+
        /* assume ok */
        e = JIM_OK;
        while (len) {
                /* Slurp... in buffer size chunks */
 
                count = len; /* in objects.. */
-               if (count > (sizeof(buffer)/width)) {
-                       count = (sizeof(buffer)/width);
+               if (count > (buffersize/width)) {
+                       count = (buffersize/width);
                }
 
                retval = target_read_memory(target, addr, width, count, buffer);
@@ -3268,6 +3264,8 @@ static int target_mem2array(Jim_Interp *interp, struct target *target, int argc,
                }
        }
 
+       free(buffer);
+
        Jim_SetResult(interp, Jim_NewEmptyStringObj(interp));
 
        return JIM_OK;
@@ -3322,7 +3320,9 @@ static int jim_array2mem(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
 
        return target_array2mem(interp,target, argc-1, argv + 1);
 }
-static int target_array2mem(Jim_Interp *interp, struct target *target, int argc, Jim_Obj *const *argv)
+
+static int target_array2mem(Jim_Interp *interp, struct target *target,
+               int argc, Jim_Obj *const *argv)
 {
        long l;
        uint32_t width;
@@ -3331,7 +3331,6 @@ static int target_array2mem(Jim_Interp *interp, struct target *target, int argc,
        uint32_t count;
        uint32_t v;
        const char *varname;
-       uint8_t buffer[4096];
        int  n, e, retval;
        uint32_t i;
 
@@ -3341,7 +3340,7 @@ static int target_array2mem(Jim_Interp *interp, struct target *target, int argc,
         * argv[4] = count to write
         */
        if (argc != 4) {
-               Jim_WrongNumArgs(interp, 1, argv, "varname width addr nelems");
+               Jim_WrongNumArgs(interp, 0, argv, "varname width addr nelems");
                return JIM_ERR;
        }
        varname = Jim_GetString(argv[0], &len);
@@ -3415,12 +3414,18 @@ static int target_array2mem(Jim_Interp *interp, struct target *target, int argc,
        n = 0;
        /* assume ok */
        e = JIM_OK;
+
+       size_t buffersize = 4096;
+       uint8_t *buffer = malloc(buffersize);
+       if (buffer == NULL)
+               return JIM_ERR;
+
        while (len) {
                /* Slurp... in buffer size chunks */
 
                count = len; /* in objects.. */
-               if (count > (sizeof(buffer)/width)) {
-                       count = (sizeof(buffer)/width);
+               if (count > (buffersize/width)) {
+                       count = (buffersize/width);
                }
 
                v = 0; /* shut up gcc */
@@ -3454,6 +3459,8 @@ static int target_array2mem(Jim_Interp *interp, struct target *target, int argc,
                }
        }
 
+       free(buffer);
+
        Jim_SetResult(interp, Jim_NewEmptyStringObj(interp));
 
        return JIM_OK;
@@ -3486,19 +3493,33 @@ void target_handle_event(struct target *target, enum target_event e)
                if (teap->event == e) {
                        LOG_DEBUG("target: (%d) %s (%s) event: %d (%s) action: %s",
                                           target->target_number,
-                                          target->cmd_name,
-                                          target_get_name(target),
+                                          target_name(target),
+                                          target_type_name(target),
                                           e,
                                           Jim_Nvp_value2name_simple(nvp_target_event, e)->name,
                                           Jim_GetString(teap->body, NULL));
-                       if (Jim_EvalObj(interp, teap->body) != JIM_OK)
+                       if (Jim_EvalObj(teap->interp, teap->body) != JIM_OK)
                        {
-                               Jim_PrintErrorMessage(interp);
+                               Jim_PrintErrorMessage(teap->interp);
                        }
                }
        }
 }
 
+/**
+ * Returns true only if the target has a handler for the specified event.
+ */
+bool target_has_event_action(struct target *target, enum target_event event)
+{
+       struct target_event_action *teap;
+
+       for (teap = target->event_action; teap != NULL; teap = teap->next) {
+               if (teap->event == event)
+                       return true;
+       }
+       return false;
+}
+
 enum target_cfg_param {
        TCFG_TYPE,
        TCFG_EVENT,
@@ -3561,16 +3582,20 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                case TCFG_TYPE:
                        /* not setable */
                        if (goi->isconfigure) {
-                               Jim_SetResult_sprintf(goi->interp, "not setable: %s", n->name);
+                               Jim_SetResult_sprintf(goi->interp,
+                                               "not settable: %s", n->name);
                                return JIM_ERR;
                        } else {
                        no_params:
                                if (goi->argc != 0) {
-                                       Jim_WrongNumArgs(goi->interp, goi->argc, goi->argv, "NO PARAMS");
+                                       Jim_WrongNumArgs(goi->interp,
+                                                       goi->argc, goi->argv,
+                                                       "NO PARAMS");
                                        return JIM_ERR;
                                }
                        }
-                       Jim_SetResultString(goi->interp, target_get_name(target), -1);
+                       Jim_SetResultString(goi->interp,
+                                       target_type_name(target), -1);
                        /* loop for more */
                        break;
                case TCFG_EVENT:
@@ -3617,9 +3642,10 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                                replace = false;
                                        }
                                        teap->event = n->value;
+                                       teap->interp = goi->interp;
                                        Jim_GetOpt_Obj(goi, &o);
                                        if (teap->body) {
-                                               Jim_DecrRefCount(interp, teap->body);
+                                               Jim_DecrRefCount(teap->interp, teap->body);
                                        }
                                        teap->body  = Jim_DuplicateObj(goi->interp, o);
                                        /*
@@ -3667,7 +3693,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                        goto no_params;
                                }
                        }
-                       Jim_SetResult(interp, Jim_NewIntObj(goi->interp, target->working_area_virt));
+                       Jim_SetResult(goi->interp, Jim_NewIntObj(goi->interp, target->working_area_virt));
                        /* loop for more */
                        break;
 
@@ -3685,7 +3711,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                        goto no_params;
                                }
                        }
-                       Jim_SetResult(interp, Jim_NewIntObj(goi->interp, target->working_area_phys));
+                       Jim_SetResult(goi->interp, Jim_NewIntObj(goi->interp, target->working_area_phys));
                        /* loop for more */
                        break;
 
@@ -3702,7 +3728,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                        goto no_params;
                                }
                        }
-                       Jim_SetResult(interp, Jim_NewIntObj(goi->interp, target->working_area_size));
+                       Jim_SetResult(goi->interp, Jim_NewIntObj(goi->interp, target->working_area_size));
                        /* loop for more */
                        break;
 
@@ -3720,7 +3746,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                        goto no_params;
                                }
                        }
-                       Jim_SetResult(interp, Jim_NewIntObj(goi->interp, target->backup_working_area));
+                       Jim_SetResult(goi->interp, Jim_NewIntObj(goi->interp, target->backup_working_area));
                        /* loop for more e*/
                        break;
 
@@ -3787,7 +3813,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
                                        goto no_params;
                                }
                        }
-                       Jim_SetResultString(interp, target->tap->dotted_name, -1);
+                       Jim_SetResultString(goi->interp, target->tap->dotted_name, -1);
                        /* loop for more e*/
                        break;
                }
@@ -3798,422 +3824,561 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
        return JIM_OK;
 }
 
-/** this is the 'tcl' handler for the target specific command */
-static int tcl_target_func(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+static int
+jim_target_configure(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
 {
        Jim_GetOptInfo goi;
-       jim_wide a,b,c;
-       int x,y,z;
-       uint8_t  target_buf[32];
-       Jim_Nvp *n;
-       struct target *target;
-       struct command_context *cmd_ctx;
-       int e;
 
-       enum {
-               TS_CMD_CONFIGURE,
-               TS_CMD_CGET,
-
-               TS_CMD_MWW, TS_CMD_MWH, TS_CMD_MWB,
-               TS_CMD_MDW, TS_CMD_MDH, TS_CMD_MDB,
-               TS_CMD_MRW, TS_CMD_MRH, TS_CMD_MRB,
-               TS_CMD_MEM2ARRAY, TS_CMD_ARRAY2MEM,
-               TS_CMD_EXAMINE,
-               TS_CMD_POLL,
-               TS_CMD_RESET,
-               TS_CMD_HALT,
-               TS_CMD_WAITSTATE,
-               TS_CMD_EVENTLIST,
-               TS_CMD_CURSTATE,
-               TS_CMD_INVOKE_EVENT,
-       };
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+       goi.isconfigure = !strcmp(Jim_GetString(argv[0], NULL), "configure");
+       int need_args = 1 + goi.isconfigure;
+       if (goi.argc < need_args)
+       {
+               Jim_WrongNumArgs(goi.interp, goi.argc, goi.argv,
+                       goi.isconfigure
+                               ? "missing: -option VALUE ..."
+                               : "missing: -option ...");
+               return JIM_ERR;
+       }
+       struct target *target = Jim_CmdPrivData(goi.interp);
+       return target_configure(&goi, target);
+}
 
-       static const Jim_Nvp target_options[] = {
-               { .name = "configure", .value = TS_CMD_CONFIGURE },
-               { .name = "cget", .value = TS_CMD_CGET },
-               { .name = "mww", .value = TS_CMD_MWW },
-               { .name = "mwh", .value = TS_CMD_MWH },
-               { .name = "mwb", .value = TS_CMD_MWB },
-               { .name = "mdw", .value = TS_CMD_MDW },
-               { .name = "mdh", .value = TS_CMD_MDH },
-               { .name = "mdb", .value = TS_CMD_MDB },
-               { .name = "mem2array", .value = TS_CMD_MEM2ARRAY },
-               { .name = "array2mem", .value = TS_CMD_ARRAY2MEM },
-               { .name = "eventlist", .value = TS_CMD_EVENTLIST },
-               { .name = "curstate",  .value = TS_CMD_CURSTATE },
-
-               { .name = "arp_examine", .value = TS_CMD_EXAMINE },
-               { .name = "arp_poll", .value = TS_CMD_POLL },
-               { .name = "arp_reset", .value = TS_CMD_RESET },
-               { .name = "arp_halt", .value = TS_CMD_HALT },
-               { .name = "arp_waitstate", .value = TS_CMD_WAITSTATE },
-               { .name = "invoke-event", .value = TS_CMD_INVOKE_EVENT },
-
-               { .name = NULL, .value = -1 },
-       };
+static int jim_target_mw(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       const char *cmd_name = Jim_GetString(argv[0], NULL);
 
-       /* go past the "command" */
-       Jim_GetOpt_Setup(&goi, interp, argc-1, argv + 1);
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
 
-       target = Jim_CmdPrivData(goi.interp);
-       cmd_ctx = Jim_GetAssocData(goi.interp, "context");
+       if (goi.argc != 2 && goi.argc != 3)
+       {
+               Jim_SetResult_sprintf(goi.interp,
+                               "usage: %s <address> <data> [<count>]", cmd_name);
+               return JIM_ERR;
+       }
 
-       /* commands here are in an NVP table */
-       e = Jim_GetOpt_Nvp(&goi, target_options, &n);
-       if (e != JIM_OK) {
-               Jim_GetOpt_NvpUnknown(&goi, target_options, 0);
+       jim_wide a;
+       int e = Jim_GetOpt_Wide(&goi, &a);
+       if (e != JIM_OK)
                return e;
+
+       jim_wide b;
+       e = Jim_GetOpt_Wide(&goi, &b);
+       if (e != JIM_OK)
+               return e;
+
+       jim_wide c = 1;
+       if (goi.argc == 3)
+       {
+               e = Jim_GetOpt_Wide(&goi, &c);
+               if (e != JIM_OK)
+                       return e;
        }
-       /* Assume blank result */
-       Jim_SetEmptyResult(goi.interp);
 
-       switch (n->value) {
-       case TS_CMD_CONFIGURE:
-               if (goi.argc < 2) {
-                       Jim_WrongNumArgs(goi.interp, goi.argc, goi.argv, "missing: -option VALUE ...");
-                       return JIM_ERR;
-               }
-               goi.isconfigure = 1;
-               return target_configure(&goi, target);
-       case TS_CMD_CGET:
-               // some things take params
-               if (goi.argc < 1) {
-                       Jim_WrongNumArgs(goi.interp, 0, goi.argv, "missing: ?-option?");
-                       return JIM_ERR;
-               }
-               goi.isconfigure = 0;
-               return target_configure(&goi, target);
-               break;
-       case TS_CMD_MWW:
-       case TS_CMD_MWH:
-       case TS_CMD_MWB:
-               /* argv[0] = cmd
-                * argv[1] = address
-                * argv[2] = data
-                * argv[3] = optional count.
-                */
+       struct target *target = Jim_CmdPrivData(goi.interp);
+       uint8_t  target_buf[32];
+       if (strcasecmp(cmd_name, "mww") == 0) {
+               target_buffer_set_u32(target, target_buf, b);
+               b = 4;
+       }
+       else if (strcasecmp(cmd_name, "mwh") == 0) {
+               target_buffer_set_u16(target, target_buf, b);
+               b = 2;
+       }
+       else if (strcasecmp(cmd_name, "mwb") == 0) {
+               target_buffer_set_u8(target, target_buf, b);
+               b = 1;
+       } else {
+               LOG_ERROR("command '%s' unknown: ", cmd_name);
+               return JIM_ERR;
+       }
 
-               if ((goi.argc == 2) || (goi.argc == 3)) {
-                       /* all is well */
-               } else {
-               mwx_error:
-                       Jim_SetResult_sprintf(goi.interp, "expected: %s ADDR DATA [COUNT]", n->name);
+       for (jim_wide x = 0; x < c; x++)
+       {
+               e = target_write_memory(target, a, b, 1, target_buf);
+               if (e != ERROR_OK)
+               {
+                       Jim_SetResult_sprintf(interp,
+                                       "Error writing @ 0x%08x: %d\n", (int)(a), e);
                        return JIM_ERR;
                }
+               /* b = width */
+               a = a + b;
+       }
+       return JIM_OK;
+}
+
+static int jim_target_md(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       const char *cmd_name = Jim_GetString(argv[0], NULL);
+
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+
+       if ((goi.argc == 2) || (goi.argc == 3))
+       {
+               Jim_SetResult_sprintf(goi.interp,
+                               "usage: %s <address> [<count>]", cmd_name);
+               return JIM_ERR;
+       }
 
-               e = Jim_GetOpt_Wide(&goi, &a);
+       jim_wide a;
+       int e = Jim_GetOpt_Wide(&goi, &a);
+       if (e != JIM_OK) {
+               return JIM_ERR;
+       }
+       jim_wide c;
+       if (goi.argc) {
+               e = Jim_GetOpt_Wide(&goi, &c);
                if (e != JIM_OK) {
-                       goto mwx_error;
+                       return JIM_ERR;
                }
+       } else {
+               c = 1;
+       }
+       jim_wide b = 1; /* shut up gcc */
+       if (strcasecmp(cmd_name, "mdw") == 0)
+               b = 4;
+       else if (strcasecmp(cmd_name, "mdh") == 0)
+               b = 2;
+       else if (strcasecmp(cmd_name, "mdb") == 0)
+               b = 1;
+       else {
+               LOG_ERROR("command '%s' unknown: ", cmd_name);
+               return JIM_ERR;
+       }
 
-               e = Jim_GetOpt_Wide(&goi, &b);
-               if (e != JIM_OK) {
-                       goto mwx_error;
+       /* convert count to "bytes" */
+       c = c * b;
+
+       struct target *target = Jim_CmdPrivData(goi.interp);
+       uint8_t  target_buf[32];
+       jim_wide x, y, z;
+       while (c > 0) {
+               y = c;
+               if (y > 16) {
+                       y = 16;
                }
-               if (goi.argc == 3) {
-                       e = Jim_GetOpt_Wide(&goi, &c);
-                       if (e != JIM_OK) {
-                               goto mwx_error;
-                       }
-               } else {
-                       c = 1;
+               e = target_read_memory(target, a, b, y / b, target_buf);
+               if (e != ERROR_OK) {
+                       Jim_SetResult_sprintf(interp, "error reading target @ 0x%08lx", (int)(a));
+                       return JIM_ERR;
                }
 
-               switch (n->value) {
-               case TS_CMD_MWW:
-                       target_buffer_set_u32(target, target_buf, b);
-                       b = 4;
+               Jim_fprintf(interp, interp->cookie_stdout, "0x%08x ", (int)(a));
+               switch (b) {
+               case 4:
+                       for (x = 0; x < 16 && x < y; x += 4)
+                       {
+                               z = target_buffer_get_u32(target, &(target_buf[ x * 4 ]));
+                               Jim_fprintf(interp, interp->cookie_stdout, "%08x ", (int)(z));
+                       }
+                       for (; (x < 16) ; x += 4) {
+                               Jim_fprintf(interp, interp->cookie_stdout, "         ");
+                       }
                        break;
-               case TS_CMD_MWH:
-                       target_buffer_set_u16(target, target_buf, b);
-                       b = 2;
+               case 2:
+                       for (x = 0; x < 16 && x < y; x += 2)
+                       {
+                               z = target_buffer_get_u16(target, &(target_buf[ x * 2 ]));
+                               Jim_fprintf(interp, interp->cookie_stdout, "%04x ", (int)(z));
+                       }
+                       for (; (x < 16) ; x += 2) {
+                               Jim_fprintf(interp, interp->cookie_stdout, "     ");
+                       }
                        break;
-               case TS_CMD_MWB:
-                       target_buffer_set_u8(target, target_buf, b);
-                       b = 1;
+               case 1:
+               default:
+                       for (x = 0 ; (x < 16) && (x < y) ; x += 1) {
+                               z = target_buffer_get_u8(target, &(target_buf[ x * 4 ]));
+                               Jim_fprintf(interp, interp->cookie_stdout, "%02x ", (int)(z));
+                       }
+                       for (; (x < 16) ; x += 1) {
+                               Jim_fprintf(interp, interp->cookie_stdout, "   ");
+                       }
                        break;
                }
-               for (x = 0 ; x < c ; x++) {
-                       e = target_write_memory(target, a, b, 1, target_buf);
-                       if (e != ERROR_OK) {
-                               Jim_SetResult_sprintf(interp, "Error writing @ 0x%08x: %d\n", (int)(a), e);
-                               return JIM_ERR;
+               /* ascii-ify the bytes */
+               for (x = 0 ; x < y ; x++) {
+                       if ((target_buf[x] >= 0x20) &&
+                               (target_buf[x] <= 0x7e)) {
+                               /* good */
+                       } else {
+                               /* smack it */
+                               target_buf[x] = '.';
                        }
-                       /* b = width */
-                       a = a + b;
                }
-               return JIM_OK;
-               break;
-
-               /* display */
-       case TS_CMD_MDW:
-       case TS_CMD_MDH:
-       case TS_CMD_MDB:
-               /* argv[0] = command
-                * argv[1] = address
-                * argv[2] = optional count
-                */
-               if ((goi.argc == 2) || (goi.argc == 3)) {
-                       Jim_SetResult_sprintf(goi.interp, "expected: %s ADDR [COUNT]", n->name);
-                       return JIM_ERR;
-               }
-               e = Jim_GetOpt_Wide(&goi, &a);
-               if (e != JIM_OK) {
-                       return JIM_ERR;
-               }
-               if (goi.argc) {
-                       e = Jim_GetOpt_Wide(&goi, &c);
-                       if (e != JIM_OK) {
-                               return JIM_ERR;
-                       }
-               } else {
-                       c = 1;
-               }
-               b = 1; /* shut up gcc */
-               switch (n->value) {
-               case TS_CMD_MDW:
-                       b =  4;
-                       break;
-               case TS_CMD_MDH:
-                       b = 2;
-                       break;
-               case TS_CMD_MDB:
-                       b = 1;
-                       break;
+               /* space pad  */
+               while (x < 16) {
+                       target_buf[x] = ' ';
+                       x++;
                }
+               /* terminate */
+               target_buf[16] = 0;
+               /* print - with a newline */
+               Jim_fprintf(interp, interp->cookie_stdout, "%s\n", target_buf);
+               /* NEXT... */
+               c -= 16;
+               a += 16;
+       }
+       return JIM_OK;
+}
 
-               /* convert to "bytes" */
-               c = c * b;
-               /* count is now in 'BYTES' */
-               while (c > 0) {
-                       y = c;
-                       if (y > 16) {
-                               y = 16;
-                       }
-                       e = target_read_memory(target, a, b, y / b, target_buf);
-                       if (e != ERROR_OK) {
-                               Jim_SetResult_sprintf(interp, "error reading target @ 0x%08lx", (int)(a));
-                               return JIM_ERR;
-                       }
+static int jim_target_mem2array(Jim_Interp *interp,
+               int argc, Jim_Obj *const *argv)
+{
+       struct target *target = Jim_CmdPrivData(interp);
+       return target_mem2array(interp, target, argc - 1, argv + 1);
+}
 
-                       Jim_fprintf(interp, interp->cookie_stdout, "0x%08x ", (int)(a));
-                       switch (b) {
-                       case 4:
-                               for (x = 0 ; (x < 16) && (x < y) ; x += 4) {
-                                       z = target_buffer_get_u32(target, &(target_buf[ x * 4 ]));
-                                       Jim_fprintf(interp, interp->cookie_stdout, "%08x ", (int)(z));
-                               }
-                               for (; (x < 16) ; x += 4) {
-                                       Jim_fprintf(interp, interp->cookie_stdout, "         ");
-                               }
-                               break;
-                       case 2:
-                               for (x = 0 ; (x < 16) && (x < y) ; x += 2) {
-                                       z = target_buffer_get_u16(target, &(target_buf[ x * 2 ]));
-                                       Jim_fprintf(interp, interp->cookie_stdout, "%04x ", (int)(z));
-                               }
-                               for (; (x < 16) ; x += 2) {
-                                       Jim_fprintf(interp, interp->cookie_stdout, "     ");
-                               }
-                               break;
-                       case 1:
-                       default:
-                               for (x = 0 ; (x < 16) && (x < y) ; x += 1) {
-                                       z = target_buffer_get_u8(target, &(target_buf[ x * 4 ]));
-                                       Jim_fprintf(interp, interp->cookie_stdout, "%02x ", (int)(z));
-                               }
-                               for (; (x < 16) ; x += 1) {
-                                       Jim_fprintf(interp, interp->cookie_stdout, "   ");
-                               }
-                               break;
-                       }
-                       /* ascii-ify the bytes */
-                       for (x = 0 ; x < y ; x++) {
-                               if ((target_buf[x] >= 0x20) &&
-                                       (target_buf[x] <= 0x7e)) {
-                                       /* good */
-                               } else {
-                                       /* smack it */
-                                       target_buf[x] = '.';
-                               }
-                       }
-                       /* space pad  */
-                       while (x < 16) {
-                               target_buf[x] = ' ';
-                               x++;
-                       }
-                       /* terminate */
-                       target_buf[16] = 0;
-                       /* print - with a newline */
-                       Jim_fprintf(interp, interp->cookie_stdout, "%s\n", target_buf);
-                       /* NEXT... */
-                       c -= 16;
-                       a += 16;
-               }
-               return JIM_OK;
-       case TS_CMD_MEM2ARRAY:
-               return target_mem2array(goi.interp, target, goi.argc, goi.argv);
-               break;
-       case TS_CMD_ARRAY2MEM:
-               return target_array2mem(goi.interp, target, goi.argc, goi.argv);
-               break;
-       case TS_CMD_EXAMINE:
-               if (goi.argc) {
-                       Jim_WrongNumArgs(goi.interp, 2, argv, "[no parameters]");
-                       return JIM_ERR;
-               }
-               if (!target->tap->enabled)
-                       goto err_tap_disabled;
-               e = target->type->examine(target);
-               if (e != ERROR_OK) {
-                       Jim_SetResult_sprintf(interp, "examine-fails: %d", e);
-                       return JIM_ERR;
-               }
-               return JIM_OK;
-       case TS_CMD_POLL:
-               if (goi.argc) {
-                       Jim_WrongNumArgs(goi.interp, 2, argv, "[no parameters]");
-                       return JIM_ERR;
-               }
-               if (!target->tap->enabled)
-                       goto err_tap_disabled;
-               if (!(target_was_examined(target))) {
-                       e = ERROR_TARGET_NOT_EXAMINED;
-               } else {
-                       e = target->type->poll(target);
-               }
-               if (e != ERROR_OK) {
-                       Jim_SetResult_sprintf(interp, "poll-fails: %d", e);
-                       return JIM_ERR;
-               } else {
-                       return JIM_OK;
-               }
-               break;
-       case TS_CMD_RESET:
-               if (goi.argc != 2) {
-                       Jim_WrongNumArgs(interp, 2, argv,
-                                       "([tT]|[fF]|assert|deassert) BOOL");
-                       return JIM_ERR;
-               }
-               e = Jim_GetOpt_Nvp(&goi, nvp_assert, &n);
-               if (e != JIM_OK) {
-                       Jim_GetOpt_NvpUnknown(&goi, nvp_assert, 1);
-                       return e;
-               }
-               /* the halt or not param */
-               e = Jim_GetOpt_Wide(&goi, &a);
-               if (e != JIM_OK) {
-                       return e;
-               }
-               if (!target->tap->enabled)
-                       goto err_tap_disabled;
-               if (!target->type->assert_reset
-                               || !target->type->deassert_reset) {
-                       Jim_SetResult_sprintf(interp,
-                                       "No target-specific reset for %s",
-                                       target->cmd_name);
-                       return JIM_ERR;
-               }
-               /* determine if we should halt or not. */
-               target->reset_halt = !!a;
-               /* When this happens - all workareas are invalid. */
-               target_free_all_working_areas_restore(target, 0);
-
-               /* do the assert */
-               if (n->value == NVP_ASSERT) {
-                       e = target->type->assert_reset(target);
-               } else {
-                       e = target->type->deassert_reset(target);
-               }
-               return (e == ERROR_OK) ? JIM_OK : JIM_ERR;
-       case TS_CMD_HALT:
-               if (goi.argc) {
-                       Jim_WrongNumArgs(goi.interp, 0, argv, "halt [no parameters]");
-                       return JIM_ERR;
-               }
-               if (!target->tap->enabled)
-                       goto err_tap_disabled;
-               e = target->type->halt(target);
-               return (e == ERROR_OK) ? JIM_OK : JIM_ERR;
-       case TS_CMD_WAITSTATE:
-               /* params:  <name>  statename timeoutmsecs */
-               if (goi.argc != 2) {
-                       Jim_SetResult_sprintf(goi.interp, "%s STATENAME TIMEOUTMSECS", n->name);
-                       return JIM_ERR;
-               }
-               e = Jim_GetOpt_Nvp(&goi, nvp_target_state, &n);
-               if (e != JIM_OK) {
-                       Jim_GetOpt_NvpUnknown(&goi, nvp_target_state,1);
-                       return e;
-               }
-               e = Jim_GetOpt_Wide(&goi, &a);
-               if (e != JIM_OK) {
-                       return e;
-               }
-               if (!target->tap->enabled)
-                       goto err_tap_disabled;
-               e = target_wait_state(target, n->value, a);
-               if (e != ERROR_OK) {
-                       Jim_SetResult_sprintf(goi.interp,
-                                                                  "target: %s wait %s fails (%d) %s",
-                                                                  target->cmd_name,
-                                                                  n->name,
-                                                                  e, target_strerror_safe(e));
-                       return JIM_ERR;
-               } else {
-                       return JIM_OK;
-               }
-       case TS_CMD_EVENTLIST:
-               /* List for human, Events defined for this target.
-                * scripts/programs should use 'name cget -event NAME'
-                */
-               {
-                       struct target_event_action *teap;
-                       teap = target->event_action;
-                       command_print(cmd_ctx, "Event actions for target (%d) %s\n",
-                                                  target->target_number,
-                                                  target->cmd_name);
-                       command_print(cmd_ctx, "%-25s | Body", "Event");
-                       command_print(cmd_ctx, "------------------------- | ----------------------------------------");
-                       while (teap) {
-                               command_print(cmd_ctx,
-                                                          "%-25s | %s",
-                                                          Jim_Nvp_value2name_simple(nvp_target_event, teap->event)->name,
-                                                          Jim_GetString(teap->body, NULL));
-                               teap = teap->next;
-                       }
-                       command_print(cmd_ctx, "***END***");
-                       return JIM_OK;
-               }
-       case TS_CMD_CURSTATE:
-               if (goi.argc != 0) {
-                       Jim_WrongNumArgs(goi.interp, 0, argv, "[no parameters]");
-                       return JIM_ERR;
-               }
-               Jim_SetResultString(goi.interp,
-                                                       target_state_name( target ),
-                                                       -1);
-               return JIM_OK;
-       case TS_CMD_INVOKE_EVENT:
-               if (goi.argc != 1) {
-                       Jim_SetResult_sprintf(goi.interp, "%s ?EVENTNAME?",n->name);
-                       return JIM_ERR;
-               }
-               e = Jim_GetOpt_Nvp(&goi, nvp_target_event, &n);
-               if (e != JIM_OK) {
-                       Jim_GetOpt_NvpUnknown(&goi, nvp_target_event, 1);
-                       return e;
-               }
-               target_handle_event(target, n->value);
-               return JIM_OK;
-       }
-       return JIM_ERR;
+static int jim_target_array2mem(Jim_Interp *interp,
+               int argc, Jim_Obj *const *argv)
+{
+       struct target *target = Jim_CmdPrivData(interp);
+       return target_array2mem(interp, target, argc - 1, argv + 1);
+}
 
-err_tap_disabled:
+static int jim_target_tap_disabled(Jim_Interp *interp)
+{
        Jim_SetResult_sprintf(interp, "[TAP is disabled]");
        return JIM_ERR;
 }
 
+static int jim_target_examine(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "[no parameters]");
+               return JIM_ERR;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       if (!target->tap->enabled)
+               return jim_target_tap_disabled(interp);
+
+       int e = target->type->examine(target);
+       if (e != ERROR_OK)
+       {
+               Jim_SetResult_sprintf(interp, "examine-fails: %d", e);
+               return JIM_ERR;
+       }
+       return JIM_OK;
+}
+
+static int jim_target_poll(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "[no parameters]");
+               return JIM_ERR;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       if (!target->tap->enabled)
+               return jim_target_tap_disabled(interp);
+
+       int e;
+       if (!(target_was_examined(target))) {
+               e = ERROR_TARGET_NOT_EXAMINED;
+       } else {
+               e = target->type->poll(target);
+       }
+       if (e != ERROR_OK)
+       {
+               Jim_SetResult_sprintf(interp, "poll-fails: %d", e);
+               return JIM_ERR;
+       }
+       return JIM_OK;
+}
+
+static int jim_target_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+
+       if (goi.argc != 2)
+       {
+               Jim_WrongNumArgs(interp, 0, argv,
+                               "([tT]|[fF]|assert|deassert) BOOL");
+               return JIM_ERR;
+       }
+
+       Jim_Nvp *n;
+       int e = Jim_GetOpt_Nvp(&goi, nvp_assert, &n);
+       if (e != JIM_OK)
+       {
+               Jim_GetOpt_NvpUnknown(&goi, nvp_assert, 1);
+               return e;
+       }
+       /* the halt or not param */
+       jim_wide a;
+       e = Jim_GetOpt_Wide(&goi, &a);
+       if (e != JIM_OK)
+               return e;
+
+       struct target *target = Jim_CmdPrivData(goi.interp);
+       if (!target->tap->enabled)
+               return jim_target_tap_disabled(interp);
+       if (!(target_was_examined(target)))
+       {
+               LOG_ERROR("Target not examined yet");
+               return ERROR_TARGET_NOT_EXAMINED;
+       }
+       if (!target->type->assert_reset || !target->type->deassert_reset)
+       {
+               Jim_SetResult_sprintf(interp,
+                               "No target-specific reset for %s",
+                               target_name(target));
+               return JIM_ERR;
+       }
+       /* determine if we should halt or not. */
+       target->reset_halt = !!a;
+       /* When this happens - all workareas are invalid. */
+       target_free_all_working_areas_restore(target, 0);
+
+       /* do the assert */
+       if (n->value == NVP_ASSERT) {
+               e = target->type->assert_reset(target);
+       } else {
+               e = target->type->deassert_reset(target);
+       }
+       return (e == ERROR_OK) ? JIM_OK : JIM_ERR;
+}
+
+static int jim_target_halt(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1) {
+               Jim_WrongNumArgs(interp, 1, argv, "[no parameters]");
+               return JIM_ERR;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       if (!target->tap->enabled)
+               return jim_target_tap_disabled(interp);
+       int e = target->type->halt(target);
+       return (e == ERROR_OK) ? JIM_OK : JIM_ERR;
+}
+
+static int jim_target_wait_state(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+
+       /* params:  <name>  statename timeoutmsecs */
+       if (goi.argc != 2)
+       {
+               const char *cmd_name = Jim_GetString(argv[0], NULL);
+               Jim_SetResult_sprintf(goi.interp,
+                               "%s <state_name> <timeout_in_msec>", cmd_name);
+               return JIM_ERR;
+       }
+
+       Jim_Nvp *n;
+       int e = Jim_GetOpt_Nvp(&goi, nvp_target_state, &n);
+       if (e != JIM_OK) {
+               Jim_GetOpt_NvpUnknown(&goi, nvp_target_state,1);
+               return e;
+       }
+       jim_wide a;
+       e = Jim_GetOpt_Wide(&goi, &a);
+       if (e != JIM_OK) {
+               return e;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       if (!target->tap->enabled)
+               return jim_target_tap_disabled(interp);
+
+       e = target_wait_state(target, n->value, a);
+       if (e != ERROR_OK)
+       {
+               Jim_SetResult_sprintf(goi.interp,
+                               "target: %s wait %s fails (%d) %s",
+                               target_name(target), n->name,
+                               e, target_strerror_safe(e));
+               return JIM_ERR;
+       }
+       return JIM_OK;
+}
+/* List for human, Events defined for this target.
+ * scripts/programs should use 'name cget -event NAME'
+ */
+static int jim_target_event_list(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       struct command_context *cmd_ctx = Jim_GetAssocData(interp, "context");
+       struct target *target = Jim_CmdPrivData(interp);
+       struct target_event_action *teap = target->event_action;
+       command_print(cmd_ctx, "Event actions for target (%d) %s\n",
+                                  target->target_number,
+                                  target_name(target));
+       command_print(cmd_ctx, "%-25s | Body", "Event");
+       command_print(cmd_ctx, "------------------------- | "
+                       "----------------------------------------");
+       while (teap)
+       {
+               Jim_Nvp *opt = Jim_Nvp_value2name_simple(nvp_target_event, teap->event);
+               command_print(cmd_ctx, "%-25s | %s",
+                               opt->name, Jim_GetString(teap->body, NULL));
+               teap = teap->next;
+       }
+       command_print(cmd_ctx, "***END***");
+       return JIM_OK;
+}
+static int jim_target_current_state(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "[no parameters]");
+               return JIM_ERR;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       Jim_SetResultString(interp, target_state_name(target), -1);
+       return JIM_OK;
+}
+static int jim_target_invoke_event(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+       if (goi.argc != 1)
+       {
+               const char *cmd_name = Jim_GetString(argv[0], NULL);
+               Jim_SetResult_sprintf(goi.interp, "%s <eventname>", cmd_name);
+               return JIM_ERR;
+       }
+       Jim_Nvp *n;
+       int e = Jim_GetOpt_Nvp(&goi, nvp_target_event, &n);
+       if (e != JIM_OK)
+       {
+               Jim_GetOpt_NvpUnknown(&goi, nvp_target_event, 1);
+               return e;
+       }
+       struct target *target = Jim_CmdPrivData(interp);
+       target_handle_event(target, n->value);
+       return JIM_OK;
+}
+
+static const struct command_registration target_instance_command_handlers[] = {
+       {
+               .name = "configure",
+               .mode = COMMAND_CONFIG,
+               .jim_handler = jim_target_configure,
+               .help  = "configure a new target for use",
+               .usage = "[target_attribute ...]",
+       },
+       {
+               .name = "cget",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_configure,
+               .help  = "returns the specified target attribute",
+               .usage = "target_attribute",
+       },
+       {
+               .name = "mww",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_mw,
+               .help = "Write 32-bit word(s) to target memory",
+               .usage = "address data [count]",
+       },
+       {
+               .name = "mwh",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_mw,
+               .help = "Write 16-bit half-word(s) to target memory",
+               .usage = "address data [count]",
+       },
+       {
+               .name = "mwb",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_mw,
+               .help = "Write byte(s) to target memory",
+               .usage = "address data [count]",
+       },
+       {
+               .name = "mdw",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_md,
+               .help = "Display target memory as 32-bit words",
+               .usage = "address [count]",
+       },
+       {
+               .name = "mdh",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_md,
+               .help = "Display target memory as 16-bit half-words",
+               .usage = "address [count]",
+       },
+       {
+               .name = "mdb",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_md,
+               .help = "Display target memory as 8-bit bytes",
+               .usage = "address [count]",
+       },
+       {
+               .name = "array2mem",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_array2mem,
+               .help = "Writes Tcl array of 8/16/32 bit numbers "
+                       "to target memory",
+               .usage = "arrayname bitwidth address count",
+       },
+       {
+               .name = "mem2array",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_mem2array,
+               .help = "Loads Tcl array of 8/16/32 bit numbers "
+                       "from target memory",
+               .usage = "arrayname bitwidth address count",
+       },
+       {
+               .name = "eventlist",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_event_list,
+               .help = "displays a table of events defined for this target",
+       },
+       {
+               .name = "curstate",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_current_state,
+               .help = "displays the current state of this target",
+       },
+       {
+               .name = "arp_examine",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_examine,
+               .help = "used internally for reset processing",
+       },
+       {
+               .name = "arp_poll",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_poll,
+               .help = "used internally for reset processing",
+       },
+       {
+               .name = "arp_reset",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_reset,
+               .help = "used internally for reset processing",
+       },
+       {
+               .name = "arp_halt",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_halt,
+               .help = "used internally for reset processing",
+       },
+       {
+               .name = "arp_waitstate",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_wait_state,
+               .help = "used internally for reset processing",
+       },
+       {
+               .name = "invoke-event",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_target_invoke_event,
+               .help = "invoke handler for specified event",
+               .usage = "event_name",
+       },
+       COMMAND_REGISTRATION_DONE
+};
+
 static int target_create(Jim_GetOptInfo *goi)
 {
        Jim_Obj *new_cmd;
@@ -4320,7 +4485,7 @@ static int target_create(Jim_GetOptInfo *goi)
 
        if (target->tap == NULL)
        {
-               Jim_SetResultString(interp, "-chain-position required when creating target", -1);
+               Jim_SetResultString(goi->interp, "-chain-position required when creating target", -1);
                e = JIM_ERR;
        }
 
@@ -4339,9 +4504,14 @@ static int target_create(Jim_GetOptInfo *goi)
        if (!target->variant)
                target->variant = strdup("");
 
+       cp = Jim_GetString(new_cmd, NULL);
+       target->cmd_name = strdup(cp);
+
        /* create the target specific commands */
-       if (target->type->register_commands) {
-               (*(target->type->register_commands))(cmd_ctx);
+       if (target->type->commands) {
+               e = register_commands(cmd_ctx, NULL, target->type->commands);
+               if (ERROR_OK != e)
+                       LOG_ERROR("unable to register '%s' commands", cp);
        }
        if (target->type->target_create) {
                (*(target->type->target_create))(target, goi->interp);
@@ -4357,140 +4527,195 @@ static int target_create(Jim_GetOptInfo *goi)
                *tpp = target;
        }
 
-       cp = Jim_GetString(new_cmd, NULL);
-       target->cmd_name = strdup(cp);
-
        /* now - create the new target name command */
-       e = Jim_CreateCommand(goi->interp,
-                                                  /* name */
-                                                  cp,
-                                                  tcl_target_func, /* C function */
-                                                  target, /* private data */
-                                                  NULL); /* no del proc */
-
-       return e;
-}
-
-static int jim_target(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
-{
-       int x,r,e;
-       jim_wide w;
-       struct command_context *cmd_ctx;
-       struct target *target;
-       Jim_GetOptInfo goi;
-       enum tcmd {
-               /* TG = target generic */
-               TG_CMD_CREATE,
-               TG_CMD_TYPES,
-               TG_CMD_NAMES,
-               TG_CMD_CURRENT,
-               TG_CMD_NUMBER,
-               TG_CMD_COUNT,
+       const const struct command_registration target_subcommands[] = {
+               {
+                       .chain = target_instance_command_handlers,
+               },
+               {
+                       .chain = target->type->commands,
+               },
+               COMMAND_REGISTRATION_DONE
        };
-       const char *target_cmds[] = {
-               "create", "types", "names", "current", "number",
-               "count",
-               NULL /* terminate */
+       const const struct command_registration target_commands[] = {
+               {
+                       .name = cp,
+                       .mode = COMMAND_ANY,
+                       .help = "target command group",
+                       .chain = target_subcommands,
+               },
+               COMMAND_REGISTRATION_DONE
        };
+       e = register_commands(cmd_ctx, NULL, target_commands);
+       if (ERROR_OK != e)
+               return JIM_ERR;
+
+       struct command *c = command_find_in_context(cmd_ctx, cp);
+       assert(c);
+       command_set_handler_data(c, target);
 
-       LOG_DEBUG("Target command params:");
-       LOG_DEBUG("%s", Jim_Debug_ArgvString(interp, argc, argv));
+       return (ERROR_OK == e) ? JIM_OK : JIM_ERR;
+}
 
-       cmd_ctx = Jim_GetAssocData(interp, "context");
+static int jim_target_current(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "Too many parameters");
+               return JIM_ERR;
+       }
+       struct command_context *cmd_ctx = Jim_GetAssocData(interp, "context");
+       Jim_SetResultString(interp, get_current_target(cmd_ctx)->cmd_name, -1);
+       return JIM_OK;
+}
 
-       Jim_GetOpt_Setup(&goi, interp, argc-1, argv + 1);
+static int jim_target_types(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "Too many parameters");
+               return JIM_ERR;
+       }
+       Jim_SetResult(interp, Jim_NewListObj(interp, NULL, 0));
+       for (unsigned x = 0; NULL != target_types[x]; x++)
+       {
+               Jim_ListAppendElement(interp, Jim_GetResult(interp),
+                       Jim_NewStringObj(interp, target_types[x]->name, -1));
+       }
+       return JIM_OK;
+}
 
-       if (goi.argc == 0) {
-               Jim_WrongNumArgs(interp, 1, argv, "missing: command ...");
+static int jim_target_names(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "Too many parameters");
                return JIM_ERR;
        }
+       Jim_SetResult(interp, Jim_NewListObj(interp, NULL, 0));
+       struct target *target = all_targets;
+       while (target)
+       {
+               Jim_ListAppendElement(interp, Jim_GetResult(interp),
+                       Jim_NewStringObj(interp, target_name(target), -1));
+               target = target->next;
+       }
+       return JIM_OK;
+}
 
-       /* Jim_GetOpt_Debug(&goi); */
-       r = Jim_GetOpt_Enum(&goi, target_cmds, &x);
-       if (r != JIM_OK) {
-               return r;
+static int jim_target_create(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+       if (goi.argc < 3)
+       {
+               Jim_WrongNumArgs(goi.interp, goi.argc, goi.argv,
+                       "<name> <target_type> [<target_options> ...]");
+               return JIM_ERR;
        }
+       return target_create(&goi);
+}
 
-       switch (x) {
-       default:
-               Jim_Panic(goi.interp,"Why am I here?");
+static int jim_target_number(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       Jim_GetOptInfo goi;
+       Jim_GetOpt_Setup(&goi, interp, argc - 1, argv + 1);
+
+       /* It's OK to remove this mechanism sometime after August 2010 or so */
+       LOG_WARNING("don't use numbers as target identifiers; use names");
+       if (goi.argc != 1)
+       {
+               Jim_SetResult_sprintf(goi.interp, "usage: target number <number>");
                return JIM_ERR;
-       case TG_CMD_CURRENT:
-               if (goi.argc != 0) {
-                       Jim_WrongNumArgs(goi.interp, 1, goi.argv, "Too many parameters");
-                       return JIM_ERR;
-               }
-               Jim_SetResultString(goi.interp, get_current_target(cmd_ctx)->cmd_name, -1);
-               return JIM_OK;
-       case TG_CMD_TYPES:
-               if (goi.argc != 0) {
-                       Jim_WrongNumArgs(goi.interp, 1, goi.argv, "Too many parameters");
-                       return JIM_ERR;
-               }
-               Jim_SetResult(goi.interp, Jim_NewListObj(goi.interp, NULL, 0));
-               for (x = 0 ; target_types[x] ; x++) {
-                       Jim_ListAppendElement(goi.interp,
-                                                                  Jim_GetResult(goi.interp),
-                                                                  Jim_NewStringObj(goi.interp, target_types[x]->name, -1));
-               }
-               return JIM_OK;
-       case TG_CMD_NAMES:
-               if (goi.argc != 0) {
-                       Jim_WrongNumArgs(goi.interp, 1, goi.argv, "Too many parameters");
-                       return JIM_ERR;
-               }
-               Jim_SetResult(goi.interp, Jim_NewListObj(goi.interp, NULL, 0));
-               target = all_targets;
-               while (target) {
-                       Jim_ListAppendElement(goi.interp,
-                                                                  Jim_GetResult(goi.interp),
-                                                                  Jim_NewStringObj(goi.interp, target->cmd_name, -1));
-                       target = target->next;
-               }
-               return JIM_OK;
-       case TG_CMD_CREATE:
-               if (goi.argc < 3) {
-                       Jim_WrongNumArgs(goi.interp, goi.argc, goi.argv, "?name  ... config options ...");
-                       return JIM_ERR;
-               }
-               return target_create(&goi);
-               break;
-       case TG_CMD_NUMBER:
-               /* It's OK to remove this mechanism sometime after August 2010 or so */
-               LOG_WARNING("don't use numbers as target identifiers; use names");
-               if (goi.argc != 1) {
-                       Jim_SetResult_sprintf(goi.interp, "expected: target number ?NUMBER?");
-                       return JIM_ERR;
-               }
-               e = Jim_GetOpt_Wide(&goi, &w);
-               if (e != JIM_OK) {
-                       return JIM_ERR;
-               }
-               for (x = 0, target = all_targets; target; target = target->next, x++) {
-                       if (target->target_number == w)
-                               break;
-               }
-               if (target == NULL) {
-                       Jim_SetResult_sprintf(goi.interp,
-                                       "Target: number %d does not exist", (int)(w));
-                       return JIM_ERR;
-               }
-               Jim_SetResultString(goi.interp, target->cmd_name, -1);
-               return JIM_OK;
-       case TG_CMD_COUNT:
-               if (goi.argc != 0) {
-                       Jim_WrongNumArgs(goi.interp, 0, goi.argv, "<no parameters>");
-                       return JIM_ERR;
-               }
-               for (x = 0, target = all_targets; target; target = target->next, x++)
+       }
+       jim_wide w;
+       int e = Jim_GetOpt_Wide(&goi, &w);
+       if (e != JIM_OK)
+               return JIM_ERR;
+
+       struct target *target;
+       for (target = all_targets; NULL != target; target = target->next)
+       {
+               if (target->target_number != w)
                        continue;
-               Jim_SetResult(goi.interp, Jim_NewIntObj(goi.interp, x));
+
+               Jim_SetResultString(goi.interp, target_name(target), -1);
                return JIM_OK;
        }
-
+       Jim_SetResult_sprintf(goi.interp,
+                       "Target: number %d does not exist", (int)(w));
        return JIM_ERR;
 }
 
+static int jim_target_count(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+{
+       if (argc != 1)
+       {
+               Jim_WrongNumArgs(interp, 1, argv, "<no parameters>");
+               return JIM_ERR;
+       }
+       unsigned count = 0;
+       struct target *target = all_targets;
+       while (NULL != target)
+       {
+               target = target->next;
+               count++;
+       }
+       Jim_SetResult(interp, Jim_NewIntObj(interp, count));
+       return JIM_OK;
+}
+
+static const struct command_registration target_subcommand_handlers[] = {
+       {
+               .name = "init",
+               .mode = COMMAND_CONFIG,
+               .handler = handle_target_init_command,
+               .help = "initialize targets",
+       },
+       {
+               .name = "create",
+               /* REVISIT this should be COMMAND_CONFIG ... */
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_create,
+               .usage = "name type '-chain-position' name [options ...]",
+               .help = "Creates and selects a new target",
+       },
+       {
+               .name = "current",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_current,
+               .help = "Returns the currently selected target",
+       },
+       {
+               .name = "types",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_types,
+               .help = "Returns the available target types as "
+                               "a list of strings",
+       },
+       {
+               .name = "names",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_names,
+               .help = "Returns the names of all targets as a list of strings",
+       },
+       {
+               .name = "number",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_number,
+               .usage = "number",
+               .help = "Returns the name of the numbered target "
+                       "(DEPRECATED)",
+       },
+       {
+               .name = "count",
+               .mode = COMMAND_ANY,
+               .jim_handler = jim_target_count,
+               .help = "Returns the number of targets as an integer "
+                       "(DEPRECATED)",
+       },
+       COMMAND_REGISTRATION_DONE
+};
 
 struct FastLoad
 {
@@ -4662,105 +4887,255 @@ COMMAND_HANDLER(handle_fast_load_command)
        return retval;
 }
 
-static int jim_mcrmrc(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
-{
-       struct command_context *context;
-       struct target *target;
-       int retval;
-
-       context = Jim_GetAssocData(interp, "context");
-       if (context == NULL) {
-               LOG_ERROR("array2mem: no command context");
-               return JIM_ERR;
-       }
-       target = get_current_target(context);
-       if (target == NULL) {
-               LOG_ERROR("array2mem: no current target");
-               return JIM_ERR;
-       }
-
-       if ((argc < 6) || (argc > 7))
-       {
-               return JIM_ERR;
-       }
-
-       int cpnum;
-       uint32_t op1;
-       uint32_t op2;
-       uint32_t CRn;
-       uint32_t CRm;
-       uint32_t value;
-
-       int e;
-       long l;
-       e = Jim_GetLong(interp, argv[1], &l);
-       if (e != JIM_OK) {
-               return e;
-       }
-       cpnum = l;
-
-       e = Jim_GetLong(interp, argv[2], &l);
-       if (e != JIM_OK) {
-               return e;
-       }
-       op1 = l;
-
-       e = Jim_GetLong(interp, argv[3], &l);
-       if (e != JIM_OK) {
-               return e;
-       }
-       CRn = l;
-
-       e = Jim_GetLong(interp, argv[4], &l);
-       if (e != JIM_OK) {
-               return e;
-       }
-       CRm = l;
-
-       e = Jim_GetLong(interp, argv[5], &l);
-       if (e != JIM_OK) {
-               return e;
-       }
-       op2 = l;
-
-       value = 0;
-
-       if (argc == 7)
+static const struct command_registration target_command_handlers[] = {
        {
-               e = Jim_GetLong(interp, argv[6], &l);
-               if (e != JIM_OK) {
-                       return e;
-               }
-               value = l;
-
-               retval = target_mcr(target, cpnum, op1, op2, CRn, CRm, value);
-               if (retval != ERROR_OK)
-                       return JIM_ERR;
-       } else
+               .name = "targets",
+               .handler = handle_targets_command,
+               .mode = COMMAND_ANY,
+               .help = "change current default target (one parameter) "
+                       "or prints table of all targets (no parameters)",
+               .usage = "[target]",
+       },
        {
-               retval = target_mrc(target, cpnum, op1, op2, CRn, CRm, &value);
-               if (retval != ERROR_OK)
-                       return JIM_ERR;
-
-               Jim_SetResult(interp, Jim_NewIntObj(interp, value));
-       }
+               .name = "target",
+               .mode = COMMAND_CONFIG,
+               .help = "configure target",
 
-       return JIM_OK;
-}
+               .chain = target_subcommand_handlers,
+       },
+       COMMAND_REGISTRATION_DONE
+};
 
 int target_register_commands(struct command_context *cmd_ctx)
 {
+       return register_commands(cmd_ctx, NULL, target_command_handlers);
+}
 
-       register_command(cmd_ctx, NULL, "targets",
-                       handle_targets_command, COMMAND_EXEC,
-                       "change current command line target (one parameter) "
-                       "or list targets (no parameters)");
+static bool target_reset_nag = true;
 
-       register_jim(cmd_ctx, "target", jim_target, "configure target");
+bool get_target_reset_nag(void)
+{
+       return target_reset_nag;
+}
 
-       return ERROR_OK;
+COMMAND_HANDLER(handle_target_reset_nag)
+{
+       return CALL_COMMAND_HANDLER(handle_command_parse_bool,
+                       &target_reset_nag, "Nag after each reset about options to improve "
+                       "performance");
 }
 
+static const struct command_registration target_exec_command_handlers[] = {
+       {
+               .name = "fast_load_image",
+               .handler = handle_fast_load_image_command,
+               .mode = COMMAND_ANY,
+               .help = "Load image into server memory for later use by "
+                       "fast_load; primarily for profiling",
+               .usage = "filename address ['bin'|'ihex'|'elf'|'s19'] "
+                       "[min_address [max_length]]",
+       },
+       {
+               .name = "fast_load",
+               .handler = handle_fast_load_command,
+               .mode = COMMAND_EXEC,
+               .help = "loads active fast load image to current target "
+                       "- mainly for profiling purposes",
+       },
+       {
+               .name = "profile",
+               .handler = handle_profile_command,
+               .mode = COMMAND_EXEC,
+               .help = "profiling samples the CPU PC",
+       },
+       /** @todo don't register virt2phys() unless target supports it */
+       {
+               .name = "virt2phys",
+               .handler = handle_virt2phys_command,
+               .mode = COMMAND_ANY,
+               .help = "translate a virtual address into a physical address",
+               .usage = "virtual_address",
+       },
+       {
+               .name = "reg",
+               .handler = handle_reg_command,
+               .mode = COMMAND_EXEC,
+               .help = "display or set a register; with no arguments, "
+                       "displays all registers and their values",
+               .usage = "[(register_name|register_number) [value]]",
+       },
+       {
+               .name = "poll",
+               .handler = handle_poll_command,
+               .mode = COMMAND_EXEC,
+               .help = "poll target state; or reconfigure background polling",
+               .usage = "['on'|'off']",
+       },
+       {
+               .name = "wait_halt",
+               .handler = handle_wait_halt_command,
+               .mode = COMMAND_EXEC,
+               .help = "wait up to the specified number of milliseconds "
+                       "(default 5) for a previously requested halt",
+               .usage = "[milliseconds]",
+       },
+       {
+               .name = "halt",
+               .handler = handle_halt_command,
+               .mode = COMMAND_EXEC,
+               .help = "request target to halt, then wait up to the specified"
+                       "number of milliseconds (default 5) for it to complete",
+               .usage = "[milliseconds]",
+       },
+       {
+               .name = "resume",
+               .handler = handle_resume_command,
+               .mode = COMMAND_EXEC,
+               .help = "resume target execution from current PC or address",
+               .usage = "[address]",
+       },
+       {
+               .name = "reset",
+               .handler = handle_reset_command,
+               .mode = COMMAND_EXEC,
+               .usage = "[run|halt|init]",
+               .help = "Reset all targets into the specified mode."
+                       "Default reset mode is run, if not given.",
+       },
+       {
+               .name = "soft_reset_halt",
+               .handler = handle_soft_reset_halt_command,
+               .mode = COMMAND_EXEC,
+               .help = "halt the target and do a soft reset",
+       },
+       {
+               .name = "step",
+               .handler = handle_step_command,
+               .mode = COMMAND_EXEC,
+               .help = "step one instruction from current PC or address",
+               .usage = "[address]",
+       },
+       {
+               .name = "mdw",
+               .handler = handle_md_command,
+               .mode = COMMAND_EXEC,
+               .help = "display memory words",
+               .usage = "['phys'] address [count]",
+       },
+       {
+               .name = "mdh",
+               .handler = handle_md_command,
+               .mode = COMMAND_EXEC,
+               .help = "display memory half-words",
+               .usage = "['phys'] address [count]",
+       },
+       {
+               .name = "mdb",
+               .handler = handle_md_command,
+               .mode = COMMAND_EXEC,
+               .help = "display memory bytes",
+               .usage = "['phys'] address [count]",
+       },
+       {
+               .name = "mww",
+               .handler = handle_mw_command,
+               .mode = COMMAND_EXEC,
+               .help = "write memory word",
+               .usage = "['phys'] address value [count]",
+       },
+       {
+               .name = "mwh",
+               .handler = handle_mw_command,
+               .mode = COMMAND_EXEC,
+               .help = "write memory half-word",
+               .usage = "['phys'] address value [count]",
+       },
+       {
+               .name = "mwb",
+               .handler = handle_mw_command,
+               .mode = COMMAND_EXEC,
+               .help = "write memory byte",
+               .usage = "['phys'] address value [count]",
+       },
+       {
+               .name = "bp",
+               .handler = handle_bp_command,
+               .mode = COMMAND_EXEC,
+               .help = "list or set hardware or software breakpoint",
+               .usage = "[address length ['hw']]",
+       },
+       {
+               .name = "rbp",
+               .handler = handle_rbp_command,
+               .mode = COMMAND_EXEC,
+               .help = "remove breakpoint",
+               .usage = "address",
+       },
+       {
+               .name = "wp",
+               .handler = handle_wp_command,
+               .mode = COMMAND_EXEC,
+               .help = "list (no params) or create watchpoints",
+               .usage = "[address length [('r'|'w'|'a') value [mask]]]",
+       },
+       {
+               .name = "rwp",
+               .handler = handle_rwp_command,
+               .mode = COMMAND_EXEC,
+               .help = "remove watchpoint",
+               .usage = "address",
+       },
+       {
+               .name = "load_image",
+               .handler = handle_load_image_command,
+               .mode = COMMAND_EXEC,
+               .usage = "filename address ['bin'|'ihex'|'elf'|'s19'] "
+                       "[min_address] [max_length]",
+       },
+       {
+               .name = "dump_image",
+               .handler = handle_dump_image_command,
+               .mode = COMMAND_EXEC,
+               .usage = "filename address size",
+       },
+       {
+               .name = "verify_image",
+               .handler = handle_verify_image_command,
+               .mode = COMMAND_EXEC,
+               .usage = "filename [offset [type]]",
+       },
+       {
+               .name = "test_image",
+               .handler = handle_test_image_command,
+               .mode = COMMAND_EXEC,
+               .usage = "filename [offset [type]]",
+       },
+       {
+               .name = "ocd_mem2array",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_mem2array,
+               .help = "read 8/16/32 bit memory and return as a TCL array "
+                       "for script processing",
+               .usage = "arrayname bitwidth address count",
+       },
+       {
+               .name = "ocd_array2mem",
+               .mode = COMMAND_EXEC,
+               .jim_handler = jim_array2mem,
+               .help = "convert a TCL array to memory locations "
+                       "and write the 8/16/32 bit values",
+               .usage = "arrayname bitwidth address count",
+       },
+       {
+               .name = "reset_nag",
+               .handler = handle_target_reset_nag,
+               .mode = COMMAND_ANY,
+               .help = "Nag after each reset about options that could have been "
+                               "enabled to improve performance. ",
+               .usage = "['enable'|'disable']",
+       },
+       COMMAND_REGISTRATION_DONE
+};
 int target_register_user_commands(struct command_context *cmd_ctx)
 {
        int retval = ERROR_OK;
@@ -4770,108 +5145,6 @@ int target_register_user_commands(struct command_context *cmd_ctx)
        if ((retval = trace_register_commands(cmd_ctx)) != ERROR_OK)
                return retval;
 
-       register_command(cmd_ctx, NULL, "profile",
-                       handle_profile_command, COMMAND_EXEC,
-                       "profiling samples the CPU PC");
-
-       register_jim(cmd_ctx, "ocd_mem2array", jim_mem2array,
-                       "read memory and return as a TCL array for script processing "
-                       "<ARRAYNAME> <WIDTH = 32/16/8> <ADDRESS> <COUNT>");
 
-       register_jim(cmd_ctx, "ocd_array2mem", jim_array2mem,
-                       "convert a TCL array to memory locations and write the values "
-                       "<ARRAYNAME> <WIDTH = 32/16/8> <ADDRESS> <COUNT>");
-
-       register_command(cmd_ctx, NULL, "fast_load_image",
-                       handle_fast_load_image_command, COMMAND_ANY,
-                       "same CMD_ARGV as load_image, image stored in memory "
-                       "- mainly for profiling purposes");
-
-       register_command(cmd_ctx, NULL, "fast_load",
-                       handle_fast_load_command, COMMAND_ANY,
-                       "loads active fast load image to current target "
-                       "- mainly for profiling purposes");
-
-       /** @todo don't register virt2phys() unless target supports it */
-       register_command(cmd_ctx, NULL, "virt2phys",
-                       handle_virt2phys_command, COMMAND_ANY,
-                       "translate a virtual address into a physical address");
-
-       register_command(cmd_ctx,  NULL, "reg",
-                       handle_reg_command, COMMAND_EXEC,
-                       "display or set a register");
-
-       register_command(cmd_ctx,  NULL, "poll",
-                       handle_poll_command, COMMAND_EXEC,
-                       "poll target state");
-       register_command(cmd_ctx,  NULL, "wait_halt",
-                       handle_wait_halt_command, COMMAND_EXEC,
-                       "wait for target halt [time (s)]");
-       register_command(cmd_ctx,  NULL, "halt",
-                       handle_halt_command, COMMAND_EXEC,
-                       "halt target");
-       register_command(cmd_ctx,  NULL, "resume",
-                       handle_resume_command, COMMAND_EXEC,
-                       "resume target [addr]");
-       register_command(cmd_ctx,  NULL, "reset",
-                       handle_reset_command, COMMAND_EXEC,
-                       "reset target [run | halt | init] - default is run");
-       register_command(cmd_ctx,  NULL, "soft_reset_halt",
-                       handle_soft_reset_halt_command, COMMAND_EXEC,
-                       "halt the target and do a soft reset");
-
-       register_command(cmd_ctx,  NULL, "step",
-                       handle_step_command, COMMAND_EXEC,
-                       "step one instruction from current PC or [addr]");
-
-       register_command(cmd_ctx,  NULL, "mdw",
-                       handle_md_command, COMMAND_EXEC,
-                       "display memory words [phys] <addr> [count]");
-       register_command(cmd_ctx,  NULL, "mdh",
-                       handle_md_command, COMMAND_EXEC,
-                       "display memory half-words [phys] <addr> [count]");
-       register_command(cmd_ctx,  NULL, "mdb",
-                       handle_md_command, COMMAND_EXEC,
-                       "display memory bytes [phys] <addr> [count]");
-
-       register_command(cmd_ctx,  NULL, "mww",
-                       handle_mw_command, COMMAND_EXEC,
-                       "write memory word [phys]  <addr> <value> [count]");
-       register_command(cmd_ctx,  NULL, "mwh",
-                       handle_mw_command, COMMAND_EXEC,
-                       "write memory half-word [phys]  <addr> <value> [count]");
-       register_command(cmd_ctx,  NULL, "mwb",
-                       handle_mw_command, COMMAND_EXEC,
-                       "write memory byte [phys] <addr> <value> [count]");
-
-       register_command(cmd_ctx,  NULL, "bp",
-                       handle_bp_command, COMMAND_EXEC,
-                       "list or set breakpoint [<address> <length> [hw]]");
-       register_command(cmd_ctx,  NULL, "rbp",
-                       handle_rbp_command, COMMAND_EXEC,
-                       "remove breakpoint <address>");
-
-       register_command(cmd_ctx,  NULL, "wp",
-                       handle_wp_command, COMMAND_EXEC,
-                       "list or set watchpoint "
-                               "[<address> <length> <r/w/a> [value] [mask]]");
-       register_command(cmd_ctx,  NULL, "rwp",
-                       handle_rwp_command, COMMAND_EXEC,
-                       "remove watchpoint <address>");
-
-       register_command(cmd_ctx,  NULL, "load_image",
-                       handle_load_image_command, COMMAND_EXEC,
-                       "load_image <file> <address> "
-                       "['bin'|'ihex'|'elf'|'s19'] [min_address] [max_length]");
-       register_command(cmd_ctx,  NULL, "dump_image",
-                       handle_dump_image_command, COMMAND_EXEC,
-                       "dump_image <file> <address> <size>");
-       register_command(cmd_ctx,  NULL, "verify_image",
-                       handle_verify_image_command, COMMAND_EXEC,
-                       "verify_image <file> [offset] [type]");
-       register_command(cmd_ctx,  NULL, "test_image",
-                       handle_test_image_command, COMMAND_EXEC,
-                       "test_image <file> [offset] [type]");
-
-       return ERROR_OK;
+       return register_commands(cmd_ctx, NULL, target_exec_command_handlers);
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)