helper/binarybuffer: fix clang static analyzer warnings

[openocd.git] / src / target / avr32_jtag.c

diff --git a/src/target/avr32_jtag.c b/src/target/avr32_jtag.c
index 647afd5e45f88c2ef77c38d75a14e65b12074e06..6a4d4b3e7ca02bb443d869cb9bbdec5188fae9df 100644 (file)
--- a/src/target/avr32_jtag.c
+++ b/src/target/avr32_jtag.c
@@ -12,9 +12,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -37,7 +35,7 @@ static int avr32_jtag_set_instr(struct avr32_jtag *jtag_info, int new_instr)
        if (buf_get_u32(tap->cur_instr, 0, tap->ir_length) != (uint32_t)new_instr) {
                do {
                        struct scan_field field;
-                       uint8_t t[4];
+                       uint8_t t[4] = { 0 };
                        uint8_t ret[4];
 
                        field.num_bits = tap->ir_length;
@@ -175,19 +173,15 @@ int avr32_jtag_nexus_read(struct avr32_jtag *jtag_info,
 {
        avr32_jtag_set_instr(jtag_info, AVR32_INST_NEXUS_ACCESS);
        avr32_jtag_nexus_set_address(jtag_info, addr, MODE_READ);
-       avr32_jtag_nexus_read_data(jtag_info, value);
-
-       return ERROR_OK;
-
+       return avr32_jtag_nexus_read_data(jtag_info, value);
 }
+
 int avr32_jtag_nexus_write(struct avr32_jtag *jtag_info,
                uint32_t addr, uint32_t value)
 {
        avr32_jtag_set_instr(jtag_info, AVR32_INST_NEXUS_ACCESS);
        avr32_jtag_nexus_set_address(jtag_info, addr, MODE_WRITE);
-       avr32_jtag_nexus_write_data(jtag_info, value);
-
-       return ERROR_OK;
+       return avr32_jtag_nexus_write_data(jtag_info, value);
 }
 
 int avr32_jtag_mwa_set_address(struct avr32_jtag *jtag_info, int slave,