target algo: do not write reg_param if direction is PARAM_IN
[openocd.git] / src / target / arm_jtag.c
index 305590c864cba3923af20ec626f42e595ec88875..9b73d4ea8439a80c7b6cb41a3f2c02e59dda9a3b 100644 (file)
@@ -2,6 +2,9 @@
  *   Copyright (C) 2005 by Dominic Rath                                    *
  *   Dominic.Rath@gmx.de                                                   *
  *                                                                         *
+ *   Copyright (C) 2007,2008 Ã˜yvind Harboe                                 *
+ *   oyvind.harboe@zylin.com                                               *
+ *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
  *   it under the terms of the GNU General Public License as published by  *
  *   the Free Software Foundation; either version 2 of the License, or     *
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
 #include "arm_jtag.h"
 
-#include "binarybuffer.h"
-#include "log.h"
-#include "jtag.h"
-
-#include <stdlib.h>
-
 #if 0
 #define _ARM_JTAG_SCAN_N_CHECK_
 #endif
 
-int arm_jtag_set_instr_error_handler(u8 *in_value, void *priv)
+int arm_jtag_set_instr_inner(struct jtag_tap *tap,
+               uint32_t new_instr, void *no_verify_capture, tap_state_t end_state)
 {
-       ERROR("setting the new JTAG instruction failed, debugging is likely to be broken");
-       
-       return ERROR_OK;
-}
+       struct scan_field field;
+       uint8_t t[4];
 
-int arm_jtag_set_instr(arm_jtag_t *jtag_info, u32 new_instr, error_handler_t *caller_error_handler)
-{
-       jtag_device_t *device = jtag_get_device(jtag_info->chain_pos);
-       
-       if (buf_get_u32(device->cur_instr, 0, device->ir_length) != new_instr)
-       {
-               scan_field_t field;
-       
-               field.device = jtag_info->chain_pos;
-               field.num_bits = device->ir_length;
-               field.out_value = calloc(CEIL(field.num_bits, 8), 1);
-               buf_set_u32(field.out_value, 0, field.num_bits, new_instr);
-               field.out_mask = NULL;
-               field.in_value = NULL;
-               field.in_check_value = NULL;
-               field.in_check_mask = NULL;
-               field.in_handler = NULL;
-               field.in_handler_priv = NULL;
-               
-               if (caller_error_handler)
-               {
-                       jtag_add_ir_scan(1, &field, -1, caller_error_handler);
-               }
-               else
-               {
-                       error_handler_t error_handler;
-                       error_handler.error_handler = arm_jtag_set_instr_error_handler;
-                       error_handler.error_handler_priv = NULL;
-                       jtag_add_ir_scan(1, &field, -1, &error_handler);
-               }
-               
-               
-               free(field.out_value);
-       }
-       
-       return ERROR_OK;
-}
+       field.num_bits = tap->ir_length;
+       field.out_value = t;
+       buf_set_u32(t, 0, field.num_bits, new_instr);
+       field.in_value = NULL;
 
-int arm_jtag_scann(arm_jtag_t *jtag_info, u32 new_scan_chain)
-{
-       if(jtag_info->cur_scan_chain != new_scan_chain)
-       {
-#ifdef _ARM_JTAG_SCAN_N_CHECK_
-               u8 scan_n_check_value = 0x10;
-#endif
-               scan_field_t field;
-               
-               field.device = jtag_info->chain_pos;
-               field.num_bits = jtag_info->scann_size;
-               field.out_value = calloc(CEIL(field.num_bits, 8), 1);
-               buf_set_u32(field.out_value, 0, field.num_bits, new_scan_chain);
-               field.out_mask = NULL;
-               field.in_value = NULL;
-#ifdef _ARM_JTAG_SCAN_N_CHECK_
-               field.in_check_value = &scan_n_check_value;
-#else
-               field.in_check_value = NULL;
-#endif 
-               field.in_check_mask = NULL;
-               field.in_handler = NULL;
-               field.in_handler_priv = NULL;
-               
-               arm_jtag_set_instr(jtag_info, jtag_info->scann_instr, NULL);
-               jtag_add_dr_scan(1, &field, -1, NULL);
-               
-               jtag_info->cur_scan_chain = new_scan_chain;
-               
-               free(field.out_value);
+       if (no_verify_capture == NULL)
+               jtag_add_ir_scan(tap, &field, end_state);
+       else {
+               /* FIX!!!! this is a kludge!!! arm926ejs.c should reimplement this arm_jtag_set_instr to
+                * have special verification code.
+                */
+               jtag_add_ir_scan_noverify(tap, &field, end_state);
        }
-       
-       return ERROR_OK;
-}
 
-int arm_jtag_reset_callback(enum jtag_event event, void *priv)
-{
-       arm_jtag_t *jtag_info = priv;
-       
-       if (event == JTAG_TRST_ASSERTED)
-       {
-               jtag_info->cur_scan_chain = 0;
-       }
-       
        return ERROR_OK;
 }
 
-int arm_jtag_setup_connection(arm_jtag_t *jtag_info)
+int arm_jtag_scann_inner(struct arm_jtag *jtag_info, uint32_t new_scan_chain, tap_state_t end_state)
 {
-       jtag_info->scann_instr = 0x2;
-       jtag_info->cur_scan_chain = 0;
-       jtag_info->intest_instr = 0xc;
+       int retval = ERROR_OK;
 
-       jtag_register_event_callback(arm_jtag_reset_callback, jtag_info);
-       
-       return ERROR_OK;
-}
+       uint8_t out_value[4];
+       buf_set_u32(out_value, 0, jtag_info->scann_size, new_scan_chain);
+       struct scan_field field = { .num_bits = jtag_info->scann_size, .out_value = out_value, };
 
-/* read JTAG buffer into host-endian u32, flipping bit-order */
-int arm_jtag_buf_to_u32_flip(u8 *in_buf, void *priv)
-{
-       u32 *dest = priv;
-       *dest = flip_u32(le_to_h_u32(in_buf), 32);
-       return ERROR_OK;
-}
+       retval = arm_jtag_set_instr(jtag_info->tap, jtag_info->scann_instr, NULL, end_state);
+       if (retval != ERROR_OK)
+               return retval;
 
-/* read JTAG buffer into little-endian u32, flipping bit-order */
-int arm_jtag_buf_to_le32_flip(u8 *in_buf, void *priv)
-{
-       h_u32_to_le(((u8*)priv), flip_u32(le_to_h_u32(in_buf), 32));
-       return ERROR_OK;
-}
+       jtag_add_dr_scan(jtag_info->tap,
+                       1,
+                       &field,
+                       end_state);
 
-/* read JTAG buffer into little-endian u16, flipping bit-order */
-int arm_jtag_buf_to_le16_flip(u8 *in_buf, void *priv)
-{
-       h_u16_to_le(((u8*)priv), flip_u32(le_to_h_u32(in_buf), 32) & 0xffff);
-       return ERROR_OK;
-}
-
-/* read JTAG buffer into big-endian u32, flipping bit-order */
-int arm_jtag_buf_to_be32_flip(u8 *in_buf, void *priv)
-{
-       h_u32_to_be(((u8*)priv), flip_u32(le_to_h_u32(in_buf), 32));
-       return ERROR_OK;
-}
+       jtag_info->cur_scan_chain = new_scan_chain;
 
-/* read JTAG buffer into big-endian u16, flipping bit-order */
-int arm_jtag_buf_to_be16_flip(u8 *in_buf, void *priv)
-{
-       h_u16_to_be(((u8*)priv), flip_u32(le_to_h_u32(in_buf), 32) & 0xffff);
-       return ERROR_OK;
-}
-
-/* read JTAG buffer into u8, flipping bit-order */
-int arm_jtag_buf_to_8_flip(u8 *in_buf, void *priv)
-{
-       u8 *dest = priv;
-       *dest = flip_u32(le_to_h_u32(in_buf), 32) & 0xff;
-       return ERROR_OK;
-}
-
-/* not-flipping variants */
-/* read JTAG buffer into host-endian u32 */
-int arm_jtag_buf_to_u32(u8 *in_buf, void *priv)
-{
-       u32 *dest = priv;
-       *dest = le_to_h_u32(in_buf);
-       return ERROR_OK;
+       return retval;
 }
 
-/* read JTAG buffer into little-endian u32 */
-int arm_jtag_buf_to_le32(u8 *in_buf, void *priv)
+static int arm_jtag_reset_callback(enum jtag_event event, void *priv)
 {
-       h_u32_to_le(((u8*)priv), le_to_h_u32(in_buf));
-       return ERROR_OK;
-}
+       struct arm_jtag *jtag_info = priv;
 
-/* read JTAG buffer into little-endian u16 */
-int arm_jtag_buf_to_le16(u8 *in_buf, void *priv)
-{
-       h_u16_to_le(((u8*)priv), le_to_h_u32(in_buf) & 0xffff);
-       return ERROR_OK;
-}
+       if (event == JTAG_TRST_ASSERTED)
+               jtag_info->cur_scan_chain = 0;
 
-/* read JTAG buffer into big-endian u32 */
-int arm_jtag_buf_to_be32(u8 *in_buf, void *priv)
-{
-       h_u32_to_be(((u8*)priv), le_to_h_u32(in_buf));
        return ERROR_OK;
 }
 
-/* read JTAG buffer into big-endian u16 */
-int arm_jtag_buf_to_be16(u8 *in_buf, void *priv)
+int arm_jtag_setup_connection(struct arm_jtag *jtag_info)
 {
-       h_u16_to_be(((u8*)priv), le_to_h_u32(in_buf) & 0xffff);
-       return ERROR_OK;
-}
+       jtag_info->scann_instr = 0x2;
+       jtag_info->cur_scan_chain = 0;
+       jtag_info->intest_instr = 0xc;
 
-/* read JTAG buffer into u8 */
-int arm_jtag_buf_to_8(u8 *in_buf, void *priv)
-{
-       u8 *dest = priv;
-       *dest = le_to_h_u32(in_buf) & 0xff;
-       return ERROR_OK;
+       return jtag_register_event_callback(arm_jtag_reset_callback, jtag_info);
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)