rtt_server: Add option for a message when client connects
[openocd.git] / src / server / rtt_server.c
index df2247bacd004cc18e0f111c25f695fc2840a3a8..97691534751caf1e29c44023d8cc8f87b7040ea7 100644 (file)
@@ -25,6 +25,7 @@
 
 struct rtt_service {
        unsigned int channel;
+       char *hello_message;
 };
 
 static int read_callback(unsigned int channel, const uint8_t *buffer,
@@ -65,6 +66,9 @@ static int rtt_new_connection(struct connection *connection)
        if (ret != ERROR_OK)
                return ret;
 
+       if (service->hello_message)
+               connection_write(connection, service->hello_message, strlen(service->hello_message));
+
        return ERROR_OK;
 }
 
@@ -117,16 +121,30 @@ COMMAND_HANDLER(handle_rtt_start_command)
        int ret;
        struct rtt_service *service;
 
-       if (CMD_ARGC != 2)
+       if (CMD_ARGC < 2 || CMD_ARGC > 3)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
-       service = malloc(sizeof(struct rtt_service));
+       service = calloc(1, sizeof(struct rtt_service));
 
        if (!service)
                return ERROR_FAIL;
 
        COMMAND_PARSE_NUMBER(uint, CMD_ARGV[1], service->channel);
 
+       if (CMD_ARGC >= 3) {
+               const char *hello_message = CMD_ARGV[2];
+               size_t hello_length = strlen(hello_message);
+
+               service->hello_message = malloc(hello_length + 2);
+               if (!service->hello_message) {
+                       LOG_ERROR("Out of memory");
+                       free(service);
+                       return ERROR_FAIL;
+               }
+               strcpy(service->hello_message, hello_message);
+               service->hello_message[hello_length] = '\n';
+               service->hello_message[hello_length + 1] = '\0';
+       }
        ret = add_service(&rtt_service_driver, CMD_ARGV[0], CONNECTION_LIMIT_UNLIMITED, service);
 
        if (ret != ERROR_OK) {
@@ -153,7 +171,7 @@ static const struct command_registration rtt_server_subcommand_handlers[] = {
                .handler = handle_rtt_start_command,
                .mode = COMMAND_ANY,
                .help = "Start a RTT server",
-               .usage = "<port> <channel>"
+               .usage = "<port> <channel> [message]"
        },
        {
                .name = "stop",

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)