jtag/drivers: fix reset logic handling in OpenJTAG
[openocd.git] / src / jtag / drivers / openjtag.c
index 1c79a2c9b65a468f8fb26e254cf3fd887e7cb88e..086a411d6b5be76118b124a328bfe996a76cef80 100644 (file)
@@ -671,14 +671,12 @@ static void openjtag_execute_reset(struct jtag_command *cmd)
 
        uint8_t buf = 0x00;
 
-       if (cmd->cmd.reset->trst) {
-               buf = 0x03;
-       } else {
+       /* Pull SRST low for 5 TCLK cycles */
+       if (cmd->cmd.reset->srst) {
                buf |= 0x04;
                buf |= 0x05 << 4;
+               openjtag_add_byte(buf);
        }
-
-       openjtag_add_byte(buf);
 }
 
 static void openjtag_execute_sleep(struct jtag_command *cmd)
@@ -691,8 +689,14 @@ static void openjtag_set_state(uint8_t openocd_state)
        uint8_t state = openjtag_get_tap_state(openocd_state);
 
        uint8_t buf = 0;
-       buf = 0x01;
-       buf |= state << 4;
+
+       if (state != OPENJTAG_TAP_RESET) {
+               buf = 0x01;
+               buf |= state << 4;
+       } else {
+               /* Force software TLR */
+               buf = 0x03;
+       }
 
        openjtag_add_byte(buf);
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)