debug_level 3 now prints seconds since start of openocd
[openocd.git] / src / helper / fileio.c
index 7075fc160ba30f9dd0e49414689e0cad498e975b..07eae786fd22f0480af934cc7f5b3cf8442e0b72 100644 (file)
@@ -44,26 +44,6 @@ int fileio_open_local(fileio_t *fileio)
        fileio_local_t *fileio_local = malloc(sizeof(fileio_local_t));
        char access[4];
        
-       fileio->location_private = fileio_local;
-       
-       if ((fileio->access != FILEIO_WRITE) && (fileio->access != FILEIO_READWRITE))
-       {
-               if (stat(fileio->url, &fileio_local->file_stat) == -1)
-               {
-                       free(fileio_local);
-                       snprintf(fileio->error_str, FILEIO_MAX_ERROR_STRING,
-                               "couldn't stat() %s: %s", fileio->url, strerror(errno));
-                       return ERROR_FILEIO_NOT_FOUND;
-               }
-       
-               if (S_ISDIR(fileio_local->file_stat.st_mode))
-               {
-                       free(fileio_local);
-                       snprintf(fileio->error_str, FILEIO_MAX_ERROR_STRING, "%s is a directory", fileio->url);
-                       return ERROR_FILEIO_NOT_FOUND;
-               }
-       }
-       
        switch (fileio->access)
        {
                case FILEIO_READ:
@@ -86,20 +66,14 @@ int fileio_open_local(fileio_t *fileio)
                        ERROR("BUG: access neither read, write nor readwrite");
                        return ERROR_INVALID_ARGUMENTS;
        }
-       
-       if (fileio->access == FILEIO_READ)
-       {
-               if (fileio_local->file_stat.st_size == 0)
-               {
-                       /* tried to open an empty file for reading */
-                       free(fileio_local);
-                       snprintf(fileio->error_str, FILEIO_MAX_ERROR_STRING, "empty file %s", fileio->url);
-                       return ERROR_FILEIO_OPERATION_FAILED;
-               }
-       }
-       
+
+       /* win32 always opens in binary mode */
+#ifndef _WIN32
        if (fileio->type == FILEIO_BINARY)
+#endif
+       {
                strcat(access, "b");
+       }
        
        if (!(fileio_local->file = fopen(fileio->url, access)))
        {
@@ -110,13 +84,30 @@ int fileio_open_local(fileio_t *fileio)
        
        if ((fileio->access != FILEIO_WRITE) || (fileio->access == FILEIO_READWRITE))
        {
-               fileio->size = fileio_local->file_stat.st_size;
+               /* NB! Here we use fseek() instead of stat(), since stat is a
+                * more advanced operation that might not apply to e.g. a disk path
+                * that refers to e.g. a tftp client */
+               int result, result2;
+               
+               result = fseek(fileio_local->file, 0, SEEK_END);
+               
+               fileio->size = ftell(fileio_local->file);
+               
+               result2 = fseek(fileio_local->file, 0, SEEK_SET); 
+                       
+               if ((fileio->size < 0) || (result < 0) || (result2 < 0))
+               {
+                       fileio_close(fileio);
+                       return ERROR_FILEIO_OPERATION_FAILED;
+               }
        }
        else
        {
                fileio->size = 0x0;
        }
        
+       fileio->location_private = fileio_local;
+       
        return ERROR_OK;
 }
 
@@ -125,17 +116,14 @@ int fileio_open(fileio_t *fileio, char *url, enum fileio_access access,   enum fil
        int retval = ERROR_OK;
        char *resource_identifier = NULL;
 
-       /* try to identify file location */
+       /* try to identify file location. We only hijack the file paths we understand, the rest is
+        * passed on to the OS which might implement e.g. tftp via a mounted tftp device.
+        */
        if ((resource_identifier = strstr(url, "bootp://")) && (resource_identifier == url))
        {
                ERROR("bootp resource location isn't supported yet");
                return ERROR_FILEIO_RESOURCE_TYPE_UNKNOWN;
        }
-       else if ((resource_identifier = strstr(url, "tftp://")) && (resource_identifier == url))
-       {
-               ERROR("tftp resource location isn't supported yet");
-               return ERROR_FILEIO_RESOURCE_TYPE_UNKNOWN;
-       }
        else
        {
                /* default to local files */
@@ -167,6 +155,12 @@ int fileio_close_local(fileio_t *fileio)
        int retval;
        fileio_local_t *fileio_local = fileio->location_private;
        
+       if (fileio->location_private == NULL)
+       {
+               snprintf(fileio->error_str, FILEIO_MAX_ERROR_STRING, "couldn't close %s: ", fileio->url);
+               return ERROR_FILEIO_OPERATION_FAILED;
+       }
+       
        if ((retval = fclose(fileio_local->file)) != 0)
        {
                if (retval == EBADF)
@@ -182,6 +176,7 @@ int fileio_close_local(fileio_t *fileio)
        }
        
        free(fileio->location_private);
+       fileio->location_private = NULL;
        
        return ERROR_OK;
 }
@@ -204,6 +199,7 @@ int fileio_close(fileio_t *fileio)
                return retval;
        
        free(fileio->url);
+       fileio->url = NULL;
        
        return ERROR_OK;
 }
@@ -279,6 +275,29 @@ int fileio_read_u32(fileio_t *fileio, u32 *data)
        return ERROR_OK;
 }
 
+int fileio_local_fgets(fileio_t *fileio, u32 size, u8 *buffer)
+{
+       fileio_local_t *fileio_local = fileio->location_private;
+       
+       if( fgets(buffer, size, fileio_local->file) == NULL)
+               return ERROR_FILEIO_OPERATION_FAILED;
+       
+       return ERROR_OK;
+}
+
+int fileio_fgets(fileio_t *fileio, u32 size, u8 *buffer)
+{
+       switch (fileio->location)
+       {
+               case FILEIO_LOCAL:
+                       return fileio_local_fgets(fileio, size, buffer);
+                       break;
+               default:
+                       ERROR("BUG: should never get here");
+                       exit(-1);
+       }
+}
+
 int fileio_local_write(fileio_t *fileio, u32 size, u8 *buffer, u32 *size_written)
 {
        fileio_local_t *fileio_local = fileio->location_private;
@@ -290,16 +309,22 @@ int fileio_local_write(fileio_t *fileio, u32 size, u8 *buffer, u32 *size_written
 
 int fileio_write(fileio_t *fileio, u32 size, u8 *buffer, u32 *size_written)
 {
+       int retval;
+       
        switch (fileio->location)
        {
                case FILEIO_LOCAL:
-                       return fileio_local_write(fileio, size, buffer, size_written);
+                       retval = fileio_local_write(fileio, size, buffer, size_written);
                        break;
                default:
                        ERROR("BUG: should never get here");
+                       exit(-1);
        }
        
-       return ERROR_OK;
+       if (retval == ERROR_OK)
+               fileio->size += *size_written;
+       
+       return retval;;
 }
 
 int fileio_write_u32(fileio_t *fileio, u32 data)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)