helper/command: simplify script_command_args_alloc()
[openocd.git] / src / helper / command.c
index 96023336c9bafe743a300c2d36371824916a7dda..f7ec0e21faf4ef929aed457cc22154de8f4a5a02 100644 (file)
@@ -161,15 +161,13 @@ static void script_command_args_free(char **words, unsigned nwords)
        free(words);
 }
 
-static char **script_command_args_alloc(
-       unsigned argc, Jim_Obj * const *argv, unsigned *nwords)
+static char **script_command_args_alloc(unsigned int argc, Jim_Obj * const *argv)
 {
        char **words = malloc(argc * sizeof(char *));
        if (!words)
                return NULL;
 
-       unsigned i;
-       for (i = 0; i < argc; i++) {
+       for (unsigned int i = 0; i < argc; i++) {
                const char *w = Jim_GetString(argv[i], NULL);
                words[i] = strdup(w);
                if (!words[i]) {
@@ -177,7 +175,6 @@ static char **script_command_args_alloc(
                        return NULL;
                }
        }
-       *nwords = i;
        return words;
 }
 
@@ -901,8 +898,8 @@ static int exec_command(Jim_Interp *interp, struct command_context *cmd_ctx,
                return c->jim_handler(interp, argc, argv);
 
        /* use c->handler */
-       unsigned int nwords;
-       char **words = script_command_args_alloc(argc, argv, &nwords);
+       unsigned int nwords = argc;
+       char **words = script_command_args_alloc(argc, argv);
        if (!words)
                return JIM_ERR;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)