Change return value on error.
[openocd.git] / src / flash / nand / lpc32xx.c
index 5cde90c490d8563ff0043191a36841b91ba3ad35..addc323b132599ce5d6be7de8b1e413cd3ae7d84 100644 (file)
@@ -75,8 +75,7 @@ static dmac_ll_t dmalist[(2048/256) * 2 + 1];
 NAND_DEVICE_COMMAND_HANDLER(lpc32xx_nand_device_command)
 {
        if (CMD_ARGC < 3) {
-               LOG_WARNING("incomplete 'lpc32xx' nand flash configuration");
-               return ERROR_FLASH_BANK_INVALID;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        uint32_t osc_freq;
@@ -214,8 +213,8 @@ static int lpc32xx_init(struct nand_device *nand)
        /* inform calling code about selected bus width */
        nand->bus_width = bus_width;
 
-       if ((address_cycles != 3) && (address_cycles != 4)) {
-               LOG_ERROR("LPC32xx driver doesn't support %i", address_cycles);
+       if ((address_cycles < 3) || (address_cycles > 5)) {
+               LOG_ERROR("LPC32xx driver doesn't support %i address cycles", address_cycles);
                return ERROR_NAND_OPERATION_NOT_SUPPORTED;
        }
 
@@ -227,8 +226,8 @@ static int lpc32xx_init(struct nand_device *nand)
        /* select MLC controller if none is currently selected */
        if (lpc32xx_info->selected_controller == LPC32xx_NO_CONTROLLER) {
                LOG_DEBUG("no LPC32xx NAND flash controller selected, "
-                         "using default 'mlc'");
-               lpc32xx_info->selected_controller = LPC32xx_MLC_CONTROLLER;
+                         "using default 'slc'");
+               lpc32xx_info->selected_controller = LPC32xx_SLC_CONTROLLER;
        }
 
        if (lpc32xx_info->selected_controller == LPC32xx_MLC_CONTROLLER) {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)