flash: npcx: fix memory leak in npcx_flash_bank_command

Recent commit 62f76b216930 ("flash/nor: add support for Nuvoton
NPCX4/K3 series flash") introduces a memory leak for a missing
free() on early return for an error.

Add the free() on the return path on error.

Change-Id: Ica8568a986802e23df2ab7bed4e8cc4bbb6305a5
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: 62f76b216930 ("flash/nor: add support for Nuvoton NPCX4/K3 series flash")
Reviewed-on: https://review.openocd.org/c/openocd/+/7894
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c
index 7304a6841266d0d225fbe32f2e91201ba2267b49..4a301f1e9816a2905f814ed5676f3cd17ad754b4 100644 (file)
--- a/src/flash/nor/npcx.c
+++ b/src/flash/nor/npcx.c
@@ -321,6 +321,7 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command)
                        npcx_bank->fiu_ver = NPCX_FIU_NPCK;
                } else {
                        LOG_ERROR("%s is not a valid fiu", fiu);
+                       free(npcx_bank);
                        return ERROR_TARGET_INVALID;
                }
        }