David Brownell <david-b@pacbell.net> Tweak disassembly commands:
[openocd.git] / src / target / cortex_m3.c
index ea20dfd14fd47b32a1e2935226b4713ded3ec34b..df00fc19e9ec4fb3e9f64d3b9603311ea58c3b94 100644 (file)
@@ -1702,23 +1702,27 @@ handle_cortex_m3_disassemble_command(struct command_context_s *cmd_ctx,
        int retval = ERROR_OK;
        target_t *target = get_current_target(cmd_ctx);
        uint32_t address;
-       unsigned long count;
+       unsigned long count = 1;
        arm_instruction_t cur_instruction;
 
-       if (argc != 2) {
+       errno = 0;
+       switch (argc) {
+       case 2:
+               count = strtoul(args[1], NULL, 0);
+               if (errno)
+                       return ERROR_FAIL;
+               /* FALL THROUGH */
+       case 1:
+               address = strtoul(args[0], NULL, 0);
+               if (errno)
+                       return ERROR_FAIL;
+               break;
+       default:
                command_print(cmd_ctx,
-                       "usage: cortex_m3 disassemble <address> <count>");
+                       "usage: cortex_m3 disassemble <address> [<count>]");
                return ERROR_OK;
        }
 
-       errno = 0;
-       address = strtoul(args[0], NULL, 0);
-       if (errno)
-               return ERROR_FAIL;
-       count = strtoul(args[1], NULL, 0);
-       if (errno)
-               return ERROR_FAIL;
-
        while (count--) {
                retval = thumb2_opcode(target, address, &cur_instruction);
                if (retval != ERROR_OK)
@@ -1809,7 +1813,7 @@ int cortex_m3_register_commands(struct command_context_s *cmd_ctx)
 
        register_command(cmd_ctx, cortex_m3_cmd, "disassemble",
                        handle_cortex_m3_disassemble_command, COMMAND_EXEC,
-                       "disassemble Thumb2 instructions <address> <count>");
+                       "disassemble Thumb2 instructions <address> [<count>]");
        register_command(cmd_ctx, cortex_m3_cmd, "maskisr",
                        handle_cortex_m3_mask_interrupts_command, COMMAND_EXEC,
                        "mask cortex_m3 interrupts ['on'|'off']");

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)