+// SPDX-License-Identifier: GPL-2.0-or-later
+
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
* Dominic.Rath@gmx.de *
* *
* Copyright (C) ST-Ericsson SA 2011 *
* michel.jaouen@stericsson.com : smp minimum support *
- * *
- * This program is free software; you can redistribute it and/or modify *
- * it under the terms of the GNU General Public License as published by *
- * the Free Software Foundation; either version 2 of the License, or *
- * (at your option) any later version. *
- * *
- * This program is distributed in the hope that it will be useful, *
- * but WITHOUT ANY WARRANTY; without even the implied warranty of *
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
- * GNU General Public License for more details. *
- * *
- * You should have received a copy of the GNU General Public License *
- * along with this program. If not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/
#ifdef HAVE_CONFIG_H
#include "target.h"
#include <helper/log.h>
#include "breakpoints.h"
+#include "smp.h"
static const char * const breakpoint_type_strings[] = {
"hardware",
(*breakpoint_p)->asid = 0;
(*breakpoint_p)->length = length;
(*breakpoint_p)->type = type;
- (*breakpoint_p)->set = 0;
+ (*breakpoint_p)->is_set = false;
(*breakpoint_p)->orig_instr = malloc(length);
(*breakpoint_p)->next = NULL;
(*breakpoint_p)->unique_id = bpwp_unique_id++;
(*breakpoint_p)->asid = asid;
(*breakpoint_p)->length = length;
(*breakpoint_p)->type = type;
- (*breakpoint_p)->set = 0;
+ (*breakpoint_p)->is_set = false;
(*breakpoint_p)->orig_instr = malloc(length);
(*breakpoint_p)->next = NULL;
(*breakpoint_p)->unique_id = bpwp_unique_id++;
(*breakpoint_p)->asid = asid;
(*breakpoint_p)->length = length;
(*breakpoint_p)->type = type;
- (*breakpoint_p)->set = 0;
+ (*breakpoint_p)->is_set = false;
(*breakpoint_p)->orig_instr = malloc(length);
(*breakpoint_p)->next = NULL;
(*breakpoint_p)->unique_id = bpwp_unique_id++;
uint32_t length,
enum breakpoint_type type)
{
- int retval = ERROR_OK;
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- if (type == BKPT_SOFT)
+
+ if (type == BKPT_SOFT) {
+ head = list_first_entry(target->smp_targets, struct target_list, lh);
return breakpoint_add_internal(head->target, address, length, type);
+ }
- while (head) {
- curr = head->target;
- retval = breakpoint_add_internal(curr, address, length, type);
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int retval = breakpoint_add_internal(curr, address, length, type);
if (retval != ERROR_OK)
return retval;
- head = head->next;
}
- return retval;
+
+ return ERROR_OK;
} else {
return breakpoint_add_internal(target, address, length, type);
}
uint32_t length,
enum breakpoint_type type)
{
- int retval = ERROR_OK;
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- retval = context_breakpoint_add_internal(curr, asid, length, type);
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int retval = context_breakpoint_add_internal(curr, asid, length, type);
if (retval != ERROR_OK)
return retval;
- head = head->next;
}
- return retval;
+
+ return ERROR_OK;
} else {
return context_breakpoint_add_internal(target, asid, length, type);
}
uint32_t length,
enum breakpoint_type type)
{
- int retval = ERROR_OK;
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- retval = hybrid_breakpoint_add_internal(curr, address, asid, length, type);
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int retval = hybrid_breakpoint_add_internal(curr, address, asid, length, type);
if (retval != ERROR_OK)
return retval;
- head = head->next;
}
- return retval;
+
+ return ERROR_OK;
} else
return hybrid_breakpoint_add_internal(target, address, asid, length, type);
}
/* free up a breakpoint */
-static void breakpoint_free(struct target *target, struct breakpoint *breakpoint_to_remove)
+static int breakpoint_free(struct target *target, struct breakpoint *breakpoint_to_remove)
{
struct breakpoint *breakpoint = target->breakpoints;
struct breakpoint **breakpoint_p = &target->breakpoints;
}
if (!breakpoint)
- return;
+ return ERROR_OK;
retval = target_remove_breakpoint(target, breakpoint);
+ if (retval != ERROR_OK) {
+ LOG_TARGET_ERROR(target, "could not remove breakpoint #%d on this target",
+ breakpoint->number);
+ return retval;
+ }
LOG_DEBUG("free BPID: %" PRIu32 " --> %d", breakpoint->unique_id, retval);
(*breakpoint_p) = breakpoint->next;
free(breakpoint->orig_instr);
free(breakpoint);
+
+ return ERROR_OK;
}
static int breakpoint_remove_internal(struct target *target, target_addr_t address)
}
if (breakpoint) {
- breakpoint_free(target, breakpoint);
- return 1;
+ return breakpoint_free(target, breakpoint);
} else {
- if (!target->smp)
- LOG_ERROR("no breakpoint at address " TARGET_ADDR_FMT " found", address);
- return 0;
+ return ERROR_BREAKPOINT_NOT_FOUND;
}
}
-static void breakpoint_remove_all_internal(struct target *target)
+static int breakpoint_remove_all_internal(struct target *target)
{
struct breakpoint *breakpoint = target->breakpoints;
+ int retval = ERROR_OK;
while (breakpoint) {
struct breakpoint *tmp = breakpoint;
breakpoint = breakpoint->next;
- breakpoint_free(target, tmp);
+ int status = breakpoint_free(target, tmp);
+ if (status != ERROR_OK)
+ retval = status;
}
+
+ return retval;
}
-void breakpoint_remove(struct target *target, target_addr_t address)
+int breakpoint_remove(struct target *target, target_addr_t address)
{
+ int retval = ERROR_OK;
+ unsigned int num_found_breakpoints = 0;
if (target->smp) {
- unsigned int num_breakpoints = 0;
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- num_breakpoints += breakpoint_remove_internal(curr, address);
- head = head->next;
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int status = breakpoint_remove_internal(curr, address);
+
+ if (status != ERROR_BREAKPOINT_NOT_FOUND) {
+ num_found_breakpoints++;
+
+ if (status != ERROR_OK) {
+ LOG_TARGET_ERROR(curr, "failed to remove breakpoint at address " TARGET_ADDR_FMT, address);
+ retval = status;
+ }
+ }
}
- if (!num_breakpoints)
- LOG_ERROR("no breakpoint at address " TARGET_ADDR_FMT " found", address);
+
} else {
- breakpoint_remove_internal(target, address);
+ retval = breakpoint_remove_internal(target, address);
+
+ if (retval != ERROR_BREAKPOINT_NOT_FOUND) {
+ num_found_breakpoints++;
+
+ if (retval != ERROR_OK)
+ LOG_TARGET_ERROR(target, "failed to remove breakpoint at address " TARGET_ADDR_FMT, address);
+ }
}
+
+ if (num_found_breakpoints == 0)
+ LOG_TARGET_ERROR(target, "no breakpoint at address " TARGET_ADDR_FMT " found", address);
+
+ return retval;
}
-void breakpoint_remove_all(struct target *target)
+int breakpoint_remove_all(struct target *target)
{
+ int retval = ERROR_OK;
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- breakpoint_remove_all_internal(curr);
- head = head->next;
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int status = breakpoint_remove_all_internal(curr);
+
+ if (status != ERROR_OK)
+ retval = status;
}
} else {
- breakpoint_remove_all_internal(target);
+ retval = breakpoint_remove_all_internal(target);
}
+
+ return retval;
}
-static void breakpoint_clear_target_internal(struct target *target)
+static int breakpoint_clear_target_internal(struct target *target)
{
LOG_DEBUG("Delete all breakpoints for target: %s",
target_name(target));
- while (target->breakpoints)
- breakpoint_free(target, target->breakpoints);
+
+ int retval = ERROR_OK;
+
+ while (target->breakpoints) {
+ int status = breakpoint_free(target, target->breakpoints);
+ if (status != ERROR_OK)
+ retval = status;
+ }
+
+ return retval;
}
-void breakpoint_clear_target(struct target *target)
+int breakpoint_clear_target(struct target *target)
{
+ int retval = ERROR_OK;
+
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- breakpoint_clear_target_internal(curr);
- head = head->next;
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int status = breakpoint_clear_target_internal(curr);
+
+ if (status != ERROR_OK)
+ retval = status;
}
} else {
- breakpoint_clear_target_internal(target);
+ retval = breakpoint_clear_target_internal(target);
}
+
+ return retval;
}
struct breakpoint *breakpoint_find(struct target *target, target_addr_t address)
return NULL;
}
-int watchpoint_add_internal(struct target *target, target_addr_t address,
- uint32_t length, enum watchpoint_rw rw, uint32_t value, uint32_t mask)
+static int watchpoint_add_internal(struct target *target, target_addr_t address,
+ uint32_t length, enum watchpoint_rw rw, uint64_t value, uint64_t mask)
{
struct watchpoint *watchpoint = target->watchpoints;
struct watchpoint **watchpoint_p = &target->watchpoints;
}
int watchpoint_add(struct target *target, target_addr_t address,
- uint32_t length, enum watchpoint_rw rw, uint32_t value, uint32_t mask)
+ uint32_t length, enum watchpoint_rw rw, uint64_t value, uint64_t mask)
{
- int retval = ERROR_OK;
if (target->smp) {
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head != (struct target_list *)NULL) {
- curr = head->target;
- retval = watchpoint_add_internal(curr, address, length, rw, value,
- mask);
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int retval = watchpoint_add_internal(curr, address, length, rw, value, mask);
if (retval != ERROR_OK)
return retval;
- head = head->next;
}
- return retval;
+
+ return ERROR_OK;
} else {
return watchpoint_add_internal(target, address, length, rw, value,
mask);
}
}
-static void watchpoint_free(struct target *target, struct watchpoint *watchpoint_to_remove)
+static int watchpoint_free(struct target *target, struct watchpoint *watchpoint_to_remove)
{
struct watchpoint *watchpoint = target->watchpoints;
struct watchpoint **watchpoint_p = &target->watchpoints;
}
if (!watchpoint)
- return;
+ return ERROR_OK;
retval = target_remove_watchpoint(target, watchpoint);
+ if (retval != ERROR_OK) {
+ LOG_TARGET_ERROR(target, "could not remove watchpoint #%d on this target",
+ watchpoint->number);
+ return retval;
+ }
+
LOG_DEBUG("free WPID: %d --> %d", watchpoint->unique_id, retval);
(*watchpoint_p) = watchpoint->next;
free(watchpoint);
+
+ return ERROR_OK;
}
-int watchpoint_remove_internal(struct target *target, target_addr_t address)
+static int watchpoint_remove_internal(struct target *target, target_addr_t address)
{
struct watchpoint *watchpoint = target->watchpoints;
}
if (watchpoint) {
- watchpoint_free(target, watchpoint);
- return 1;
+ return watchpoint_free(target, watchpoint);
} else {
- if (!target->smp)
- LOG_ERROR("no watchpoint at address " TARGET_ADDR_FMT " found", address);
- return 0;
+ return ERROR_WATCHPOINT_NOT_FOUND;
}
}
-void watchpoint_remove(struct target *target, target_addr_t address)
+int watchpoint_remove(struct target *target, target_addr_t address)
{
+ int retval = ERROR_OK;
+ unsigned int num_found_watchpoints = 0;
if (target->smp) {
- unsigned int num_watchpoints = 0;
struct target_list *head;
- struct target *curr;
- head = target->head;
- while (head) {
- curr = head->target;
- num_watchpoints += watchpoint_remove_internal(curr, address);
- head = head->next;
+
+ foreach_smp_target(head, target->smp_targets) {
+ struct target *curr = head->target;
+ int status = watchpoint_remove_internal(curr, address);
+
+ if (status != ERROR_WATCHPOINT_NOT_FOUND) {
+ num_found_watchpoints++;
+
+ if (status != ERROR_OK) {
+ LOG_TARGET_ERROR(curr, "failed to remove watchpoint at address" TARGET_ADDR_FMT, address);
+ retval = status;
+ }
+ }
}
- if (num_watchpoints == 0)
- LOG_ERROR("no watchpoint at address " TARGET_ADDR_FMT " num_watchpoints", address);
} else {
- watchpoint_remove_internal(target, address);
+ retval = watchpoint_remove_internal(target, address);
+
+ if (retval != ERROR_WATCHPOINT_NOT_FOUND) {
+ num_found_watchpoints++;
+
+ if (retval != ERROR_OK)
+ LOG_TARGET_ERROR(target, "failed to remove watchpoint at address" TARGET_ADDR_FMT, address);
+ }
}
+
+ if (num_found_watchpoints == 0)
+ LOG_TARGET_ERROR(target, "no watchpoint at address " TARGET_ADDR_FMT " found", address);
+
+ return retval;
}
-void watchpoint_clear_target(struct target *target)
+int watchpoint_clear_target(struct target *target)
{
+ int retval = ERROR_OK;
+
LOG_DEBUG("Delete all watchpoints for target: %s",
target_name(target));
- while (target->watchpoints)
- watchpoint_free(target, target->watchpoints);
+ while (target->watchpoints) {
+ int status = watchpoint_free(target, target->watchpoints);
+ if (status != ERROR_OK)
+ retval = status;
+ }
+
+ return retval;
}
int watchpoint_hit(struct target *target, enum watchpoint_rw *rw,