rtos/riot: fix out-of-bounds read of optional symbols array
[openocd.git] / src / rtos / zephyr.c
index b594b2b531366f3f487d3a2f1e037e8745c3caec..a5967355706e90764ab68ca02129cf2486749d55 100644 (file)
@@ -340,6 +340,14 @@ static struct zephyr_params zephyr_params_list[] = {
                .cpu_saved_fp_stacking = &arm_cpu_saved_fp_stacking,
                .get_cpu_state = &zephyr_get_arm_state,
        },
+       {
+               .target_name = "cortex_r4",
+               .pointer_width = 4,
+               .callee_saved_stacking = &arm_callee_saved_stacking,
+               .cpu_saved_nofp_stacking = &arm_cpu_saved_nofp_stacking,
+               .cpu_saved_fp_stacking = &arm_cpu_saved_fp_stacking,
+               .get_cpu_state = &zephyr_get_arm_state,
+       },
        {
                .target_name = "hla_target",
                .pointer_width = 4,
@@ -385,7 +393,7 @@ static const struct symbol_table_elem zephyr_symbol_list[] = {
 
 static bool zephyr_detect_rtos(struct target *target)
 {
-       if (target->rtos->symbols == NULL) {
+       if (!target->rtos->symbols) {
                LOG_INFO("Zephyr: no symbols while detecting RTOS");
                return false;
        }
@@ -745,14 +753,14 @@ static int zephyr_get_thread_reg_list(struct rtos *rtos, int64_t thread_id,
 
        LOG_INFO("Getting thread %" PRId64 " reg list", thread_id);
 
-       if (rtos == NULL)
+       if (!rtos)
                return ERROR_FAIL;
 
        if (thread_id == 0)
                return ERROR_FAIL;
 
        params = rtos->rtos_specific_params;
-       if (params == NULL)
+       if (!params)
                return ERROR_FAIL;
 
        addr = thread_id + params->offsets[OFFSET_T_STACK_POINTER]

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)