Code Review / openocd.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
Change return value on error.
[openocd.git] / src / flash / nor / stm32f1x.c
diff --git a/src/flash/nor/stm32f1x.c b/src/flash/nor/stm32f1x.c
index a0520c79278b3ee497bf42c36ca0d2302cc4fedb..5d9da90351c16e024a62c91d0601e469f9d82374 100644 (file)
--- a/src/flash/nor/stm32f1x.c
+++ b/src/flash/nor/stm32f1x.c
@@ -130,8 +130,7 @@ FLASH_BANK_COMMAND_HANDLER(stm32x_flash_bank_command)
 
        if (CMD_ARGC < 6)
        {
-               LOG_WARNING("incomplete flash_bank stm32x configuration");
-               return ERROR_FLASH_BANK_INVALID;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        stm32x_info = malloc(sizeof(struct stm32x_flash_bank));
@@ -955,7 +954,7 @@ static int stm32x_probe(struct flash_bank *bank)
        struct target *target = bank->target;
        struct stm32x_flash_bank *stm32x_info = bank->driver_priv;
        int i;
-       uint16_t num_pages;
+       uint16_t flash_size_in_kb;
        uint32_t device_id;
        int page_size;
        uint32_t base_address = 0x08000000;
@@ -970,12 +969,12 @@ static int stm32x_probe(struct flash_bank *bank)
        LOG_INFO("device id = 0x%08" PRIx32 "", device_id);
 
        /* get flash size from target. */
-       retval = target_read_u16(target, 0x1FFFF7E0, &num_pages);
+       retval = target_read_u16(target, 0x1FFFF7E0, &flash_size_in_kb);
        if (retval != ERROR_OK)
        {
                LOG_WARNING("failed reading flash size, default to max target family");
                /* failed reading flash size, default to max target family */
-               num_pages = 0xffff;
+               flash_size_in_kb = 0xffff;
        }
 
        if ((device_id & 0x7ff) == 0x410)
@@ -986,11 +985,11 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->ppage_size = 4;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors incorrect on revA */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 128k flash");
-                       num_pages = 128;
+                       flash_size_in_kb = 128;
                }
        }
        else if ((device_id & 0x7ff) == 0x412)
@@ -1001,11 +1000,11 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->ppage_size = 4;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors incorrect on revA */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 32k flash");
-                       num_pages = 32;
+                       flash_size_in_kb = 32;
                }
        }
        else if ((device_id & 0x7ff) == 0x414)
@@ -1016,11 +1015,11 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->ppage_size = 2;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors incorrect on revZ */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 512k flash");
-                       num_pages = 512;
+                       flash_size_in_kb = 512;
                }
        }
        else if ((device_id & 0x7ff) == 0x418)
@@ -1031,11 +1030,11 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->ppage_size = 2;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors incorrect on revZ */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 256k flash");
-                       num_pages = 256;
+                       flash_size_in_kb = 256;
                }
        }
        else if ((device_id & 0x7ff) == 0x420)
@@ -1046,26 +1045,26 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->ppage_size = 4;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors may be incorrrect on early silicon */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 128k flash");
-                       num_pages = 128;
+                       flash_size_in_kb = 128;
                }
        }
        else if ((device_id & 0x7ff) == 0x428)
        {
-               /* value line density - we have 1k pages
+               /* value line High density - we have 2k pages
                 * 4 pages for a protection area */
                page_size = 2048;
                stm32x_info->ppage_size = 4;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors may be incorrrect on early silicon */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 128k flash");
-                       num_pages = 128;
+                       flash_size_in_kb = 128;
                }
        }
 
@@ -1078,22 +1077,22 @@ static int stm32x_probe(struct flash_bank *bank)
                stm32x_info->has_dual_banks = true;
 
                /* check for early silicon */
-               if (num_pages == 0xffff)
+               if (flash_size_in_kb == 0xffff)
                {
                        /* number of sectors may be incorrrect on early silicon */
                        LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 1024k flash");
-                       num_pages = 1024;
+                       flash_size_in_kb = 1024;
                }
 
                /* split reported size into matching bank */
                if (bank->base != 0x08080000)
                {
                        /* bank 0 will be fixed 512k */
-                       num_pages = 512;
+                       flash_size_in_kb = 512;
                }
                else
                {
-                       num_pages -= 512;
+                       flash_size_in_kb -= 512;
                        /* bank1 also uses a register offset */
                        stm32x_info->register_base = FLASH_REG_BASE_B1;
                        base_address = 0x08080000;
@@ -1105,10 +1104,16 @@ static int stm32x_probe(struct flash_bank *bank)
                return ERROR_FAIL;
        }
 
-       LOG_INFO("flash size = %dkbytes", num_pages);
+       LOG_INFO("flash size = %dkbytes", flash_size_in_kb);
+
+       /* did we assign flash size? */
+       assert(flash_size_in_kb != 0xffff);
 
        /* calculate numbers of pages */
-       num_pages /= (page_size / 1024);
+       int num_pages = flash_size_in_kb * 1024 / page_size;
+
+       /* check that calculation result makes sense */
+       assert(num_pages > 0);
 
        if (bank->sectors)
        {
@@ -1323,8 +1328,7 @@ COMMAND_HANDLER(stm32x_handle_lock_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "stm32x lock <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -1372,8 +1376,7 @@ COMMAND_HANDLER(stm32x_handle_unlock_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "stm32x unlock <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -1420,8 +1423,7 @@ COMMAND_HANDLER(stm32x_handle_options_read_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "stm32x options_read <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -1490,9 +1492,7 @@ COMMAND_HANDLER(stm32x_handle_options_write_command)
 
        if (CMD_ARGC < 4)
        {
-               command_print(CMD_CTX, "stm32x options_write <bank> <SWWDG | HWWDG> "
-                               "<RSTSTNDBY | NORSTSTNDBY> <RSTSTOP | NORSTSTOP> <BOOT0 | BOOT1>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -1625,8 +1625,7 @@ COMMAND_HANDLER(stm32x_handle_mass_erase_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "stm32x mass_erase <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)