From fc348bc08648f492c6e5d63d47c0f7a1e6e0b3b2 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Sun, 20 Jan 2019 00:52:07 +0100 Subject: [PATCH] command: initialize the command mode for every command All the commands in OpenOCD have been inspected and have the command mode initialize, apart for two of them. This is not critical, because the uninitialized value (0) is equivalent to the enum COMMAND_EXEC, that is also the correct value for the two mentioned commands. To keep the code consistent, initialize the command mode to COMMAND_EXEC. Change-Id: Iaf043364cbd1005418d787ed045a3ec653612382 Signed-off-by: Antonio Borneo Reviewed-on: http://openocd.zylin.com/4861 Tested-by: jenkins Reviewed-by: Tomas Vanek --- src/flash/nand/mxc.c | 1 + src/target/armv4_5.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/flash/nand/mxc.c b/src/flash/nand/mxc.c index 5e59b9a6ca..6be416057b 100644 --- a/src/flash/nand/mxc.c +++ b/src/flash/nand/mxc.c @@ -179,6 +179,7 @@ COMMAND_HANDLER(handle_mxc_biswap_command) static const struct command_registration mxc_sub_command_handlers[] = { { .name = "biswap", + .mode = COMMAND_EXEC, .handler = handle_mxc_biswap_command, .help = "Turns on/off bad block information swaping from main area, " "without parameter query status.", diff --git a/src/target/armv4_5.c b/src/target/armv4_5.c index af8fd9a7f2..b3bee8d887 100644 --- a/src/target/armv4_5.c +++ b/src/target/armv4_5.c @@ -1134,6 +1134,7 @@ static const struct command_registration arm_exec_command_handlers[] = { }, { .name = "mrc", + .mode = COMMAND_EXEC, .jim_handler = &jim_mcrmrc, .help = "read coprocessor register", .usage = "cpnum op1 CRn CRm op2", -- 2.30.2