From ebe431879d26ca5c85021c80e18af7f91f09fa38 Mon Sep 17 00:00:00 2001 From: Spencer Oliver Date: Tue, 5 Oct 2010 15:00:40 +0100 Subject: [PATCH] gdbderver: fix gdb pipe startup overflow When usng gdb pipes we need to keep openocd output at a minimum, otherwise the gdb stdin will overflow and fail. Make the calls to gdb_port and log_output synchronous to stop this. Signed-off-by: Spencer Oliver --- src/helper/options.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/helper/options.c b/src/helper/options.c index df4676d2e3..f8db2cda26 100644 --- a/src/helper/options.c +++ b/src/helper/options.c @@ -104,13 +104,13 @@ static void add_default_dirs(void) const char *home = getenv("HOME"); - if (home) + if (home) { char *path; path = alloc_printf("%s/.openocd", home); - if (path) + if (path) { add_script_search_dir(path); free(path); @@ -178,8 +178,10 @@ int parse_cmdline_args(struct command_context *cmd_ctx, int argc, char *argv[]) } break; case 'p': + /* to replicate the old syntax this needs to be synchronous + * otherwise the gdb stdin will overflow with the warning message */ + command_run_line(cmd_ctx, "gdb_port pipe; log_output openocd.log"); LOG_WARNING("deprecated option: -p/--pipe. Use '-c \"gdb_port pipe; log_output openocd.log\"' instead."); - add_config_command("gdb_port pipe; log_output openocd.log"); break; } } -- 2.30.2