From d86211b1da4a9ab1f7412de959907d5d73a9188e Mon Sep 17 00:00:00 2001 From: Hsiangkai Wang Date: Wed, 28 Aug 2013 10:59:29 +0800 Subject: [PATCH] target: Remove error messages as no .get_gdb_fileio_info If target does not support semi-hosting function, it has no need to provide .get_gdb_fileio_info callback. OpenOCD will use default function target_get_gdb_fileio_info_default. The default function just return ERROR_FAIL and gdb_server will treat every halted condition as normal halted and return "Txx" to gdb. Change-Id: I9ddb2be3a1145eae2ef5b712bdea89eb2e0fbc20 Signed-off-by: Hsiangkai Wang Reviewed-on: http://openocd.zylin.com/1586 Tested-by: jenkins Reviewed-by: Nemui Trinomius Reviewed-by: Spencer Oliver --- src/target/target.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/target/target.c b/src/target/target.c index e4235ed26a..29a011cea1 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -1734,14 +1734,16 @@ int target_arch_state(struct target *target) static int target_get_gdb_fileio_info_default(struct target *target, struct gdb_fileio_info *fileio_info) { - LOG_ERROR("Not implemented: %s", __func__); + /* If target does not support semi-hosting function, target + has no need to provide .get_gdb_fileio_info callback. + It just return ERROR_FAIL and gdb_server will return "Txx" + as target halted every time. */ return ERROR_FAIL; } static int target_gdb_fileio_end_default(struct target *target, int retcode, int fileio_errno, bool ctrl_c) { - LOG_ERROR("Not implemented: %s", __func__); return ERROR_OK; } -- 2.30.2