From d0eb66f729ff50ffa21a3ea22bcff46167fe627a Mon Sep 17 00:00:00 2001 From: Tomas Vanek Date: Tue, 8 Jan 2019 00:26:39 +0100 Subject: [PATCH] command: Log the failed command by full name Commit 44009186cfabe77fb260af221ebd6272d1e78f44 added logging of failed cmd name but it used c->name only. It might be confusing: Debug: 244 105 command.c:644 run_command(): Command 'init' failed with error code -4 User : 245 106 command.c:711 command_run_line(): Debug: 246 107 command.c:644 run_command(): Command 'init' failed with error code -4 The command on line 244 is 'dap init' Use full name of cmd including parents. Change-Id: Iff131ce6454ef70b353ce1bc6d0a480b92820545 Signed-off-by: Tomas Vanek Reviewed-on: http://openocd.zylin.com/4837 Reviewed-by: Antonio Borneo Tested-by: jenkins Reviewed-by: Jean-Christian de Rivaz --- src/helper/command.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/helper/command.c b/src/helper/command.c index 48d998f663..1ff4e01a7d 100644 --- a/src/helper/command.c +++ b/src/helper/command.c @@ -642,7 +642,10 @@ static int run_command(struct command_context *context, /* we do not print out an error message because the command *should* * have printed out an error */ - LOG_DEBUG("Command '%s' failed with error code %d", c->name, retval); + char *full_name = command_name(c, ' '); + LOG_DEBUG("Command '%s' failed with error code %d", + full_name ? full_name : c->name, retval); + free(full_name); } return retval; -- 2.30.2