From 4ce4aa752b638d8eb39864d1ad498bde139f5233 Mon Sep 17 00:00:00 2001 From: Tarek BOCHKATI Date: Fri, 13 Mar 2020 11:49:25 +0100 Subject: [PATCH] armv8: log the register name which we failed to read or write when openocd fails to read armv8 register, the user is not informed which register has caused the error. for example, in AArch32 state ESR_EL3 read/write is not supported, thus armv8_dpm_read_current_registers is always failing without mentioning which register has caused the error. Change-Id: I24c5abbda9fac24fb77a01777ed15261aeaaf800 Signed-off-by: Tarek BOCHKATI Reviewed-on: http://openocd.zylin.com/5516 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/target/armv8_dpm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/target/armv8_dpm.c b/src/target/armv8_dpm.c index 081eed21ba..5be52726c3 100644 --- a/src/target/armv8_dpm.c +++ b/src/target/armv8_dpm.c @@ -681,6 +681,10 @@ static int dpmv8_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum) LOG_DEBUG("READ: %s, hvalue=%16.8llx", r->name, (unsigned long long) hvalue); } } + + if (retval != ERROR_OK) + LOG_ERROR("Failed to read %s register", r->name); + return retval; } @@ -720,6 +724,9 @@ static int dpmv8_write_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum) } } + if (retval != ERROR_OK) + LOG_ERROR("Failed to write %s register", r->name); + return retval; } -- 2.30.2