openocd.git
9 years agoopenocd.c: review scope of symbols
Antonio Borneo [Sun, 20 Jun 2010 09:40:28 +0000 (17:40 +0800)]
openocd.c: review scope of symbols

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agonor/virtual: review scope of symbols
Antonio Borneo [Sun, 20 Jun 2010 09:38:19 +0000 (17:38 +0800)]
nor/virtual: review scope of symbols

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agotarget/avrt: review unused symbols
Antonio Borneo [Sun, 20 Jun 2010 05:05:56 +0000 (13:05 +0800)]
target/avrt: review unused symbols

Remove unused functions:
- mcu_write_dr_u16
- mcu_write_dr_u8
- mcu_write_ir_u16
- mcu_write_ir_u32

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agotarget/avr: review scope of symbols
Antonio Borneo [Sun, 20 Jun 2010 04:52:07 +0000 (12:52 +0800)]
target/avr: review scope of symbols

Add "static" qualifier to private functions.
Move duplicated global declarations from "target/avrt.c"
and "nor/avrf.c" to "target/avrt.h".
Remove unused declarations form "nor/avrf.c".

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agotarget/feroceon: review scope of symbols
Antonio Borneo [Sun, 20 Jun 2010 04:20:01 +0000 (12:20 +0800)]
target/feroceon: review scope of symbols

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agotarget/mips_m4k: review scope of symbols
Antonio Borneo [Sat, 19 Jun 2010 16:22:12 +0000 (00:22 +0800)]
target/mips_m4k: review scope of symbols

Add "static" qualifier to private functions.
Remove private prototypes from include file.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agohelper/jim-eventloop.h: review unused definitions
Antonio Borneo [Sat, 19 Jun 2010 15:46:46 +0000 (23:46 +0800)]
helper/jim-eventloop.h: review unused definitions

Remove unused typedef and define

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agohelper/jim-eventloop: review unused symbols
Antonio Borneo [Sat, 19 Jun 2010 15:37:33 +0000 (23:37 +0800)]
helper/jim-eventloop: review unused symbols

Remove unused functions:
- Jim_CreateSignalHandler
- Jim_DeleteSignalHandler

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agohelper/jim-eventloop: review scope of symbols
Antonio Borneo [Sat, 19 Jun 2010 15:34:05 +0000 (23:34 +0800)]
helper/jim-eventloop: review scope of symbols

Add "static" qualifier to private functions.
Remove private prototypes from include file.
Remove empty definition of JIM_STATIC.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agojtag: retire jtag_get_error()
Øyvind Harboe [Mon, 21 Jun 2010 11:32:16 +0000 (13:32 +0200)]
jtag: retire jtag_get_error()

This fn is an implementation detail of jtag_execute_queue()
that is not to be exposed externally.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojtag: do not use jtag_get_error()
Øyvind Harboe [Mon, 21 Jun 2010 11:25:06 +0000 (13:25 +0200)]
jtag: do not use jtag_get_error()

normal code should not call jtag_get_error(), but rather check
the return code from jtag_execute_queue().

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoadi_v5_jtag: add missing error handling
Øyvind Harboe [Mon, 21 Jun 2010 07:02:53 +0000 (09:02 +0200)]
adi_v5_jtag: add missing error handling

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocortex a8: add missing error handling
Øyvind Harboe [Mon, 21 Jun 2010 07:02:02 +0000 (09:02 +0200)]
cortex a8: add missing error handling

cortex examine was missing error handling.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm-jtag-ew: -Wshadow fix
Andreas Fritiofson [Sat, 19 Jun 2010 09:12:12 +0000 (11:12 +0200)]
arm-jtag-ew: -Wshadow fix

declaration of ‘index’ shadows a global declaration
in /usr/include/string.h

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
9 years agocortex a8: fix segfault for unexamined targets
Øyvind Harboe [Fri, 18 Jun 2010 13:35:52 +0000 (15:35 +0200)]
cortex a8: fix segfault for unexamined targets

print error message instead of segfaulting for
unexamined targets.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agotarget/dsp563xx: review unused symbols
Antonio Borneo [Fri, 18 Jun 2010 06:30:26 +0000 (14:30 +0800)]
target/dsp563xx: review unused symbols

Remove unused functions:
- dsp563xx_jtag_senddat
- dsp563xx_write_ir_u16
- dsp563xx_write_dr_u16
- dsp563xx_write_ir_u32

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agotarget/dsp563xx: review scope of symbols
Antonio Borneo [Fri, 18 Jun 2010 06:28:01 +0000 (14:28 +0800)]
target/dsp563xx: review scope of symbols

Add "static" qualifier to private functions.
Remove private prototypes from include file.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoreverse order of Jim stack trace output
Andreas Fritiofson [Thu, 17 Jun 2010 23:33:22 +0000 (01:33 +0200)]
reverse order of Jim stack trace output

The stack traces makes much more sense this way.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
9 years agodon't add confusing source info to Jim
Andreas Fritiofson [Thu, 17 Jun 2010 22:48:47 +0000 (00:48 +0200)]
don't add confusing source info to Jim

When an interactive command fails, the Jim stack trace prints references to
the line in "command.c" where the interpreter was invoked. Since that
location has no relation to the actual command that failed, the information
serves only to add confusion.

By not adding the useless source info to Jim the noise can be reduced,
while still printing a useful trace for nested commands.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agohelper/jim: review unused symbols
Antonio Borneo [Fri, 18 Jun 2010 03:43:09 +0000 (11:43 +0800)]
helper/jim: review unused symbols

Remove unused functions:
- Jim_IdentityHashFunction
- StringAppendObj
- JimReferencesHTDoubleHashFunction

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agohelper/jim: review scope of symbols
Antonio Borneo [Fri, 18 Jun 2010 03:39:43 +0000 (11:39 +0800)]
helper/jim: review scope of symbols

Add "static" qualifier to private functions.

Function Jim_InterpolateTokens() is private, but has not
been changed to "static".
This function is called only once, so compiler inlines it.
After inline, there is a warning for variable uninitialized.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomingw32: -Wshadow fixes in arm-jtag-ew.c
Freddie Chopin [Thu, 17 Jun 2010 18:30:23 +0000 (20:30 +0200)]
mingw32: -Wshadow fixes in arm-jtag-ew.c

(error: declaration of ‘stat’ shadows a global declaration; /usr/local/lib/gcc/i686-w64-mingw32/4.4.2/../../../../i686-w64-mingw32/include/sys/stat.h:279: error: shadowed declaration is here)

Signed-off-by: Freddie Chopin <freddie_chopin@op.pl>
9 years agomingw32: -Wshadow fixes in rlink.c
Freddie Chopin [Thu, 17 Jun 2010 18:26:48 +0000 (20:26 +0200)]
mingw32: -Wshadow fixes in rlink.c

(error: declaration of ‘byte’ shadows a global declaration; /usr/local/lib/gcc/i686-w64-mingw32/4.4.2/../../../../i686-w64-mingw32/include/rpcndr.h:50: error: shadowed declaration is here)

Signed-off-by: Freddie Chopin <freddie_chopin@op.pl>
9 years agorlink: -Wshadows fixes
Freddie Chopin [Thu, 17 Jun 2010 18:24:46 +0000 (20:24 +0200)]
rlink: -Wshadows fixes

(error: declaration of ‘pHDev’ shadows a global declaration; ../../../../src/jtag/drivers/rlink.c:102: error: shadowed declaration is here)

Signed-off-by: Freddie Chopin <freddie_chopin@op.pl>
9 years agomingw32: -Wshadow fixes
Freddie Chopin [Thu, 17 Jun 2010 18:06:28 +0000 (20:06 +0200)]
mingw32: -Wshadow fixes

in jim.c (error: declaration of ‘boolean’ shadows a global declaration; /usr/local/lib/gcc/i686-w64-mingw32/4.4.2/../../../../i686-w64-mingw32/include/rpcndr.h:52: error: shadowed declaration is here)

Signed-off-by: Freddie Chopin <freddie_chopin@op.pl>
9 years agojlink: fix -Wshadow warning
Antonio Borneo [Thu, 17 Jun 2010 15:13:08 +0000 (23:13 +0800)]
jlink: fix -Wshadow warning

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agovsllink: fix -Wshadow warning
Antonio Borneo [Thu, 17 Jun 2010 15:12:48 +0000 (23:12 +0800)]
vsllink: fix -Wshadow warning

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agogdb-server: fix -Wshadow warning
Oyvind Harboe [Thu, 17 Jun 2010 13:30:25 +0000 (15:30 +0200)]
gdb-server: fix -Wshadow warning

This warning was only reproducable with
Cygwin.

Cygwin now builds without warnings for the basic
case.

Signed-off-by: Oyvind Harboe <oyvind.harboe@zylin.com>
9 years agozy1000: fix arm11 optimisation
Øyvind Harboe [Thu, 17 Jun 2010 07:04:46 +0000 (09:04 +0200)]
zy1000: fix arm11 optimisation

copy & paste error + added FIFO throttling to work around
lockup bug in FPGA.

The arm11 optimisation was introduced post v0.4.0, so this
is not a regression compared to previous release.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agohelper: remove helper membuf
Antonio Borneo [Mon, 14 Jun 2010 04:31:13 +0000 (12:31 +0800)]
helper: remove helper membuf

Helper is now unused. Can be removed.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agonor/at91sam3: replace helper membuf
Antonio Borneo [Mon, 14 Jun 2010 04:22:10 +0000 (12:22 +0800)]
nor/at91sam3: replace helper membuf

Helper ./src/helper/membuf.c is only used in at91sam3.c

1) Replace membuf with LOG_*

2) The original code in sam3_GetDetails() invalidates
   all the buffered output of sam3_GetInfo(). The new
   code skips sam3_GetInfo() if its output should not
   be printed.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agobuild: enable -Wshadow by default
Øyvind Harboe [Wed, 16 Jun 2010 06:33:32 +0000 (08:33 +0200)]
build: enable -Wshadow by default

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agogdb: -Wshadow warning fixes
Øyvind Harboe [Wed, 16 Jun 2010 06:27:50 +0000 (08:27 +0200)]
gdb: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agogdb: clean up error handling in step/continue
Øyvind Harboe [Wed, 16 Jun 2010 06:24:51 +0000 (08:24 +0200)]
gdb: clean up error handling in step/continue

if step/continue fails, then the error should be
reported to the calling fn.

The calling fn decides if the connection has to be
aborted or if packet processing can continue.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoxsvf: -Wshadow warning fixes
Øyvind Harboe [Wed, 16 Jun 2010 06:19:25 +0000 (08:19 +0200)]
xsvf: -Wshadow warning fixes

I think this fixed an error message where the error
message would show the *previous* uc code rather than
the current unsupported uc code.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agosvf: -Wshadow warning fixes
Øyvind Harboe [Wed, 16 Jun 2010 06:17:27 +0000 (08:17 +0200)]
svf: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomflash: -Wshadow warning fix
Øyvind Harboe [Wed, 16 Jun 2010 05:42:41 +0000 (07:42 +0200)]
mflash: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm_io: -Wshadow warning fix
Øyvind Harboe [Wed, 16 Jun 2010 05:41:43 +0000 (07:41 +0200)]
arm_io: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agonand: when verify failed, it didn't return an error
Øyvind Harboe [Wed, 16 Jun 2010 05:39:46 +0000 (07:39 +0200)]
nand: when verify failed, it didn't return an error

when the verify failed, it didn't return an error,
which breaks e.g. tcl scripts that rely on this for
exceptions to work.

Found by -Wshadow

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agotms470: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 22:08:58 +0000 (00:08 +0200)]
tms470: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agostr9xpec: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 22:07:59 +0000 (00:07 +0200)]
str9xpec: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agostr9x: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 22:05:58 +0000 (00:05 +0200)]
str9x: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agooops... backup file snuck in, remove it.
Øyvind Harboe [Tue, 15 Jun 2010 22:04:23 +0000 (00:04 +0200)]
oops... backup file snuck in, remove it.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agostr7x: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 22:02:58 +0000 (00:02 +0200)]
str7x: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agostm32x: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 22:00:57 +0000 (00:00 +0200)]
stm32x: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agostellaris: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:59:21 +0000 (23:59 +0200)]
stellaris: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agolpc2900: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:58:19 +0000 (23:58 +0200)]
lpc2900: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agolpc2000: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:53:36 +0000 (23:53 +0200)]
lpc2000: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoecos flash: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:32:47 +0000 (23:32 +0200)]
ecos flash: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoat91sam7: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:31:36 +0000 (23:31 +0200)]
at91sam7: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoflash: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:29:08 +0000 (23:29 +0200)]
flash: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomips_ejtag: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:27:08 +0000 (23:27 +0200)]
mips_ejtag: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomips32_pracc: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:26:16 +0000 (23:26 +0200)]
mips32_pracc: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomips_m4k: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:25:32 +0000 (23:25 +0200)]
mips_m4k: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agomips32: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:24:47 +0000 (23:24 +0200)]
mips32: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocortex_a8: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:23:16 +0000 (23:23 +0200)]
cortex_a8: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm11_dbgtap: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:22:24 +0000 (23:22 +0200)]
arm11_dbgtap: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm926ejs: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:20:00 +0000 (23:20 +0200)]
arm926ejs: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm920t: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:18:44 +0000 (23:18 +0200)]
arm920t: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm720t: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:17:00 +0000 (23:17 +0200)]
arm720t: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoadi_v5_jtag: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:15:50 +0000 (23:15 +0200)]
adi_v5_jtag: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm_adi: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:14:41 +0000 (23:14 +0200)]
arm_adi: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm_simulator: -Wshadow warning fixes
Øyvind Harboe [Tue, 15 Jun 2010 21:14:20 +0000 (23:14 +0200)]
arm_simulator: -Wshadow warning fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm_dpm: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:09:12 +0000 (23:09 +0200)]
arm_dpm: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agotarget: -Wshdaow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:07:45 +0000 (23:07 +0200)]
target: -Wshdaow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agobreakpoint: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:04:22 +0000 (23:04 +0200)]
breakpoint: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agozy1000: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:02:46 +0000 (23:02 +0200)]
zy1000: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agofileio: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 21:01:42 +0000 (23:01 +0200)]
fileio: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojim: -Wshadow warning fix
Øyvind Harboe [Tue, 15 Jun 2010 20:47:52 +0000 (22:47 +0200)]
jim: -Wshadow warning fix

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojim: more jim -Wshadow fixes that should be straightforward
Øyvind Harboe [Mon, 14 Jun 2010 20:29:41 +0000 (22:29 +0200)]
jim: more jim -Wshadow fixes that should be straightforward

this bunch was a bit less obvious, but looked
straightforward.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojim: -Wshadow fixes
Øyvind Harboe [Mon, 14 Jun 2010 20:24:22 +0000 (22:24 +0200)]
jim: -Wshadow fixes

this batch of fixes should be pretty straightforward
rename of 'index' and an 'i' local variable shadowing.

'index' conflicts with a global name.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoDM36x: pll & clock setup
Thomas Koeller [Tue, 15 Jun 2010 08:37:05 +0000 (10:37 +0200)]
DM36x: pll & clock setup

Added a function 'pll_v03_setup' to set up PLLs and clock
dividers on DM365 and DM368.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm1136 scripts
michal smulski [Mon, 14 Jun 2010 22:13:09 +0000 (15:13 -0700)]
arm1136 scripts

Here is a patch to fix a startup in C100 (arm1136). Basically make sure
that UART is configured before using it.

Michal

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years ago-Wshadow fixes
Øyvind Harboe [Mon, 14 Jun 2010 09:51:25 +0000 (11:51 +0200)]
-Wshadow fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocfi: add LOG_ERROR() in case of unsupported intel erase algorithm
Øyvind Harboe [Mon, 14 Jun 2010 13:42:39 +0000 (15:42 +0200)]
cfi: add LOG_ERROR() in case of unsupported intel erase algorithm

found by code inspection. There are many other places in
CFI where LOG_ERROR() should be called similarly...

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoflash: fix bug in error propagation of flash write_image
Øyvind Harboe [Mon, 14 Jun 2010 10:08:46 +0000 (12:08 +0200)]
flash: fix bug in error propagation of flash write_image

when a write/unlock/erase failed during write_image, then
an error was not propagated back up so e.g. flash write
image from tcl scripts would not throw an exception.

Also flash filling speed was printed even when the
operation failed. Output is now less confusing.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agohelper: fix -Wshadow warning in number parsing
Øyvind Harboe [Mon, 14 Jun 2010 10:10:35 +0000 (12:10 +0200)]
helper: fix -Wshadow warning in number parsing

use obtuse local variable names in macros to avoid
interfering with global name space

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocfi: fix gaffe introduced in previous version
Øyvind Harboe [Mon, 14 Jun 2010 07:47:33 +0000 (09:47 +0200)]
cfi: fix gaffe introduced in previous version

flash probe broke w/in last commit.

ecc8041c0f4c30a7310c0f8414a5261ee7a090ca

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agotarget: fix retval gaffe in mwX commands
Øyvind Harboe [Mon, 14 Jun 2010 07:30:37 +0000 (09:30 +0200)]
target: fix retval gaffe in mwX commands

failure to write to memory was not propagated.

This is an interesting case of broken error handling:
with exceptions we wouldn't have had this at all,
and I also wonder if there is a GCC option to warn
about these kinds of potential bugs.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoTARGET: removed unused parameters
Antonio Borneo [Sat, 12 Jun 2010 10:35:06 +0000 (18:35 +0800)]
TARGET: removed unused parameters

Parameters "domain" and "ap" of function armv4_5_mmu_translate_va()
are not used.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoTARGET: removed unsed parameter
Antonio Borneo [Sat, 12 Jun 2010 03:58:50 +0000 (11:58 +0800)]
TARGET: removed unsed parameter

Parameter "type" of function armv4_5_mmu_translate_va()
is now not used.
Remove the parameter and the "enum" listing its values.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoTARGET: fix handling return code of MMU translation
Antonio Borneo [Sat, 12 Jun 2010 03:46:56 +0000 (11:46 +0800)]
TARGET: fix handling return code of MMU translation

Function armv4_5_mmu_translate_va() now properly signals
errors in the return value.
Remove former error handling by setting variable "type" to
value "-1".

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoTARGET/ARM920T: fix return value
Antonio Borneo [Sat, 12 Jun 2010 03:07:47 +0000 (11:07 +0800)]
TARGET/ARM920T: fix return value

Function arm920t_write_memory() default return value
should be ERROR_OK.
All cases of local errors are handled immediately and
not further propagated.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoTARGET/ARM920T: fix compile warning
Antonio Borneo [Sat, 12 Jun 2010 03:01:24 +0000 (11:01 +0800)]
TARGET/ARM920T: fix compile warning

Commit 0538081246fafbfb74d554bb1b758412534aa254
introduces a compile time warning:
arm920t.c: In function ‘arm920t_write_memory’:
arm920t.c:567: warning: ‘retval’ may be used uninitialized in this function

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
9 years agoflash: add error handling to get_flash_by_addr/name
Øyvind Harboe [Fri, 11 Jun 2010 06:10:39 +0000 (08:10 +0200)]
flash: add error handling to get_flash_by_addr/name

autoprobing can fail and this error has to be
reported up the call stack.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoarm mmu: error propagation added for address translation
Øyvind Harboe [Thu, 10 Jun 2010 14:18:14 +0000 (16:18 +0200)]
arm mmu: error propagation added for address translation

The return value for MMU translation was a mess, either
error or value.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocfi: fix error propagation
Øyvind Harboe [Thu, 10 Jun 2010 13:27:35 +0000 (15:27 +0200)]
cfi: fix error propagation

any read/write operation to memory can fail.

block write algorithm error propagation was broken
in that it would continue after an error was reported
writing data to ram or the algorithm failing.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojtag: added mising header
Thomas Koeller [Thu, 10 Jun 2010 14:54:25 +0000 (16:54 +0200)]
jtag: added mising header

Distributions created by 'make dist' were incomplete due to a
missing header file.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
9 years agoflash: add error message if image is too big for flash
Øyvind Harboe [Wed, 9 Jun 2010 15:12:52 +0000 (17:12 +0200)]
flash: add error message if image is too big for flash

replaced assert() w/error message if the image is
too big.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoflash: flash erase_address takes unsigned arguments
Øyvind Harboe [Wed, 9 Jun 2010 14:01:10 +0000 (16:01 +0200)]
flash: flash erase_address takes unsigned arguments

fixed bug where address was parsed as a signed, rather
than unsigned it.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agozy1000: fix optimisation gaffe
Øyvind Harboe [Mon, 7 Jun 2010 14:14:51 +0000 (16:14 +0200)]
zy1000: fix optimisation gaffe

DCC optimisation was broken on targets w/multiple TAP's.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agozy1000: added watchdog server
Øyvind Harboe [Thu, 6 May 2010 11:37:56 +0000 (13:37 +0200)]
zy1000: added watchdog server

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agocfi: fix GDB keep alive bug
Øyvind Harboe [Wed, 5 May 2010 14:18:50 +0000 (16:18 +0200)]
cfi: fix GDB keep alive bug

Long running CFI writes could cause GDB timeout.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agoverify: display up to 128 diff's
Øyvind Harboe [Wed, 5 May 2010 17:00:21 +0000 (19:00 +0200)]
verify: display up to 128 diff's

Showing up to 128 differences.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agogdb-server: fix error reporting bugs
Øyvind Harboe [Mon, 7 Jun 2010 13:14:04 +0000 (15:14 +0200)]
gdb-server: fix error reporting bugs

GDB and OpenOCD has two different error number
spaces and no mapping exists between them.

If a specific error number is to be reported
to GDB then this has to be done at the calling
site, rather than as a generic routine that
tries to map "retval" to GDB error number speak.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
9 years agojtag: rename JTAG_MOVESTATE to JTAG_TLR_RESET
Øyvind Harboe [Sat, 5 Jun 2010 09:30:49 +0000 (11:30 +0200)]
jtag: rename JTAG_MOVESTATE to JTAG_TLR_RESET

JTAG_MOVESTATE is misleading, this cmd is only used
for reset.

JTAG_PATHMOVE should be used otherwise.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
10 years agostm32 : change returned value of mass_erase function
gcembed [Tue, 1 Jun 2010 11:48:22 +0000 (13:48 +0200)]
stm32 : change returned value of mass_erase function

Hello,
"stm32x mass_erase" return ERROR_OK even if something goes wrong.
Here is a summary of changes :
* in stm32x_mass_erase : return ERROR_FLASH_OPERATION_FAILED when error
detected in FLASH_SR register;
* in COMMAND_HANDLER(stm32x_handle_mass_erase_command) : return the
returned value of stm32x_mass_erase().

I don't know if there is reason to always return ERROR_OK ?

Gaëtan

10 years agoNEWS: updates
Spencer Oliver [Thu, 3 Jun 2010 09:20:06 +0000 (10:20 +0100)]
NEWS: updates

Add new features since 0.4.0 release.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
10 years agoetm: print something when trace buffer empty
Jon Povey [Mon, 31 May 2010 02:56:42 +0000 (11:56 +0900)]
etm: print something when trace buffer empty

ETM analyze produced no output when the trace buffer was empty.
This patch provides users with a clue.

Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
10 years agonor: fix memory leaks during probe
Spencer Oliver [Sat, 29 May 2010 14:43:42 +0000 (15:43 +0100)]
nor: fix memory leaks during probe

Fix similar memory leaks as per commit:
ef72484b785ec7462a0415afea679d08b864c7fb

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>