openocd.git
8 years agokinetis flash: use longword write when writing into pflash
Tomas Frydrych [Sun, 13 Nov 2011 17:04:53 +0000 (17:04 +0000)]
kinetis flash: use longword write when writing into pflash

Check whether the destination is in the program flash or NVM regions,
in the former case, use the normal longword mechanism, not the fast NVM
write.

Change-Id: I7366b7c8919928ee690252df83b99701776aee82
Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
Reviewed-on: http://openocd.zylin.com/194
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoAdd Tincantools Flyswatter2 support
Marek Vasut [Fri, 11 Nov 2011 22:38:36 +0000 (23:38 +0100)]
Add Tincantools Flyswatter2 support

This is a successor to the Flyswatter cable and is very close to the original.
The new revision is based on FT2232H.

Change-Id: Icc6efcf0e4f9d8a10b65df8679b4973f6b375a9f
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: David Anders <danders@tincantools.com>
Reviewed-on: http://openocd.zylin.com/193
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoat91sam7: ensure probed flash bank has a name (fix a segfault)
Aurelien Jacobs [Mon, 17 Oct 2011 12:49:18 +0000 (14:49 +0200)]
at91sam7: ensure probed flash bank has a name (fix a segfault)

Before this commit, openocd used to segfault when probing flash
of an at91sam7x512 (which contains 2 banks of flash). This was due
to the way it systematically insert a new flash bank without setting
its name.
Then, when get_flash_bank_by_name_noprobe() is called, it is doing
a strcmp() on the non-initialized bank->name.

This commit prevents allocation of second probed bank if it is already
allocated (for example, if it is set in a target config file). If a
new bank really needs to be allocated, it ensures that a default name
is set.

Change-Id: I38d15bef1fda2ec746efad37171975136cf7b371
Signed-off-by: Aurelien Jacobs <aurel@gnuage.org>
Reviewed-on: http://openocd.zylin.com/171
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agotarget: make it absolutely clear that no null pointers are accepted
Øyvind Harboe [Sat, 5 Nov 2011 12:06:35 +0000 (13:06 +0100)]
target: make it absolutely clear that no null pointers are accepted

there are no comments about what the rules w.r.t. null pointers
are and it is inconsistent.

It's simply a bug in the app if we ask about the properties of a null
pointer w.r.t. what kind of target it is. It's equally wrong to say
that it is an arm target as that it isn't an arm target.

Change-Id: I0925a6a5c8b38e594ffa7c3ca4390487b5e9b718
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/168
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
8 years agoimage: remove assignments to local variables that is never read
Øyvind Harboe [Thu, 10 Nov 2011 17:19:21 +0000 (18:19 +0100)]
image: remove assignments to local variables that is never read

Change-Id: I1a5e968f165e060fd4aa7c023ad870a9e21bb5dd
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/191
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoft2232: fix warning about assignment to local variable
Øyvind Harboe [Thu, 10 Nov 2011 18:37:00 +0000 (19:37 +0100)]
ft2232: fix warning about assignment to local variable

variable is not read afterwards.

Change-Id: I905bbb10c596190f75494e6c6ad400a3e51843f6
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/192
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agosvf: fix warnings
Øyvind Harboe [Mon, 7 Nov 2011 19:56:52 +0000 (20:56 +0100)]
svf: fix warnings

Change-Id: Ib7f67612db3a865f9acc5ae349455da7ddcd3348
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/177
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoft2232: Set PWR_RST and LOOPBACK for xds100v2
Kyle Manna [Sat, 22 Oct 2011 05:27:36 +0000 (00:27 -0500)]
ft2232: Set PWR_RST and LOOPBACK for xds100v2

The CPLD on the xds100v2 expects to see a rising edge on PWR_RST to
enable the outputs.  This patch creates that transition correctly by
fixing the direction register for PWR_RST.

THe CPLD will also loop back the data if the LOOPBACK signal is
asserted.  Set this signal to an output and keep it clear.

This was tested with a TI DM3730 Beagleboard xM.

Change-Id: I4ea216bef6ae5c40e935741af5c69dc844d5d494
Signed-off-by: Kyle Manna <kyle.manna@fuel7.com>
Reviewed-on: http://openocd.zylin.com/189
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agodocs: remove berlios related info
Spencer Oliver [Wed, 9 Nov 2011 21:34:13 +0000 (21:34 +0000)]
docs: remove berlios related info

Change-Id: I9593eb165fce51411f20fa068e324b3fd882cdb3
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/190
Tested-by: jenkins
8 years agoWork around silicon bug in the SAM3 family flash waitstates
Attila Kinali [Thu, 27 Oct 2011 10:14:55 +0000 (12:14 +0200)]
Work around silicon bug in the SAM3 family flash waitstates

* Add flash waitstate support for Atmel SAM3 chips.
* Set default waitstates to 6, to workaround a silicon bug in the SAM3 family

This code has been tested on SAM3U4, SAM3N4 and SAM3N1

based on Change-Id: I477446f9bfb3e910ea3e2414a6e9a75beb14a214
by Jim Norris <u17263@att.net>

Change-Id: I8d360080f6968979ca5e197ad638282cadd18fb7
Signed-off-by: Attila Kinali <attila@kinali.ch>
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/128
Tested-by: jenkins
8 years agocontrib: Add udev rules for TI xds100v2 debugger
Kyle Manna [Sat, 22 Oct 2011 14:29:14 +0000 (09:29 -0500)]
contrib: Add udev rules for TI xds100v2 debugger

This corrects permissions on the FTDI chip on the xds100v2 debugger
enabling normal users to access it.

Change-Id: I0f6618692ebdee6284eee28f9e612e68782c4d78
Signed-off-by: Kyle Manna <kyle.manna@fuel7.com>
Reviewed-on: http://openocd.zylin.com/188
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoat91sam7: fix warnings by removing dead assignments
Øyvind Harboe [Tue, 8 Nov 2011 16:43:32 +0000 (17:43 +0100)]
at91sam7: fix warnings by removing dead assignments

Change-Id: I836038b3518e617291ac7d5d255a388d9486f67f
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/180
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agobuspirate: add missing error propagation
Øyvind Harboe [Tue, 8 Nov 2011 16:50:01 +0000 (17:50 +0100)]
buspirate: add missing error propagation

found by clang.

Change-Id: I80ea8e6afc8dcc1aa7edb6f63af0d94f6781b81c
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/182
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agowarning fix: remove unused variable assignment
Øyvind Harboe [Tue, 8 Nov 2011 16:55:56 +0000 (17:55 +0100)]
warning fix: remove unused variable assignment

Change-Id: I8c73b0f9a6a10734e539eedcedd79e1a34122f60
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/185
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoem357: fix warning by removing unused local variables
Øyvind Harboe [Tue, 8 Nov 2011 16:54:28 +0000 (17:54 +0100)]
em357: fix warning by removing unused local variables

Change-Id: I9def63d36ed4fa8bf9cdeeedc18b1b25d0e487d6
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/184
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agousbprog: fix unecessary and confusing assignment
Øyvind Harboe [Tue, 8 Nov 2011 20:41:35 +0000 (21:41 +0100)]
usbprog: fix unecessary and confusing assignment

clang found silly code that was trivially fixed.

Change-Id: Ied6c1b254c1823cd111140cbe0c8a03d2ede65fb
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/186
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoflash: update luminary device table
Spencer Oliver [Thu, 3 Nov 2011 20:42:50 +0000 (20:42 +0000)]
flash: update luminary device table

add support for checking target against the device CLASS rather
then just the PARTNO.

This change also adds the new LM4F family (Blizzard).

Change-Id: Ia9d1e33f1f1c2817c0039a2232ecf932fae072f9
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/161
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoarm7_9: remove warnings by reducing scope of variables
Øyvind Harboe [Tue, 8 Nov 2011 06:32:04 +0000 (07:32 +0100)]
arm7_9: remove warnings by reducing scope of variables

Change-Id: Idc384b733056a72108680b073da7c327a8eeedc3
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/179
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoat91sam7: add a new target config file for at91sam7x512
Aurelien Jacobs [Mon, 17 Oct 2011 13:19:24 +0000 (15:19 +0200)]
at91sam7: add a new target config file for at91sam7x512

The main difference with at91sam7x256 is the declaration of the second
bank of flash.

Change-Id: I87a20dcbb639b797799139ccf46cc73934fa3b9e
Signed-off-by: Aurelien Jacobs <aurel@gnuage.org>
Reviewed-on: http://openocd.zylin.com/173
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agodisassembly: fix access to undefined memory pointer upon unknown instruction
Øyvind Harboe [Sat, 5 Nov 2011 12:13:50 +0000 (13:13 +0100)]
disassembly: fix access to undefined memory pointer upon unknown instruction

return error message instead. Found by clang.

Change-Id: Ica109d077206236a12d007e77cc78061ffd05834
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/169
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoxsvf: add missing error propagation
Øyvind Harboe [Mon, 7 Nov 2011 06:24:42 +0000 (07:24 +0100)]
xsvf: add missing error propagation

Change-Id: Ibc70deb980d6d18ceb376b72d9104e6180b16acf
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/176
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agodsp5680xx: fix warnings
Øyvind Harboe [Sat, 5 Nov 2011 12:16:23 +0000 (13:16 +0100)]
dsp5680xx: fix warnings

- propagate error
- remove dead assignment

Change-Id: I0d7078f531d96e421e95f08bfd908e818500d74c
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/170
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agostr9x: explain compiler that a local variable will always be initialized
Øyvind Harboe [Mon, 31 Oct 2011 21:03:49 +0000 (22:03 +0100)]
str9x: explain compiler that a local variable will always be initialized

Change-Id: I9ddb2793b4cdbf6acea6f69973531491e4ebcc5b
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/145
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoat91sam3: fix warnings
Øyvind Harboe [Thu, 3 Nov 2011 20:39:23 +0000 (21:39 +0100)]
at91sam3: fix warnings

- reduce scope of variables
- assert on post condition to fix clang warning

Change-Id: Id91038f73a632f9688ba52c9c34eae923626e770
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/160
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agostr7x: fix error propagation
Øyvind Harboe [Mon, 7 Nov 2011 20:02:48 +0000 (21:02 +0100)]
str7x: fix error propagation

stick to convention of "retval" being used as error value to
be propagated and use "flash_flags" local variable for flash
flags read from how.

Change-Id: I63f1f2248b4f4538d6cd7634ae277f7c0aadc346
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/178
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agotarget config files: Fix whitespace issues.
Uwe Hermann [Sat, 29 Oct 2011 21:32:17 +0000 (23:32 +0200)]
target config files: Fix whitespace issues.

Drop useless double-space occurences, drop trailing whitespace, and fix
some other minor whitespace-related issues.

Change-Id: I6b4c515492e2ee94dc25ef1fe4f51015a4bba8b5
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/137
Tested-by: jenkins
8 years agoecos: add missing error propagation
Øyvind Harboe [Mon, 7 Nov 2011 05:59:03 +0000 (06:59 +0100)]
ecos: add missing error propagation

Change-Id: Ib34815c9cf654517f22486a7c8001fdb7471338c
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/174
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoxscale: cleanup
Øyvind Harboe [Mon, 7 Nov 2011 06:20:26 +0000 (07:20 +0100)]
xscale: cleanup

- fix error propagation
- add some debug output for "unused" variables
- reduce scope of variable to avoid "unread" variables.

Change-Id: I136995f2a043102e64b8fff3017502fae564013b
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/175
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agowarning fix: add self-consitency check to remove warning
Øyvind Harboe [Mon, 31 Oct 2011 20:26:28 +0000 (21:26 +0100)]
warning fix: add self-consitency check to remove warning

verify promise of code that more code can be pasted with an
assert at the end condition of the code passage that builds
string.

Change-Id: I76a4e5f91b9142fff932e1493cb43c29eb6a0f80
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/143
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agocfi: fix gaffe in fixing warnings
Øyvind Harboe [Thu, 3 Nov 2011 20:43:31 +0000 (21:43 +0100)]
cfi: fix gaffe in fixing warnings

introduced reading garbage value for arm32.

Change-Id: Ib5792a8a3207ee4db6d01d354df98c3cfabce037
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/162
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agotools: fix permissions
Spencer Oliver [Fri, 4 Nov 2011 10:00:30 +0000 (10:00 +0000)]
tools: fix permissions

Change-Id: I9419138dd2972304daf215594ca917ac8eb7fcda
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agotools: add checkpatch script
Spencer Oliver [Thu, 3 Nov 2011 23:33:37 +0000 (23:33 +0000)]
tools: add checkpatch script

execute from openocd root dir after commiting change but before
pushing to gerrit.
tools/checkpatch.sh

This is the same script used by the jenkins build server to validate
a change.

Change-Id: Ib40d44b160e1c50a5e47ab55fc48a554381ea763
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/167
Tested-by: jenkins
8 years agoetm: fix warning by removing assignment that is immediately overwritten
Øyvind Harboe [Thu, 3 Nov 2011 20:49:59 +0000 (21:49 +0100)]
etm: fix warning by removing assignment that is immediately overwritten

Change-Id: Ia3a83d3c1fc3a1707d69017fce6cf142a81babc4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/165
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agocortex_m: initialize unused CPU variables to 0 for poll info output
Øyvind Harboe [Thu, 3 Nov 2011 20:45:38 +0000 (21:45 +0100)]
cortex_m: initialize unused CPU variables to 0 for poll info output

fixes warnings.

Change-Id: I1a9ec09083d4e6269889fb79e6121f25e83eb396
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/163
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agodsp5680xx: add missing and broken error propagation
Øyvind Harboe [Tue, 1 Nov 2011 22:28:10 +0000 (23:28 +0100)]
dsp5680xx: add missing and broken error propagation

found by clang.

Change-Id: Ie7e2ecad71bf0838ece93727e4778ad368b890ef
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/156
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoat91sam9: fix broken error propagation
Øyvind Harboe [Thu, 3 Nov 2011 20:34:00 +0000 (21:34 +0100)]
at91sam9: fix broken error propagation

Change-Id: I3288ce6f7642e519c26dd099be888a395fe1de94
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/159
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoavr32_regs: add missing error propagation
Øyvind Harboe [Thu, 3 Nov 2011 20:51:31 +0000 (21:51 +0100)]
avr32_regs: add missing error propagation

Change-Id: Ie8b141dd534d73eccfc045069d5f628bd1eea88e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/166
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agointerface configs: Add missing URLs and names.
Uwe Hermann [Sat, 29 Oct 2011 23:44:18 +0000 (01:44 +0200)]
interface configs: Add missing URLs and names.

Also, drop author name from interface/hilscher_* files, that info is in the
git log, and none of the other files contain author names either.

Change-Id: Idf0eb4279c4bff31d15c166619c0bf8b1c5bb877
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/138
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoHACKING: all you need is http access
Øyvind Harboe [Wed, 2 Nov 2011 09:48:44 +0000 (10:48 +0100)]
HACKING: all you need is http access

Change-Id: I191c1da5126c4c9ea1ff8826576b6b24feaf9881
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/157
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agocheckpatch: increase line length warning to 100
Spencer Oliver [Thu, 3 Nov 2011 23:09:05 +0000 (23:09 +0000)]
checkpatch: increase line length warning to 100

Change-Id: Ief0445ea6581929b3ffdcf8bc644ce5f27b392c4
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agotools: add checkpatch script
Spencer Oliver [Thu, 3 Nov 2011 19:22:19 +0000 (19:22 +0000)]
tools: add checkpatch script

Change-Id: I3579028fc1c6ee8bea58c82e5f0eecba7794d7cb
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agogdb_server: assert to avoid malloc(0)
Øyvind Harboe [Sat, 29 Oct 2011 15:37:42 +0000 (17:37 +0200)]
gdb_server: assert to avoid malloc(0)

Change-Id: I6ae3e007f4aa768f8bc64de78351750138f12e53
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/135
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agocfg: add Stellaris LM4F232 Evaluation Kit config
Spencer Oliver [Tue, 1 Nov 2011 21:13:54 +0000 (21:13 +0000)]
cfg: add Stellaris LM4F232 Evaluation Kit config

Change-Id: Ica754897bef6573a0738ed1afdfe1dfda07292fd
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/151
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
8 years agocfg: add Blizzard class to stellaris.cfg
Spencer Oliver [Tue, 1 Nov 2011 21:12:58 +0000 (21:12 +0000)]
cfg: add Blizzard class to stellaris.cfg

Change-Id: I2a1320c696b6d9b070e4a927c4cd4d68178af751
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/150
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
8 years agotx27stk5: add board init support for KaRo TX27 CPU module
Mark Vels [Tue, 1 Nov 2011 12:29:11 +0000 (13:29 +0100)]
tx27stk5: add board init support for KaRo TX27 CPU module

This patch adds support for a KaRo TX27 CPU module on a StarterkitV base board.
The register settings have been extracted from a RedBoot distribution
that is distributed along with the hardware by KaRo.

This setup has been tested with a JTAGKey. The testing has been focussed
on loading a program into memory and start execution.
Although the flash seems to be correctly detected, no effort has been put
in testing the NAND programming yet.

Change-Id: Ib17763f1e3ecacd0eb9b5fdc32f8cba7a5e59be5
Signed-off-by: Mark Vels <mark.vels@team-embedded.nl>
Reviewed-on: http://openocd.zylin.com/158
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agofix warning: remove assigned to variable
Øyvind Harboe [Tue, 1 Nov 2011 21:10:54 +0000 (22:10 +0100)]
fix warning: remove assigned to variable

variable is subsequently not used

Change-Id: I177d21c6ba9f1f2e3765feffdbf317ea375a8cfe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/149
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agocortex_a: add missing error propagation
Øyvind Harboe [Tue, 1 Nov 2011 21:56:28 +0000 (22:56 +0100)]
cortex_a: add missing error propagation

found by clang.

Change-Id: I50eac219d7540fd48d3285f3f213cb659492d0c0
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/153
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agousbtoxxx: remove warning by reducing scope of variable
Øyvind Harboe [Tue, 1 Nov 2011 21:59:17 +0000 (22:59 +0100)]
usbtoxxx: remove warning by reducing scope of variable

Change-Id: Icc3cfe601082cd83ad1c8818c1e21e7ada014150
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/154
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoarm11: print next address to debug
Øyvind Harboe [Tue, 1 Nov 2011 22:20:49 +0000 (23:20 +0100)]
arm11: print next address to debug

fixes clang warning. Basically the next address pointer is not
used for anything in the fn, except to be examined in debug.

Change-Id: I253519b8e49e54490bbe7da8ec3d2dd31f49052a
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/155
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agocortex_m: add missing error checking
Øyvind Harboe [Tue, 1 Nov 2011 21:53:54 +0000 (22:53 +0100)]
cortex_m: add missing error checking

found by clang.

Change-Id: I099c6fe6b044dba36c20221cb439bdcba5a6bb6f
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/152
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agotarget: fix null pointer exception
Øyvind Harboe [Tue, 1 Nov 2011 21:00:46 +0000 (22:00 +0100)]
target: fix null pointer exception

check if no target is selected and return error.

Change-Id: Ie8abb63c708d09572b45e88fc6766af108715077
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/148
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoflash: add Stellaris Blizzard class
Spencer Oliver [Mon, 31 Oct 2011 22:20:06 +0000 (22:20 +0000)]
flash: add Stellaris Blizzard class

Change-Id: I83f0d6edf3ab31d9fa86682f20cec77dc47ba2f6
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/146
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
8 years agotarget: rename cortex_m3.[ch] to cortex_m.[ch]
Spencer Oliver [Mon, 31 Oct 2011 22:31:15 +0000 (22:31 +0000)]
target: rename cortex_m3.[ch] to cortex_m.[ch]

This rename is in preparation for cortex_m4 support.

Change-Id: Ic08c298ec6ed2aabc2c39db67191f68b3a51f550
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/147
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agowarning fix: remove senseless assignment before bailing out of fn w/error
Øyvind Harboe [Mon, 31 Oct 2011 20:52:10 +0000 (21:52 +0100)]
warning fix: remove senseless assignment before bailing out of fn w/error

Change-Id: I822f3adce0eccb880007673d60c7eccf7d36b398
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/144
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agowarnings: null pointer check fix
Øyvind Harboe [Mon, 31 Oct 2011 20:21:35 +0000 (21:21 +0100)]
warnings: null pointer check fix

rewrite broken null pointer check code by reducing scope
of variable.

Change-Id: I8254f6849b187e5c9cd083053cdc11973c6fe339
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/142
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agocfi: unsupported code paths now report and return error
Øyvind Harboe [Fri, 28 Oct 2011 15:22:32 +0000 (17:22 +0200)]
cfi: unsupported code paths now report and return error

found by clang, would have done something undefined and mysterious
later on.

Change-Id: If7d7aca8514575d229ed0b17378bf8b1bbf347c4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/133
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agobugfixes: tinker a bit with the targets command
Øyvind Harboe [Thu, 27 Oct 2011 21:51:50 +0000 (23:51 +0200)]
bugfixes: tinker a bit with the targets command

return error when target can not be found instead of ERROR_OK,
split fn.

Change-Id: Iba5232d3862a490d0995c3bfece23685bd6856e3
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/131
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agodsp563xxx: fix missing error propagation found by clang
Øyvind Harboe [Sun, 30 Oct 2011 17:36:47 +0000 (18:36 +0100)]
dsp563xxx: fix missing error propagation found by clang

Change-Id: I7380ce145b4942e21b174f2a810928a877c32bc7
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/140
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agointerface configs: Fix whitespace and other issues.
Uwe Hermann [Sat, 29 Oct 2011 23:45:11 +0000 (01:45 +0200)]
interface configs: Fix whitespace and other issues.

Change-Id: I98825c7fb9bdee75b69b06005ed12a3f64ec4db4
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/139
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoconfig files: Drop incorrect comments.
Uwe Hermann [Sat, 29 Oct 2011 20:58:12 +0000 (22:58 +0200)]
config files: Drop incorrect comments.

There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):

 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
    # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }

However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.

Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/136
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoclang: fix warning by adding assert that shows that a variable is used
Øyvind Harboe [Sat, 29 Oct 2011 08:55:02 +0000 (10:55 +0200)]
clang: fix warning by adding assert that shows that a variable is used

Change-Id: I26e0ba9f1ae9d43c9a14c42c4225746782dc4d66
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/134
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoFixes comment typo for page size
Jonathan Dumaresq [Fri, 28 Oct 2011 15:08:19 +0000 (11:08 -0400)]
Fixes comment typo for page size

Change-Id: I6dd8aadcecd680c48e696aeec0daf74d2addbb05
Signed-off-by: Jonathan Dumaresq <jdumaresq@cimeq.qc.ca>
Reviewed-on: http://openocd.zylin.com/132
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agobugfixes: numerous bugs in error propagation found by clang
Øyvind Harboe [Thu, 27 Oct 2011 21:51:50 +0000 (23:51 +0200)]
bugfixes: numerous bugs in error propagation found by clang

Change-Id: I784068325b422d1918e28c08544bc5a1332d712f
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/130
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoclang: fix warning about missing check for return value
Øyvind Harboe [Thu, 27 Oct 2011 17:27:04 +0000 (19:27 +0200)]
clang: fix warning about missing check for return value

Change-Id: I0c6b6b8d1f0c30b6a503cb98df30584252bc0ee1
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/129
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoRemove use of undefined variable.
Jim Norris [Thu, 27 Oct 2011 00:30:20 +0000 (19:30 -0500)]
Remove use of undefined variable.

Change-Id: Id8fd345438c360b2a42857525f05360ce2794d21
Signed-off-by: Jim Norris <u17263@att.net>
Reviewed-on: http://openocd.zylin.com/127
Reviewed-by: Peter Stuge <peter@stuge.se>
Tested-by: jenkins
8 years agoclang: fix warning about use of unitialized variable
Øyvind Harboe [Wed, 26 Oct 2011 20:26:44 +0000 (22:26 +0200)]
clang: fix warning about use of unitialized variable

this was a false positive, silence it.

Change-Id: I432e0c466c94cf8fd6bbf0ea153c8501a8a261eb
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/126
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoAdd configuration for ATMEL SAM3N-EK board.
Jim Norris [Wed, 26 Oct 2011 01:49:12 +0000 (20:49 -0500)]
Add configuration for ATMEL SAM3N-EK board.

Change-Id: I525f6c346cace4e54f47659c5a7aceb29ee4baf2
Signed-off-by: Jim Norris <u17263@att.net>
Reviewed-on: http://openocd.zylin.com/125
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoAdd configuration for ATMEL SAM3N series.
Jim Norris [Wed, 26 Oct 2011 01:48:35 +0000 (20:48 -0500)]
Add configuration for ATMEL SAM3N series.

Change-Id: Iac498ab37e59127b989f29a1c4167ab29d625b05
Signed-off-by: Jim Norris <u17263@att.net>
Reviewed-on: http://openocd.zylin.com/124
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agostm3220g_eval.cfg: fix CHIPNAME.
Marti Bolivar [Tue, 25 Oct 2011 19:52:10 +0000 (15:52 -0400)]
stm3220g_eval.cfg: fix CHIPNAME.

The STM3220G-EVAL board has an STM32F207IGH6. ("...H6", not "...T6").

Change-Id: Iaf3dae6830c5c0685a1dcd1588d391434bc51be7
Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>
Reviewed-on: http://openocd.zylin.com/120
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoarmv7a: fix scan-build warnings
Andreas Fritiofson [Mon, 24 Oct 2011 22:47:21 +0000 (00:47 +0200)]
armv7a: fix scan-build warnings

"Value stored to 'retval' is never read": Check and propagate error
"Dereference of null pointer": Probably bogus, maybe triggered by the null
check on armv7a, so remove the check since it can't be null anyway.

Change-Id: I3bc44e52af1589ff40e6a42deda0ce7f3a25e397
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/119
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoarmv7a: make local functions static
Andreas Fritiofson [Mon, 24 Oct 2011 22:36:24 +0000 (00:36 +0200)]
armv7a: make local functions static

Also fix a spelling error and remove the declaration for a non-existent
function from the header.

Change-Id: I13177e2d81aa167c05c1cc766f06924211e6d735
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/118
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoarmv7m: improve error handling
Andreas Fritiofson [Mon, 24 Oct 2011 22:03:42 +0000 (00:03 +0200)]
armv7m: improve error handling

Propagate errors unchanged.
Free allocated working area in the error return path.
Remove duplicated cleanup code by rewriting the logic.
As a side-effect, fixes a scan-build warning.

Change-Id: I80e3c0015be672778f916e998c8c2e4f23d7588c
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/117
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoFix "Evaluate 'script' in the global scope"
Freddie Chopin [Sat, 22 Oct 2011 07:53:55 +0000 (09:53 +0200)]
Fix "Evaluate 'script' in the global scope"

This fixes commit Evaluate 'script' in the global scope. It caused
Windows builds behave differently than before because path was evaluated twice
and backslashes from Windows' paths got unescaped and effectively wiped out.
Configs could only be passed with "-f ../dir/config.cfg" or "-f
..\\dir\\config.cfg" instead of usual "-f dir/config.cfg" (or using backslash)
as previously.

Change-Id: I13b4abac6dbe6d770cc11a4e61c9421ef340da83
Author: Steve Bennett <steveb@workware.net.au>
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/40
Tested-by: jenkins
Reviewed-by: Xiaofan <xiaofanc@gmail.com>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agowarning: silence gcc by initializing local variables
Øyvind Harboe [Mon, 24 Oct 2011 16:11:43 +0000 (18:11 +0200)]
warning: silence gcc by initializing local variables

GCC doesn't understand that these are in fact initialized if they are
used.

Change-Id: I01988adb0547f785b48d869ddbe44cc17dca4739
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/116
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoSERVER: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:16:26 +0000 (12:16 +0800)]
SERVER: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I0b9d0b419d9c8b7a8c755e048d5faf72d1658ba2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/87
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agocfg: Add interface config for Dangerous Prototypes BusBlaster
Richard Barlow [Sun, 23 Oct 2011 11:50:34 +0000 (12:50 +0100)]
cfg: Add interface config for Dangerous Prototypes BusBlaster

The BusBlaster from Dangerous Prototypes is based on the FTDI FT2232H IC.
It has a CPLD between the FT2232H and the JTAG header allowing it to
emulate various debugger types. It comes configured as a JTAGkey compatible
device.

Change-Id: Iab56907bf67ded87001e628d93012f1e16287d90
Signed-off-by: Richard Barlow <richard@richardbarlow.co.uk>
Reviewed-on: http://openocd.zylin.com/53
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoNOR/CORE: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:12:57 +0000 (12:12 +0800)]
NOR/CORE: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I10338a249bcfeff87d8596f7e17f209e26b41678
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/86
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoNAND/CORE: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:02:57 +0000 (12:02 +0800)]
NAND/CORE: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I42a371d6adfdf3b3fb867705211c47d89776ee2a
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/85
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoFLASH/CFI: fix clang warnings
Antonio Borneo [Sun, 23 Oct 2011 03:21:44 +0000 (11:21 +0800)]
FLASH/CFI: fix clang warnings

Total of 5 warnings:
3x "Dead store": removed dead assignment to variable;
1x "Dereference of null pointer": this is not an error, but a
   limited visibility of clang, since pointer erase_region_info
   is initialized inside cfi_fixup_non_cfi();
1x "Branch condition evaluates to a garbage value":
   this is a real coding bug that could issue SIGSEGV, since
   "goto cleanup" can be executed before initialization
   of "source".

Change-Id: Id3c323c82bb15cbd3bb8fc04b23541f11145f109
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/84
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agomx2: add error propagation and remove warnings
Øyvind Harboe [Fri, 21 Oct 2011 23:11:58 +0000 (01:11 +0200)]
mx2: add error propagation and remove warnings

Change-Id: Idd4fb452790e5d7921a749679dbd865586e5a4a9
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/48
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agofm3: fix warning for superfluous assignment
Øyvind Harboe [Fri, 21 Oct 2011 23:08:16 +0000 (01:08 +0200)]
fm3: fix warning for superfluous assignment

Change-Id: I4f8e8c2e676a2728ddc6227daf9ca6a7ceb3d505
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/46
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agokinetis: fix warning about malloc(0) w/assert
Øyvind Harboe [Fri, 21 Oct 2011 23:09:32 +0000 (01:09 +0200)]
kinetis: fix warning about malloc(0) w/assert

Change-Id: Ib40204675bfc5429c744f9ed7e2f7098384b753d
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/47
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agotms470: remove dead assignment warning
Øyvind Harboe [Fri, 21 Oct 2011 23:06:26 +0000 (01:06 +0200)]
tms470: remove dead assignment warning

Change-Id: I21e7ac47f80d93c9c0d7b169f8848b929c664b20
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/45
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoadd Freescale Kinetis K40 devices and Kwikstik eval board
Mathias K [Sat, 22 Oct 2011 16:00:20 +0000 (18:00 +0200)]
add Freescale Kinetis K40 devices and Kwikstik eval board

Change-Id: I4817921d09ab915c50f42651bc073690033450fe
Signed-off-by: Mathias K <kesmtp@freenet.de>
Reviewed-on: http://openocd.zylin.com/51
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoclang: fix warning w/assert so that clang knows that there will be no division by...
Øyvind Harboe [Fri, 21 Oct 2011 17:14:57 +0000 (19:14 +0200)]
clang: fix warning w/assert so that clang knows that there will be no division by zero

Change-Id: I98ac62a22f21043bb535a667a4f1f1537ccde2a4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/42
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoclang: fix malloc() warning with assert
Øyvind Harboe [Fri, 21 Oct 2011 17:00:09 +0000 (19:00 +0200)]
clang: fix malloc() warning with assert

Change-Id: I989d2655622a9f11f4a0a2994014e42822587ecd
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/41
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agotms470: removed unnecessary operations
Edgar Grimberg [Sun, 23 Oct 2011 09:39:50 +0000 (11:39 +0200)]
tms470: removed unnecessary operations

This should silence a warning.

Change-Id: Id91a9ebacae836083b1db2654a8e7bf24b2300e9
Signed-off-by: Edgar Grimberg <edgar.grimberg@gmail.com>
Reviewed-on: http://openocd.zylin.com/52
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoFLASH/STMSMI: fix clang "dead store" warning
Antonio Borneo [Sat, 22 Oct 2011 11:23:10 +0000 (19:23 +0800)]
FLASH/STMSMI: fix clang "dead store" warning

Change-Id: Icfdefdc48432db2057d3fea19dc424571d2385eb
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/50
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agobuspirate: ignore return value and fix warning
Øyvind Harboe [Fri, 21 Oct 2011 22:40:51 +0000 (00:40 +0200)]
buspirate: ignore return value and fix warning

Perhaps we could do one better and propagate the error?

Change-Id: Idc45f516c26f09de4ee01fe05e8d3475f4b80db3
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/43
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agowarning: fix false positive
Øyvind Harboe [Sat, 22 Oct 2011 06:25:00 +0000 (08:25 +0200)]
warning: fix false positive

may be used uninitialized in this function [-Werror=uninitialized]

Change-Id: Ida2cf8efe4e7da6fd9f669b806a20894563ac3d4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/49
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoserver: remove warning due to dead assignment
Øyvind Harboe [Fri, 21 Oct 2011 23:04:27 +0000 (01:04 +0200)]
server: remove warning due to dead assignment

Change-Id: Idb08aef0c11b3fae92286e8fcea61ab09ab09e74
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/44
Reviewed-by: Peter Stuge <peter@stuge.se>
Tested-by: jenkins
8 years agojim: add missing jim license
Spencer Oliver [Fri, 21 Oct 2011 08:51:21 +0000 (09:51 +0100)]
jim: add missing jim license

Change-Id: Ib8e34739d92cd54655b9b47d07b856a82ff25f3c
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/39
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agortos: remove broken code for handling the deprecated qP packet
Andreas Fritiofson [Wed, 19 Oct 2011 22:21:33 +0000 (00:21 +0200)]
rtos: remove broken code for handling the deprecated qP packet

Change-Id: Icca522c1e2a2877abb20665b171c61079b1d8f48
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/37
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agortos: return the correct value if the T or H packets are handled
Andreas Fritiofson [Wed, 19 Oct 2011 22:25:08 +0000 (00:25 +0200)]
rtos: return the correct value if the T or H packets are handled

Change-Id: Iea31e20ee4e35c1a9cb7b93424c92b3f38081067
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/38
Tested-by: jenkins
Reviewed-by: Evan Hunter <evan@ozhiker.com>
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoUnused variables
Freddie Chopin [Wed, 19 Oct 2011 19:40:48 +0000 (21:40 +0200)]
Unused variables

Fix a few errors with set and unused variables detected by GCC 4.7.0

Change-Id: I59b748e18e514ee9f0cde7883b4ed5116198bd4a
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/36
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoUpdated fm3.c, added Flash type 2 support, error handling improved
Marc Willam / Holger Wech [Thu, 13 Oct 2011 13:43:06 +0000 (14:43 +0100)]
Updated fm3.c, added Flash type 2 support, error handling improved

Change-Id: I684aca11c4554290d0e57c6d3318d8082980c1ef
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
Reviewed-on: http://openocd.zylin.com/10
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
8 years agoTMPA900/910 MCUs are always little endian.
Uwe Hermann [Tue, 18 Oct 2011 23:54:25 +0000 (01:54 +0200)]
TMPA900/910 MCUs are always little endian.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Change-Id: I8839f2cf0faf1b5ba9f99901c5ee028b199fabd2
Reviewed-on: http://openocd.zylin.com/35
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoToshiba TMPA900 config: Fix incorrect working area.
Uwe Hermann [Tue, 18 Oct 2011 23:09:44 +0000 (01:09 +0200)]
Toshiba TMPA900 config: Fix incorrect working area.

The Toshiba TMPA900 series (TMPA900/901) only has internal RAM regions
RAM-0 (16kB) and RAM-1 (8kB) which we can use as working area.

This is probably a copy-paste error from tmpa910.cfg, which has the
correct values and sizes for the TMPA910 series (TMPA910/911/912/913):
there are RAM-0, RAM-1, and RAM-2 (each 16kB).

Also, change "built-in RAM" to "internal RAM" to match what the
datasheet uses.

Change-Id: I993cd6b7fadc28cf34e5cc18426bb2bb42597670
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/34
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
8 years agoxscale: fix bug in xscale_receive()
Matt Reimer [Mon, 19 Sep 2011 14:30:13 +0000 (10:30 -0400)]
xscale: fix bug in xscale_receive()

The code in xscale_receive() that tries to skip invalid reads (i.e.
reads that don't have the DBG_SR[0] 'valid' bit set) seems to be
wrong, as it only looks at the first word's valid flag rather than
each word's own valid flag. Am I reading the code correctly? If so,
the attached patch should fix it.

If this looks correct, I'll generate a proper patch and commit message.

Matt

Change-Id: I74ebe2ad7a36d340a9dd3b8487578b6ea7f3cf1e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/32
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
8 years agoluminary: add new targets
Spencer Oliver [Mon, 17 Oct 2011 21:27:49 +0000 (22:27 +0100)]
luminary: add new targets

update target support from latest SW-DRL 8049

Change-Id: I40aba4d30fe2b79fd955f466c64d99a1dfd63ecf
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/31
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>