openocd.git
11 years agoAdd a rule to rebuild libtool if ltmain.sh changes (from libtool docs).
zwelch [Tue, 9 Jun 2009 12:01:56 +0000 (12:01 +0000)]
Add a rule to rebuild libtool if ltmain.sh changes (from libtool docs).

git-svn-id: svn://svn.berlios.de/openocd/trunk@2174 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoreset to eol native for now. guess-rev.sh was broken by eol native, but it was a...
oharboe [Tue, 9 Jun 2009 11:05:45 +0000 (11:05 +0000)]
reset to eol native for now. guess-rev.sh was broken by eol native, but it was a red herring that these two files were affected.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2173 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFix make maintainer-clean for out-of-tree builds.
zwelch [Tue, 9 Jun 2009 10:28:16 +0000 (10:28 +0000)]
Fix make maintainer-clean for out-of-tree builds.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2172 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoEncapsulate the core jtag interface pointer:
zwelch [Tue, 9 Jun 2009 10:07:07 +0000 (10:07 +0000)]
Encapsulate the core jtag interface pointer:
- Add new jtag_config_khz to increase encapsulation of jtag->khz call.
- Add new jtag_get_speed_readable to encapsulate of jtag->speed_div call.
- Make definition of jtag static in core.c, remove extern from tcl.c.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2171 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agodos2unix
oharboe [Tue, 9 Jun 2009 08:59:54 +0000 (08:59 +0000)]
dos2unix

git-svn-id: svn://svn.berlios.de/openocd/trunk@2170 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoContinue encapsulation of JTAG event callback sub-API:
zwelch [Tue, 9 Jun 2009 08:41:36 +0000 (08:41 +0000)]
Continue encapsulation of JTAG event callback sub-API:
- Move jtag_event_callbacks struct to core.c; it's an implementation detail.
- Move jtag_*_event_callbacks next to the definition of the new function type.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2169 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdd jtag_event_handler_t:
zwelch [Tue, 9 Jun 2009 08:41:29 +0000 (08:41 +0000)]
Add jtag_event_handler_t:
- Define the function signature used by the JTAG event callback mechanism.
- Provide Doxygen block for new type, including TODO for its return value.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2168 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoExpose jtag_unregister_event_callback with related API declarations.
zwelch [Tue, 9 Jun 2009 08:41:23 +0000 (08:41 +0000)]
Expose jtag_unregister_event_callback with related API declarations.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2167 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoImprove encapsulation of JTAG event handling:
zwelch [Tue, 9 Jun 2009 08:41:14 +0000 (08:41 +0000)]
Improve encapsulation of JTAG event handling:
- Move nvp_jtag_tap_event and jtag_tap_handle_event to tcl.c.
- Change both to be static; remove declaration of function from jtag.h.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2166 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoProperly encapsulate core hasKHZ variable.
zwelch [Tue, 9 Jun 2009 08:41:08 +0000 (08:41 +0000)]
Properly encapsulate core hasKHZ variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2165 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup and encapsulate IR Capture verification:
zwelch [Tue, 9 Jun 2009 08:41:00 +0000 (08:41 +0000)]
Cleanup and encapsulate IR Capture verification:
- Add accessors for setting the jtag_verify_capture_ir flag.
- Use them in handle_verify_ircapture_cpmmand
- Change variable type to bool; make it static.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2164 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdd missing static keywords to a few variables in JTAG core module.
zwelch [Tue, 9 Jun 2009 08:40:54 +0000 (08:40 +0000)]
Add missing static keywords to a few variables in JTAG core module.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2163 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMove the jtag_error helper routines out of header file:
zwelch [Tue, 9 Jun 2009 08:40:46 +0000 (08:40 +0000)]
Move the jtag_error helper routines out of header file:
- Makes jtag_error static, add new get helper function for completeness.
- Improve and add documentation and style for these helpers.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2162 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoEncapsulate jtag_reset_config using accessors:
zwelch [Tue, 9 Jun 2009 08:40:31 +0000 (08:40 +0000)]
Encapsulate jtag_reset_config using accessors:
- Update handle_reset_config_command in tcl.c to use new helpers.
- Replace direct accesses in JTAG interface and target drivers.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2161 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRemove superfluous extern for non-existant global variable.
zwelch [Tue, 9 Jun 2009 08:40:23 +0000 (08:40 +0000)]
Remove superfluous extern for non-existant global variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2160 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdd get and set accessors for jtag_speed:
zwelch [Tue, 9 Jun 2009 08:40:10 +0000 (08:40 +0000)]
Add get and set accessors for jtag_speed:
- Setter calls the interface driver callback to improve core encapsulation.
- Use getter in standard JTAG interface drivers and ZY1000 minidriver.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2159 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoEncapsulate the jtag_event_callback list; add helper functions if needed.
zwelch [Tue, 9 Jun 2009 08:40:02 +0000 (08:40 +0000)]
Encapsulate the jtag_event_callback list; add helper functions if needed.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2158 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoEncapsulate the jtag_trst and jtag_srst variables:
zwelch [Tue, 9 Jun 2009 08:39:50 +0000 (08:39 +0000)]
Encapsulate the jtag_trst and jtag_srst variables:
- Add accessor functions to return their value.
- Use new SRST accessor in cortex_m3.c and mips_m4k.c

git-svn-id: svn://svn.berlios.de/openocd/trunk@2157 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMove extern of nvp_jtag_tap_event from jtag.h to tcl.c.
zwelch [Tue, 9 Jun 2009 08:39:44 +0000 (08:39 +0000)]
Move extern of nvp_jtag_tap_event from jtag.h to tcl.c.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2156 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRemove superfluous extern of jtag_event_strings from jtag.h.
zwelch [Tue, 9 Jun 2009 08:39:37 +0000 (08:39 +0000)]
Remove superfluous extern of jtag_event_strings from jtag.h.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2155 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoremove native line style
oharboe [Tue, 9 Jun 2009 07:51:47 +0000 (07:51 +0000)]
remove native line style

git-svn-id: svn://svn.berlios.de/openocd/trunk@2154 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoremoved native line end style - breaks cygwin
oharboe [Tue, 9 Jun 2009 06:53:26 +0000 (06:53 +0000)]
removed native line end style - breaks cygwin

git-svn-id: svn://svn.berlios.de/openocd/trunk@2153 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoReplace 'jtag.c' with 'core.c' in code comments.
zwelch [Tue, 9 Jun 2009 04:54:09 +0000 (04:54 +0000)]
Replace 'jtag.c' with 'core.c' in code comments.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2152 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRemove accidental duplicate of hasKHz; fixes pre-init speed setup.
zwelch [Tue, 9 Jun 2009 04:39:54 +0000 (04:39 +0000)]
Remove accidental duplicate of hasKHz; fixes pre-init speed setup.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2151 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoProvide brief description of newly factored TCL layer in The Manual.
zwelch [Tue, 9 Jun 2009 04:35:16 +0000 (04:35 +0000)]
Provide brief description of newly factored TCL layer in The Manual.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2150 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSplit main jtag.c file into two layers:
zwelch [Tue, 9 Jun 2009 04:15:13 +0000 (04:15 +0000)]
Split main jtag.c file into two layers:
- src/jtag/core.c: contains the low-level JTAG TAP and scanning routines.
- src/jtag/tcl.c: contains high-level JTAG TCL commands that use the core.
- Remove static keywords from routines in core.c, extern from tcl.c:
  - jtag, jtag_interface global variables
  - jtag_{examine,validate}_chain and jtag_tap_{init,free} functions
- Added myself to the copyright header in both of these files.
- Used 'svn cp' to add files, so versioning was preserved for both.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2149 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMerge documentation for jtag_add_statemove from source into header block.
zwelch [Tue, 9 Jun 2009 02:48:28 +0000 (02:48 +0000)]
Merge documentation for jtag_add_statemove from source into header block.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2148 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMove Doxygen documentation for IR/DR scan routines to header file.
zwelch [Tue, 9 Jun 2009 02:48:18 +0000 (02:48 +0000)]
Move Doxygen documentation for IR/DR scan routines to header file.
- Move plain IR scan declaration closer to the other IR scan declarations.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2147 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years ago- Replace 'jtag_tap_by_abs_position' with 'jtag_tap_by_position'.
zwelch [Tue, 9 Jun 2009 02:24:05 +0000 (02:24 +0000)]
- Replace 'jtag_tap_by_abs_position' with 'jtag_tap_by_position'.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2146 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRemove non-existant jtag_tap_by_position API declaration.
zwelch [Tue, 9 Jun 2009 02:24:00 +0000 (02:24 +0000)]
Remove non-existant jtag_tap_by_position API declaration.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2145 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoUse unsigned type for jtag_tap_count and jtag_tap_by_abs_position.
zwelch [Tue, 9 Jun 2009 02:23:53 +0000 (02:23 +0000)]
Use unsigned type for jtag_tap_count and jtag_tap_by_abs_position.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2144 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup jtag_tap_by_abs_position:
zwelch [Tue, 9 Jun 2009 02:23:44 +0000 (02:23 +0000)]
Cleanup jtag_tap_by_abs_position:
- Remove unused orig_n local variable.
- Merge variable declaration with first use.
- Update code to use current style guidelines.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2143 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_tap_by_jim_object:
zwelch [Tue, 9 Jun 2009 02:23:35 +0000 (02:23 +0000)]
Simplify jtag_tap_by_jim_object:
- Merge declarations of temporary variables with first use.
- Restructure logic to simplify conditional logic.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2142 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify and fix bug in jtag_tap_by_string:
zwelch [Tue, 9 Jun 2009 02:23:27 +0000 (02:23 +0000)]
Simplify and fix bug in jtag_tap_by_string:
- Bug fix: Use unsigned type and strtoul when parsing for position number.
- Simplify logic by returning directly when a tap is found by name.
- Reduce scope: declare temporary variables with first use.
- Bring code up to current style guidelines.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2141 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAllow jtag_tap_add to be called from other JTAG code modules.
zwelch [Tue, 9 Jun 2009 02:23:16 +0000 (02:23 +0000)]
Allow jtag_tap_add to be called from other JTAG code modules.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2140 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup jtag_tap_count_enabled.
zwelch [Tue, 9 Jun 2009 02:23:03 +0000 (02:23 +0000)]
Cleanup jtag_tap_count_enabled.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2139 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoChange jtag_add_pathmove to set jtag_error rather than call exit():
zwelch [Tue, 9 Jun 2009 01:16:35 +0000 (01:16 +0000)]
Change jtag_add_pathmove to set jtag_error rather than call exit():
- Add new error codes to encode the possible failure conditions.
- Add documentation to describe the routine's possible error codes.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2138 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoReduce scope or eliminate temporary variables in jtag_add_statemove:
zwelch [Tue, 9 Jun 2009 01:16:19 +0000 (01:16 +0000)]
Reduce scope or eliminate temporary variables in jtag_add_statemove:
- Change types of tms_bits and tms_count to unsigned, eliminates a cast.
- Use moves[] only if needed; a single move can use goal_state directly.
- Declare loop induction variable inside its control statement.
- Remove retval in favor of direct returns.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2137 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMove documentation in jtag_add_statemove body to Doxygen block.
zwelch [Tue, 9 Jun 2009 01:16:13 +0000 (01:16 +0000)]
Move documentation in jtag_add_statemove body to Doxygen block.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2136 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRevert changes from r2134 that snuck into the commit. Mea culpa.
zwelch [Tue, 9 Jun 2009 01:01:13 +0000 (01:01 +0000)]
Revert changes from r2134 that snuck into the commit.  Mea culpa.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2135 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>:
zwelch [Tue, 9 Jun 2009 00:58:23 +0000 (00:58 +0000)]
David Brownell <david-b@pacbell.net>:

Add configuration for an old AT91rm9200 board, the Cogent CSB 337.
Worth noting from the OpenOCD perspective:

 - It got a real hardware trace port connector; wired up here as
   much as we can, lacking inexpensive trace-aware dongles.

 - This is the first in-tree use of the "arm920t cp15" command.
   It adjusts the CPU clocking and enables i-cache, which gives
   more than 4x speedup after booting Linux; it's visible even
   just running U-Boot.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2134 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFix eol-style on guess-rev.sh
kc8apf [Mon, 8 Jun 2009 22:18:16 +0000 (22:18 +0000)]
Fix eol-style on guess-rev.sh

git-svn-id: svn://svn.berlios.de/openocd/trunk@2133 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoupdate zy1000 to latest minidriver work
oharboe [Mon, 8 Jun 2009 14:13:32 +0000 (14:13 +0000)]
update zy1000 to latest minidriver work

git-svn-id: svn://svn.berlios.de/openocd/trunk@2132 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoZach Welch wrote a fix for configure problems under Cygwin.
oharboe [Mon, 8 Jun 2009 13:57:13 +0000 (13:57 +0000)]
Zach Welch wrote a fix for configure problems under Cygwin.
ltmain.sh is added to svn ignore

git-svn-id: svn://svn.berlios.de/openocd/trunk@2131 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdd documentation for new interface_list command to user guide.
zwelch [Mon, 8 Jun 2009 13:16:57 +0000 (13:16 +0000)]
Add documentation for new interface_list command to user guide.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2130 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactor interface list to its own command:
zwelch [Mon, 8 Jun 2009 13:12:17 +0000 (13:12 +0000)]
Factor interface list to its own command:
- Add handle_interface_list_command, used by handle_interface_command.
- Display output of new list to command console.
- Change first index of displayed drivers to 1; it's only cosmetic.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2129 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup and simplify handle_interface_command:
zwelch [Mon, 8 Jun 2009 13:12:12 +0000 (13:12 +0000)]
Cleanup and simplify handle_interface_command:
- Reduce indent: invert logic of strcmp test.
- Reduce scope: declare variables upon first use in loops.
- Reduce unsaid: compare end of table with NULL.
- Remove superfluous braces around blocks with one statment.
- Improve language that introduces the list of built-in drivers.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2128 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_sleep:
zwelch [Mon, 8 Jun 2009 10:58:28 +0000 (10:58 +0000)]
Simplify jtag_add_sleep:
- Add todo for removing keep_alive: is this a layering violation?
- Use jtag_set_error instead of accessing jtag_error directly.
- Remove superfluous retval temporary variable and empty return.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2127 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_reset:
zwelch [Mon, 8 Jun 2009 10:58:13 +0000 (10:58 +0000)]
Simplify jtag_add_reset:
- Use jtag_set_error instead of accessing jtag_error directly.
- Remove superfluous retval temporary variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2126 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_clocks:
zwelch [Mon, 8 Jun 2009 10:57:51 +0000 (10:57 +0000)]
Simplify jtag_add_clocks:
- Use jtag_set_error instead of accessing jtag_error directly.
- Improve error language and whitespace.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2125 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_runtest:
zwelch [Mon, 8 Jun 2009 10:57:39 +0000 (10:57 +0000)]
Simplify jtag_add_runtest:
- Use jtag_set_error instead of accessing jtag_error directly.
- Eliminate superfluous comment and temporary variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2124 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_pathmove:
zwelch [Mon, 8 Jun 2009 10:57:18 +0000 (10:57 +0000)]
Simplify jtag_add_pathmove:
- Use jtag_set_error instead of accessing jtag_error directly.
- Eliminate superfluous retval temporary variable.
- Reduce scope of loop induction variable.
- Wrap to fit within 80 columns.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2123 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_tlr:
zwelch [Mon, 8 Jun 2009 10:57:10 +0000 (10:57 +0000)]
Simplify jtag_add_tlr:
- Use jtag_set_error instead of accessing jtag_error directly.
- Eliminate superfluous temporary variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2122 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_plain_dr_scan:
zwelch [Mon, 8 Jun 2009 10:56:49 +0000 (10:56 +0000)]
Simplify jtag_add_plain_dr_scan:
- Use jtag_set_error instead of accessing jtag_error directly.
- Wrap function arguments to fit everything in 80 columns.
- Move retval variable to location of first use.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2121 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_dr_scan:
zwelch [Mon, 8 Jun 2009 10:56:36 +0000 (10:56 +0000)]
Simplify jtag_add_dr_scan:
- Use jtag_set_error instead of accessing jtag_error directly.
- Wrap function arguments to fit everything in 80 columns.
- Move retval variable to location of first use.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2120 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_plain_ir_scan:
zwelch [Mon, 8 Jun 2009 10:56:25 +0000 (10:56 +0000)]
Simplify jtag_add_plain_ir_scan:
- Use jtag_set_error instead of accessing jtag_error directly.
- Wrap function arguments to fit everything in 80 columns.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2119 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_add_ir_scan_noverify:
zwelch [Mon, 8 Jun 2009 10:56:18 +0000 (10:56 +0000)]
Simplify jtag_add_ir_scan_noverify:
- Use jtag_set_error instead of accessing jtag_error directly.
- Wrap and rename function arguments to fit everything in 80 columns.
- Move retval variable to location of first use.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2118 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_execute_queue:
zwelch [Mon, 8 Jun 2009 10:56:07 +0000 (10:56 +0000)]
Simplify jtag_execute_queue:
- Add static inline jtag_error_clear helper to return and clear jtag_error.
- Use new helper to shrink body of function to two lines.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2117 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify jtag_execute_queue_noclear:
zwelch [Mon, 8 Jun 2009 10:55:54 +0000 (10:55 +0000)]
Simplify jtag_execute_queue_noclear:
- Replace jtag_error logic with equivalent call to jtag_set_error.
- Remove superfluous comment and temporary return variable.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2116 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup handle_runtest_command:
zwelch [Mon, 8 Jun 2009 10:55:44 +0000 (10:55 +0000)]
Cleanup handle_runtest_command:
- Make command argument require exactly one argument; do not allow extras.
- Remove superfluous whitespace at end of function.
- Wrap function arguments to fit in 80 columns.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2115 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoClean up handle_jtag_reset_command:
zwelch [Mon, 8 Jun 2009 10:55:36 +0000 (10:55 +0000)]
Clean up handle_jtag_reset_command:
- Make command require exactly two arguments; do not allow more than two.
- Move temporary variable declarations closer to point of first use.
- Remove superfluous braces around single statments.
- Wrap to 80 column width.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2114 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoExtend handle_jtag_n{s,t}rst_delay_command routines:
zwelch [Mon, 8 Jun 2009 10:55:24 +0000 (10:55 +0000)]
Extend handle_jtag_n{s,t}rst_delay_command routines:
- Add support to display the reset delays too, like the other commands.
- Always show the values, so users can see if they are being redundant.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2113 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdd accessors to retrieve values of jtag_n{s,t}rst_delay variables.
zwelch [Mon, 8 Jun 2009 10:55:13 +0000 (10:55 +0000)]
Add accessors to retrieve values of jtag_n{s,t}rst_delay variables.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2112 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoUpdate JTAG reset delay command handlers:
zwelch [Mon, 8 Jun 2009 10:54:52 +0000 (10:54 +0000)]
Update JTAG reset delay command handlers:
- Fixes for error handling:
  - Return a syntax error instead of calling exit(-1).
  - Return error when more than one argument is provided too.
- Remove useless braces and indent after the if/return statements.
- Wrap function arguments to fit in 80 columns.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2111 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoCleanup the handle_jtag_khz_command routine:
zwelch [Mon, 8 Jun 2009 10:54:41 +0000 (10:54 +0000)]
Cleanup the handle_jtag_khz_command routine:
- Separate retval assignments from logical tests.
- Simplify logical tests.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2110 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSimplify logic in handle_jtag_speed_command.
zwelch [Mon, 8 Jun 2009 10:54:06 +0000 (10:54 +0000)]
Simplify logic in handle_jtag_speed_command.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2109 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net> Bugfix: $target_name cget/configure -work-area...
oharboe [Mon, 8 Jun 2009 06:18:13 +0000 (06:18 +0000)]
David Brownell <david-b@pacbell.net> Bugfix: $target_name cget/configure -work-area-backup commands
should return the "is it backed up?" flag, not the work area size.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2108 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>
oharboe [Mon, 8 Jun 2009 06:16:43 +0000 (06:16 +0000)]
David Brownell <david-b@pacbell.net>

- Don't let disabled TAPs be set as the current target

 - Improve "targets" output:
    * Remove undesirable "chain position" number; we discourage using them
    * TAP and Target column updates:
       + make them long enough for current usage
       + improve labels, removing guesswork
       + "TapName" label patches scan_chain output
    * Highlight the "current" target
    * Display "tap disabled" as a new pseudo-state
    * Update docs accordingly

git-svn-id: svn://svn.berlios.de/openocd/trunk@2107 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoAdjust whitespace in configure script: use two spaces for indent.
zwelch [Mon, 8 Jun 2009 04:35:19 +0000 (04:35 +0000)]
Adjust whitespace in configure script: use two spaces for indent.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2106 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoReorder configure script macros:
zwelch [Mon, 8 Jun 2009 04:35:05 +0000 (04:35 +0000)]
Reorder configure script macros:
- Check for a compiler before looking for libraries or header files.
- Initialize automake before calling other AM_ macros.
- Disable libtool shared libraries by default.
- Remove checks for unused C++, Fortran, and Java compilers.
- Remove redundant AC_CANONICAL_HOST; called by AC_PROG_LIBTOOL.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2105 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoRework parallel port configure script option handling:
zwelch [Mon, 8 Jun 2009 04:34:45 +0000 (04:34 +0000)]
Rework parallel port configure script option handling:
- Move AC_ARG_ENABLE for secondary parallel port options:
  - These macros cause their configure options to appear unconditionally,
    so they should not be placed inside conditional logic.
  - Groups them with primary parallel port driver option.
- Update these options to show '-' instead of '_'; both still work.
- Update command help text to show host architecture/OS requirements.
- Display a warning when these options have been provided and the
  configure script will ignore the setting that the user specified.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2104 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoMove minidummy source file, as was supposed to happen in last commit.
zwelch [Mon, 8 Jun 2009 01:14:04 +0000 (01:14 +0000)]
Move minidummy source file, as was supposed to happen in last commit.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2103 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFinish off the dummy minidriver integration:
zwelch [Mon, 8 Jun 2009 00:42:15 +0000 (00:42 +0000)]
Finish off the dummy minidriver integration:
- Try to disambiguates minidriver options from "standard" driver options.
  - Make minidummy symbols more explict about being a minidriver.
  - Move minidummy.c into minidummy directory to put it with its header.

In configure.in:
- Improve configuration option to allow new minidriver implementations:
  - Change option from --enable-minidummy to --enable-minidriver-dummy.
  - Move it to the end of the list of options.
  - Provides a clear pattern for future minidrivers.
- Update handling of HAVE_JTAG_MINIDRIVER_H:
  - Check for external jtag_minidriver.h only with --enable-ecosboard.
  - Otherwise, define it when --enable-minidriver-dummy is provided.
- Add check to ensure only one minidriver is enabled.
- When a minidriver is enabled, warn user that standard drivers are not built.
- Use proper AC_DEFINE semantics with MINIDRIVER_DUMMY.

In src/jtag/Makefile.am:
- Restructure handling of minidummy source files.
- Include minidummy driver header in the distribution.

In src/jtag/jtag.c:
- Restructure preprocessor logic to include:
  - only one minidriver, or
  - all configured standard drivers.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2102 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFix reference warning in JTAG primer, add another external reference.
zwelch [Sun, 7 Jun 2009 23:49:14 +0000 (23:49 +0000)]
Fix reference warning in JTAG primer, add another external reference.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2101 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>:
zwelch [Sun, 7 Jun 2009 23:35:29 +0000 (23:35 +0000)]
David Brownell <david-b@pacbell.net>:

Let disabled targets be ignored during normal operation:

 - In target_examine(), ignore disabled TAPs

 - Reset handling must not poke at them either:
     * fail $target_name arp_* operations on disabled TAPs
     * in startup.tcl, don't even issue the arp_* wait ops

ZW: removed superfluous braces from the patch to target.c.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2100 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>:
zwelch [Sun, 7 Jun 2009 23:21:41 +0000 (23:21 +0000)]
David Brownell <david-b@pacbell.net>:

Clarify docs for the evb_lm3s811 layout:  works in
two modes, not just one.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2099 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFix regression in mdw output; identified by Magnus Lundin.
zwelch [Sun, 7 Jun 2009 23:20:30 +0000 (23:20 +0000)]
Fix regression in mdw output; identified by Magnus Lundin.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2098 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>:
zwelch [Sun, 7 Jun 2009 23:14:58 +0000 (23:14 +0000)]
David Brownell <david-b@pacbell.net>:

Rework chapter 12 (CPU configuration) to use @deffn, match
the code more closely, and present things more clearly.

Includes the *current* list of targets.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2097 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net>:
zwelch [Sun, 7 Jun 2009 23:10:50 +0000 (23:10 +0000)]
David Brownell <david-b@pacbell.net>:

Various minor tweaks for the User's guide.

 - Fix various minor (but repeated) typographic goofs;
 - Talk about TAP "declaration" not "creation" (they exist
   even if OpenOCD never learns about their board);
 - Encourage board.cfg for reset config, not target.cfg
 - Fill in some missing information (e.g. x16_as_x8)
 - Add a cross reference to the FAQ on TAP ordering;
 - Unclutter the concept index a bit (re core-specific commands)
 - Provide a bit more info about TAP states

git-svn-id: svn://svn.berlios.de/openocd/trunk@2096 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoretire endstate command
oharboe [Sun, 7 Jun 2009 19:10:51 +0000 (19:10 +0000)]
retire endstate command

git-svn-id: svn://svn.berlios.de/openocd/trunk@2095 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoSet svn:eol-style properties on new minidummy driver files.
zwelch [Sun, 7 Jun 2009 18:39:11 +0000 (18:39 +0000)]
Set svn:eol-style properties on new minidummy driver files.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2094 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFix regressions in previous series of cleanp, caused by r2092.
zwelch [Sun, 7 Jun 2009 18:38:13 +0000 (18:38 +0000)]
Fix regressions in previous series of cleanp, caused by r2092.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2093 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agominidriver build test driver "minidriver"
oharboe [Sun, 7 Jun 2009 13:55:29 +0000 (13:55 +0000)]
minidriver build test driver "minidriver"

git-svn-id: svn://svn.berlios.de/openocd/trunk@2092 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:24:27 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Improve variable type: change device_count to unsigned.
- Improves jtag_tap_count_enabled() API too (now returns unsigned).

git-svn-id: svn://svn.berlios.de/openocd/trunk@2091 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:24:20 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Limit scope: move tap and bit_count variables to point of first use.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2090 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:24:12 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor TAP ID matching into new helper function.
- Simplifies the main jtag_examine_chain loop logic considerably.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2089 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:24:03 +0000 (05:24 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Minor whitespace and style cleanups in body of jtag_examine_chain.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2088 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:23:50 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Add helper to check for the terminating ID during jtag_examine_chain.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2087 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:23:40 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor end-of-chain verfication into new helper routine.
- Change 'unexpected' local variable name to 'triggered' and type to bool.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2086 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:23:30 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor output of accepted/incorrect/expected TAP IDs into static helper.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2085 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:23:13 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor initial chain examination check into new static helper.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2084 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:23:03 +0000 (05:23 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Factor JTAG chain examination into static helper function.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2083 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:22:53 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logical test of expected_id count.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2082 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:22:42 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logic test for unexpected TAP (no IDs).

git-svn-id: svn://svn.berlios.de/openocd/trunk@2081 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:22:34 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Reduce indent: invert logic test for tap in jtag_examine_chain.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2080 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:22:25 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Move definition of maximum JTAG chain size closer to its only uses.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2079 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoFactoring of jtag_examine_chain for maintainability:
zwelch [Sun, 7 Jun 2009 05:22:09 +0000 (05:22 +0000)]
Factoring of jtag_examine_chain for maintainability:
- Move JTAG EXTRACT macros out from the middle of jtag_examine_chain.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2078 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoClean up handle_endstate_command():
zwelch [Sun, 7 Jun 2009 03:48:21 +0000 (03:48 +0000)]
Clean up handle_endstate_command():
- Merge declaration of state with first use.
- Unindent and remove unnecessary 'else' block.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2077 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoDavid Brownell <david-b@pacbell.net> target/at91rm9200.cfg cleanup
oharboe [Fri, 5 Jun 2009 08:35:24 +0000 (08:35 +0000)]
David Brownell <david-b@pacbell.net> target/at91rm9200.cfg cleanup

git-svn-id: svn://svn.berlios.de/openocd/trunk@2075 b42882b7-edfa-0310-969c-e2dbd0fdcd60

11 years agoremove hacks no longer required to build OpenOCD w/eCos
oharboe [Fri, 5 Jun 2009 06:43:09 +0000 (06:43 +0000)]
remove hacks no longer required to build OpenOCD w/eCos

git-svn-id: svn://svn.berlios.de/openocd/trunk@2074 b42882b7-edfa-0310-969c-e2dbd0fdcd60