openocd.git
7 years agoarmv7a: fix scan-build warnings
Andreas Fritiofson [Mon, 24 Oct 2011 22:47:21 +0000 (00:47 +0200)]
armv7a: fix scan-build warnings

"Value stored to 'retval' is never read": Check and propagate error
"Dereference of null pointer": Probably bogus, maybe triggered by the null
check on armv7a, so remove the check since it can't be null anyway.

Change-Id: I3bc44e52af1589ff40e6a42deda0ce7f3a25e397
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/119
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoarmv7a: make local functions static
Andreas Fritiofson [Mon, 24 Oct 2011 22:36:24 +0000 (00:36 +0200)]
armv7a: make local functions static

Also fix a spelling error and remove the declaration for a non-existent
function from the header.

Change-Id: I13177e2d81aa167c05c1cc766f06924211e6d735
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/118
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoarmv7m: improve error handling
Andreas Fritiofson [Mon, 24 Oct 2011 22:03:42 +0000 (00:03 +0200)]
armv7m: improve error handling

Propagate errors unchanged.
Free allocated working area in the error return path.
Remove duplicated cleanup code by rewriting the logic.
As a side-effect, fixes a scan-build warning.

Change-Id: I80e3c0015be672778f916e998c8c2e4f23d7588c
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/117
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoFix "Evaluate 'script' in the global scope"
Freddie Chopin [Sat, 22 Oct 2011 07:53:55 +0000 (09:53 +0200)]
Fix "Evaluate 'script' in the global scope"

This fixes commit Evaluate 'script' in the global scope. It caused
Windows builds behave differently than before because path was evaluated twice
and backslashes from Windows' paths got unescaped and effectively wiped out.
Configs could only be passed with "-f ../dir/config.cfg" or "-f
..\\dir\\config.cfg" instead of usual "-f dir/config.cfg" (or using backslash)
as previously.

Change-Id: I13b4abac6dbe6d770cc11a4e61c9421ef340da83
Author: Steve Bennett <steveb@workware.net.au>
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/40
Tested-by: jenkins
Reviewed-by: Xiaofan <xiaofanc@gmail.com>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agowarning: silence gcc by initializing local variables
Øyvind Harboe [Mon, 24 Oct 2011 16:11:43 +0000 (18:11 +0200)]
warning: silence gcc by initializing local variables

GCC doesn't understand that these are in fact initialized if they are
used.

Change-Id: I01988adb0547f785b48d869ddbe44cc17dca4739
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/116
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoSERVER: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:16:26 +0000 (12:16 +0800)]
SERVER: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I0b9d0b419d9c8b7a8c755e048d5faf72d1658ba2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/87
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agocfg: Add interface config for Dangerous Prototypes BusBlaster
Richard Barlow [Sun, 23 Oct 2011 11:50:34 +0000 (12:50 +0100)]
cfg: Add interface config for Dangerous Prototypes BusBlaster

The BusBlaster from Dangerous Prototypes is based on the FTDI FT2232H IC.
It has a CPLD between the FT2232H and the JTAG header allowing it to
emulate various debugger types. It comes configured as a JTAGkey compatible
device.

Change-Id: Iab56907bf67ded87001e628d93012f1e16287d90
Signed-off-by: Richard Barlow <richard@richardbarlow.co.uk>
Reviewed-on: http://openocd.zylin.com/53
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
7 years agoNOR/CORE: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:12:57 +0000 (12:12 +0800)]
NOR/CORE: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I10338a249bcfeff87d8596f7e17f209e26b41678
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/86
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoNAND/CORE: fix clang warning
Antonio Borneo [Sun, 23 Oct 2011 04:02:57 +0000 (12:02 +0800)]
NAND/CORE: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I42a371d6adfdf3b3fb867705211c47d89776ee2a
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/85
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoFLASH/CFI: fix clang warnings
Antonio Borneo [Sun, 23 Oct 2011 03:21:44 +0000 (11:21 +0800)]
FLASH/CFI: fix clang warnings

Total of 5 warnings:
3x "Dead store": removed dead assignment to variable;
1x "Dereference of null pointer": this is not an error, but a
   limited visibility of clang, since pointer erase_region_info
   is initialized inside cfi_fixup_non_cfi();
1x "Branch condition evaluates to a garbage value":
   this is a real coding bug that could issue SIGSEGV, since
   "goto cleanup" can be executed before initialization
   of "source".

Change-Id: Id3c323c82bb15cbd3bb8fc04b23541f11145f109
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/84
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agomx2: add error propagation and remove warnings
Øyvind Harboe [Fri, 21 Oct 2011 23:11:58 +0000 (01:11 +0200)]
mx2: add error propagation and remove warnings

Change-Id: Idd4fb452790e5d7921a749679dbd865586e5a4a9
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/48
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agofm3: fix warning for superfluous assignment
Øyvind Harboe [Fri, 21 Oct 2011 23:08:16 +0000 (01:08 +0200)]
fm3: fix warning for superfluous assignment

Change-Id: I4f8e8c2e676a2728ddc6227daf9ca6a7ceb3d505
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/46
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agokinetis: fix warning about malloc(0) w/assert
Øyvind Harboe [Fri, 21 Oct 2011 23:09:32 +0000 (01:09 +0200)]
kinetis: fix warning about malloc(0) w/assert

Change-Id: Ib40204675bfc5429c744f9ed7e2f7098384b753d
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/47
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agotms470: remove dead assignment warning
Øyvind Harboe [Fri, 21 Oct 2011 23:06:26 +0000 (01:06 +0200)]
tms470: remove dead assignment warning

Change-Id: I21e7ac47f80d93c9c0d7b169f8848b929c664b20
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/45
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoadd Freescale Kinetis K40 devices and Kwikstik eval board
Mathias K [Sat, 22 Oct 2011 16:00:20 +0000 (18:00 +0200)]
add Freescale Kinetis K40 devices and Kwikstik eval board

Change-Id: I4817921d09ab915c50f42651bc073690033450fe
Signed-off-by: Mathias K <kesmtp@freenet.de>
Reviewed-on: http://openocd.zylin.com/51
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoclang: fix warning w/assert so that clang knows that there will be no division by...
Øyvind Harboe [Fri, 21 Oct 2011 17:14:57 +0000 (19:14 +0200)]
clang: fix warning w/assert so that clang knows that there will be no division by zero

Change-Id: I98ac62a22f21043bb535a667a4f1f1537ccde2a4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/42
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoclang: fix malloc() warning with assert
Øyvind Harboe [Fri, 21 Oct 2011 17:00:09 +0000 (19:00 +0200)]
clang: fix malloc() warning with assert

Change-Id: I989d2655622a9f11f4a0a2994014e42822587ecd
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/41
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agotms470: removed unnecessary operations
Edgar Grimberg [Sun, 23 Oct 2011 09:39:50 +0000 (11:39 +0200)]
tms470: removed unnecessary operations

This should silence a warning.

Change-Id: Id91a9ebacae836083b1db2654a8e7bf24b2300e9
Signed-off-by: Edgar Grimberg <edgar.grimberg@gmail.com>
Reviewed-on: http://openocd.zylin.com/52
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoFLASH/STMSMI: fix clang "dead store" warning
Antonio Borneo [Sat, 22 Oct 2011 11:23:10 +0000 (19:23 +0800)]
FLASH/STMSMI: fix clang "dead store" warning

Change-Id: Icfdefdc48432db2057d3fea19dc424571d2385eb
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/50
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agobuspirate: ignore return value and fix warning
Øyvind Harboe [Fri, 21 Oct 2011 22:40:51 +0000 (00:40 +0200)]
buspirate: ignore return value and fix warning

Perhaps we could do one better and propagate the error?

Change-Id: Idc45f516c26f09de4ee01fe05e8d3475f4b80db3
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/43
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agowarning: fix false positive
Øyvind Harboe [Sat, 22 Oct 2011 06:25:00 +0000 (08:25 +0200)]
warning: fix false positive

may be used uninitialized in this function [-Werror=uninitialized]

Change-Id: Ida2cf8efe4e7da6fd9f669b806a20894563ac3d4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/49
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoserver: remove warning due to dead assignment
Øyvind Harboe [Fri, 21 Oct 2011 23:04:27 +0000 (01:04 +0200)]
server: remove warning due to dead assignment

Change-Id: Idb08aef0c11b3fae92286e8fcea61ab09ab09e74
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/44
Reviewed-by: Peter Stuge <peter@stuge.se>
Tested-by: jenkins
7 years agojim: add missing jim license
Spencer Oliver [Fri, 21 Oct 2011 08:51:21 +0000 (09:51 +0100)]
jim: add missing jim license

Change-Id: Ib8e34739d92cd54655b9b47d07b856a82ff25f3c
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/39
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agortos: remove broken code for handling the deprecated qP packet
Andreas Fritiofson [Wed, 19 Oct 2011 22:21:33 +0000 (00:21 +0200)]
rtos: remove broken code for handling the deprecated qP packet

Change-Id: Icca522c1e2a2877abb20665b171c61079b1d8f48
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/37
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
7 years agortos: return the correct value if the T or H packets are handled
Andreas Fritiofson [Wed, 19 Oct 2011 22:25:08 +0000 (00:25 +0200)]
rtos: return the correct value if the T or H packets are handled

Change-Id: Iea31e20ee4e35c1a9cb7b93424c92b3f38081067
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/38
Tested-by: jenkins
Reviewed-by: Evan Hunter <evan@ozhiker.com>
Reviewed-by: Peter Stuge <peter@stuge.se>
7 years agoUnused variables
Freddie Chopin [Wed, 19 Oct 2011 19:40:48 +0000 (21:40 +0200)]
Unused variables

Fix a few errors with set and unused variables detected by GCC 4.7.0

Change-Id: I59b748e18e514ee9f0cde7883b4ed5116198bd4a
Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-on: http://openocd.zylin.com/36
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoUpdated fm3.c, added Flash type 2 support, error handling improved
Marc Willam / Holger Wech [Thu, 13 Oct 2011 13:43:06 +0000 (14:43 +0100)]
Updated fm3.c, added Flash type 2 support, error handling improved

Change-Id: I684aca11c4554290d0e57c6d3318d8082980c1ef
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
Reviewed-on: http://openocd.zylin.com/10
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoTMPA900/910 MCUs are always little endian.
Uwe Hermann [Tue, 18 Oct 2011 23:54:25 +0000 (01:54 +0200)]
TMPA900/910 MCUs are always little endian.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Change-Id: I8839f2cf0faf1b5ba9f99901c5ee028b199fabd2
Reviewed-on: http://openocd.zylin.com/35
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
7 years agoToshiba TMPA900 config: Fix incorrect working area.
Uwe Hermann [Tue, 18 Oct 2011 23:09:44 +0000 (01:09 +0200)]
Toshiba TMPA900 config: Fix incorrect working area.

The Toshiba TMPA900 series (TMPA900/901) only has internal RAM regions
RAM-0 (16kB) and RAM-1 (8kB) which we can use as working area.

This is probably a copy-paste error from tmpa910.cfg, which has the
correct values and sizes for the TMPA910 series (TMPA910/911/912/913):
there are RAM-0, RAM-1, and RAM-2 (each 16kB).

Also, change "built-in RAM" to "internal RAM" to match what the
datasheet uses.

Change-Id: I993cd6b7fadc28cf34e5cc18426bb2bb42597670
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/34
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
7 years agoxscale: fix bug in xscale_receive()
Matt Reimer [Mon, 19 Sep 2011 14:30:13 +0000 (10:30 -0400)]
xscale: fix bug in xscale_receive()

The code in xscale_receive() that tries to skip invalid reads (i.e.
reads that don't have the DBG_SR[0] 'valid' bit set) seems to be
wrong, as it only looks at the first word's valid flag rather than
each word's own valid flag. Am I reading the code correctly? If so,
the attached patch should fix it.

If this looks correct, I'll generate a proper patch and commit message.

Matt

Change-Id: I74ebe2ad7a36d340a9dd3b8487578b6ea7f3cf1e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/32
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoluminary: add new targets
Spencer Oliver [Mon, 17 Oct 2011 21:27:49 +0000 (22:27 +0100)]
luminary: add new targets

update target support from latest SW-DRL 8049

Change-Id: I40aba4d30fe2b79fd955f466c64d99a1dfd63ecf
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/31
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoluminary: add peripheral reset script
Spencer Oliver [Mon, 17 Oct 2011 21:04:21 +0000 (22:04 +0100)]
luminary: add peripheral reset script

some luminary device classes require a reset script
to emulate a hardware reset.

Change-Id: Id505c92451244b48b0238c2130aebab2df8d208b
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/30
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoAM/DM37x: Use ICEPick warm reset and include halt when gdb connects.
Karl Kurbjun [Sun, 2 Oct 2011 17:41:33 +0000 (11:41 -0600)]
AM/DM37x: Use ICEPick warm reset and include halt when gdb connects.

Using the ICEPick reset seems to allow the processor to be halted sooner
and the halt on gdb connection makes the connect process more robust.

Change-Id: I0586f6e6becc60a729030509ef58907a19d545ec
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/23
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoICEPick-C: Add support for warm reset through JTAG controller and provide finer detai...
Karl Kurbjun [Sun, 2 Oct 2011 16:52:20 +0000 (10:52 -0600)]
ICEPick-C: Add support for warm reset through JTAG controller and provide finer detail functions.

This sets up simple functions that can later be used to provide additional
ICEPick Operations.

Change-Id: I313b8679267696fad87d23f3692963e513f2fe21
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/22
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoAdd the SAM3N familly to the chip_details table
Attila Kinali [Mon, 10 Oct 2011 13:09:22 +0000 (15:09 +0200)]
Add the SAM3N familly to the chip_details table

Change-Id: Ic122d324eacf6e667ed6008ebb84708be944222c
Signed-off-by: Attila Kinali <attila@kinali.ch>
Reviewed-on: http://openocd.zylin.com/29
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agotarget_request: add target_got_message() that can be used to improve DCC performance
Øyvind Harboe [Fri, 14 Oct 2011 12:55:17 +0000 (14:55 +0200)]
target_request: add target_got_message() that can be used to improve DCC performance

API change to allow implementing a back-off algorithm for
polling hardware.

Change-Id: I6cbe8b4534c8dfeb8442305171ea96b5481c1f17
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/26
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agotarget: DCC / target message backoff algorithm
Øyvind Harboe [Fri, 14 Oct 2011 13:05:45 +0000 (15:05 +0200)]
target: DCC / target message backoff algorithm

by immediately polling again when we have received a message from
the target instead of waiting 100ms, we can hope for much better
performance. More than 100x? :-)

Change-Id: Ieaf0c6c8b6e5addc482895670ffbf9a743e07a29
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/27
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
7 years agoAdd some more detail for setting up Gerrit account.
Jim Norris [Fri, 14 Oct 2011 18:42:26 +0000 (13:42 -0500)]
Add some more detail for setting up Gerrit account.

1) Add a couple more steps when setting up the Gerrit account.

Change-Id: I5d81feac4650d4d28653d14cfc0baf14270424c1
Signed-off-by: Jim Norris <u17263@att.net>
Reviewed-on: http://openocd.zylin.com/28
Reviewed-by: Peter Stuge <peter@stuge.se>
Tested-by: Peter Stuge <peter@stuge.se>
7 years agoarm-jtag-ew: whitespace cleanup
Spencer Oliver [Fri, 14 Oct 2011 08:40:58 +0000 (09:40 +0100)]
arm-jtag-ew: whitespace cleanup

Change-Id: I8861e825f9c84525e0c09c3adaa3fe300640770d
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
Reviewed-on: http://openocd.zylin.com/21
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoflash: fix lpc2000 driver typo 24/24/2
Spencer Oliver [Fri, 14 Oct 2011 12:03:29 +0000 (13:03 +0100)]
flash: fix lpc2000 driver typo

Change-Id: I3a759ed98a27fd186c12355b846d5e97dba86c5b
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoAdd an interface file for DLP Design DLP-USB1232H.
Uwe Hermann [Thu, 13 Oct 2011 22:21:06 +0000 (00:21 +0200)]
Add an interface file for DLP Design DLP-USB1232H.

The DLP Design DLP-USB1232H UART/SPI/JTAG module is based on an FTDI FT2232H
chip. Among other things, it can used as JTAG programmer if connected to
the JTAG target properly. I have successfully wired the module to an
Olimex STM32-H103 eval board and flashed a firmware onto that using OpenOCD.

The setup details and schematics are documented at:
http://randomprojects.org/wiki/DLP-USB1232H_and_OpenOCD_based_JTAG_adapter

Change-Id: I5eb9255a61eeece233009bee77d7dc3b5d1afb8b
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/20
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoAdd a board file for the Glyn Tonga2.
Uwe Hermann [Thu, 13 Oct 2011 22:13:47 +0000 (00:13 +0200)]
Add a board file for the Glyn Tonga2.

This is a Toshiba TMPA900CMXBG (ARM9) based SO-DIMM CPU module with 64MB
DDR SDRAM, 256MB NAND flash, and on-board Ethernet.

The board file provides a tonga2_init function which sets up the
PLL/clocks and memory (SDRAM and SRAM), which allows writing a boot-loader
into RAM via JTAG.

Change-Id: I60522b97997bdf50e1f25aebab910d93a98522fb
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/19
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agotarget: whitespace cleanup
Spencer Oliver [Thu, 13 Oct 2011 18:58:06 +0000 (19:58 +0100)]
target: whitespace cleanup

Change-Id: I1453f4f3dc0add529da20577e38b8b82d7d00366
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
Reviewed-on: http://openocd.zylin.com/18
Reviewed-by: Alex Austin <alex.austin@spectrumdsi.com>
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agobreakpoint : smp software breakpoint issue
Michel Jaouen [Mon, 3 Oct 2011 17:05:59 +0000 (19:05 +0200)]
breakpoint : smp software breakpoint issue

Change-Id: Iefe78bad71d4fdb38ae412ab8fe2f6282836c22e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/14
Tested-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
7 years agoMerge "docs: update HACKING to point to Gerrit"
Peter Stuge [Wed, 12 Oct 2011 18:48:21 +0000 (18:48 +0000)]
Merge "docs: update HACKING to point to Gerrit"

7 years agodocs: update HACKING to point to Gerrit 17/17/2
Øyvind Harboe [Wed, 12 Oct 2011 18:21:18 +0000 (20:21 +0200)]
docs: update HACKING to point to Gerrit

Change-Id: If79e86c731ac06aaefca1aebde40e7cb3de68e4d
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
7 years agodocs: update more url's 16/16/1
Spencer Oliver [Wed, 12 Oct 2011 11:25:59 +0000 (12:25 +0100)]
docs: update more url's

Change-Id: I476078f32910579fed55777c3b0e6da3ef3363b7
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
7 years agodocs: update project url's 15/15/1
Spencer Oliver [Wed, 12 Oct 2011 08:32:59 +0000 (09:32 +0100)]
docs: update project url's

Change-Id: I54fc3aff722ed25143aad85e58d19b72fcecbba0
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
7 years agobreakpoint : indentation 13/13/1
Michel Jaouen [Mon, 3 Oct 2011 17:03:47 +0000 (19:03 +0200)]
breakpoint : indentation

Change-Id: Icdb8f72dbb516cd0dfc612c3d61b6801f6382be6
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
7 years agoreplace berlios url's with sourceforge url's 09/9/1
Spencer Oliver [Tue, 11 Oct 2011 16:18:05 +0000 (17:18 +0100)]
replace berlios url's with sourceforge url's

Change-Id: I1c9957bb64df87cee7c5e832f21453eb8934a5fb
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
7 years agocontrib: remove extra lf 08/8/1
Spencer Oliver [Tue, 11 Oct 2011 12:01:22 +0000 (13:01 +0100)]
contrib: remove extra lf

Change-Id: I6e16010e13ad2ea0cdff99b2e8805c74bcd0eb56
Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
7 years agostm32f1x: use async algorithm in flash programming routine
Andreas Fritiofson [Sun, 31 Jul 2011 08:31:56 +0000 (10:31 +0200)]
stm32f1x: use async algorithm in flash programming routine

Let the target algorithm be running in the background and buffer data
continuously through a FIFO. This reduces or removes the effect of latency
because only a very small number of queue executions needs to be done per
buffer fill. Previously, the many repeated target state changes, register
accesses (really inefficient) and algorithm uploads caused the flash
programming to be latency bound in many cases. Now it should scale better
with increased throughput.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
7 years agostm32f1x: use register base instead of register offset
Andreas Fritiofson [Sun, 17 Jul 2011 12:07:26 +0000 (14:07 +0200)]
stm32f1x: use register base instead of register offset

Access the different flash banks' registers using a bank specific register
base and a register specific offset. This is equivalent but feels more
natural.

Some accesses were discovered that maybe should not be hard coded to bank0
registers. Add a note about that.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
7 years agocortex_m3: use armv7m's async algorithm implementation
Andreas Fritiofson [Fri, 15 Jul 2011 20:21:34 +0000 (22:21 +0200)]
cortex_m3: use armv7m's async algorithm implementation

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
7 years agoarmv7m: implement async algorithm functions
Andreas Fritiofson [Fri, 15 Jul 2011 20:20:34 +0000 (22:20 +0200)]
armv7m: implement async algorithm functions

Split armv7m_run_algorithm into two pieces and use them to reimplement it.
The arch_info parameter is used to keep context between the two calls, so
both calls must refer to the same armv7m_algorithm struct. Ugly but works
for a proof-of-concept.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
7 years agotarget: add async algorithm entries to the target type
Andreas Fritiofson [Fri, 15 Jul 2011 20:18:39 +0000 (22:18 +0200)]
target: add async algorithm entries to the target type

On supported targets, this may be used to start a long running algorithm in
the background so the target may be interacted with during execution and
later wait for its completion.

The most obvious use case is a double buffered flash algorithm that can
upload the next block of data while the algorithm is flashing the current.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
7 years agoarm-jtag-ew: Send GDB keep_alive() messages when logging USB communication
Simon Barner [Fri, 16 Sep 2011 19:15:19 +0000 (21:15 +0200)]
arm-jtag-ew: Send GDB keep_alive() messages when logging USB communication

- Ticket: #35

7 years agoarm-jtag-ew: Formatting
Simon Barner [Fri, 16 Sep 2011 19:14:39 +0000 (21:14 +0200)]
arm-jtag-ew: Formatting

7 years agoarm-jtag-ew: In armjtagew_init(), set initial JTAG speed to 32 kHz (before TAP initia...
Simon Barner [Fri, 16 Sep 2011 19:13:39 +0000 (21:13 +0200)]
arm-jtag-ew: In armjtagew_init(), set initial JTAG speed to 32 kHz (before TAP initialization).

This prevents rare communication errors during startup.

7 years agoarm-jtag-ew: Emit a warning if interface firmware version != 1.6
Simon Barner [Fri, 16 Sep 2011 19:12:47 +0000 (21:12 +0200)]
arm-jtag-ew: Emit a warning if interface firmware version != 1.6

7 years agoarm-jtag-ew: Declare interface as `jtag_only'
Simon Barner [Fri, 16 Sep 2011 19:11:40 +0000 (21:11 +0200)]
arm-jtag-ew: Declare interface as `jtag_only'

7 years agoarm-jtag-ew: Provide armjtagew_speed_div() in order to fix interactive use of `adapte...
Simon Barner [Fri, 16 Sep 2011 19:10:23 +0000 (21:10 +0200)]
arm-jtag-ew: Provide armjtagew_speed_div() in order to fix interactive use of `adapter_khz'

7 years agoarm-jtag-ew: Fix setting interface speed (2/2)
Simon Barner [Fri, 16 Sep 2011 19:08:10 +0000 (21:08 +0200)]
arm-jtag-ew: Fix setting interface speed (2/2)

Interface expects speed in Hz, not kHz

- Ticket #34

7 years agoarm-jtag-ew: Fix setting interface speed (1/2)
Simon Barner [Fri, 16 Sep 2011 19:06:02 +0000 (21:06 +0200)]
arm-jtag-ew: Fix setting interface speed (1/2)

CMD_SET_TCK_FREQUENCY message length is 5, not 4

- Ticket: #34

7 years agoAdd udev rules for openmoko neo1973 debug board
Eugeniy Meshcheryakov [Tue, 4 Oct 2011 13:14:02 +0000 (15:14 +0200)]
Add udev rules for openmoko neo1973 debug board

7 years agoSTM32L: Added flash driver and target
Clément Burin des Roziers [Fri, 16 Sep 2011 13:55:54 +0000 (15:55 +0200)]
STM32L: Added flash driver and target

Added the flash driver for the STM32L family, which highly differ from the STM32F family.
Added the TCL target file for JTAG access.

7 years agoVerdex: Add support for Gumstix Verdex boards.
Ash Charles [Fri, 30 Sep 2011 23:17:21 +0000 (16:17 -0700)]
Verdex: Add support for Gumstix Verdex boards.

Gumstix Verdex is a PXA270-based series of computer-on-modules. This
configuration file is based off the voipac.cfg configuration with
a different flash memory configuration. This has been tested flyswatter
adapter to reflash a Gumstix Verdex XL6P board.

7 years agou8500 : config for L2 cache
Michel Jaouen [Mon, 19 Sep 2011 14:49:23 +0000 (16:49 +0200)]
u8500 : config for L2 cache

7 years agoarmv7a ,cortex a : add L1, L2 cache support, va to pa support
Michel Jaouen [Thu, 29 Sep 2011 15:17:27 +0000 (17:17 +0200)]
armv7a ,cortex a : add L1, L2 cache support, va to pa support

7 years agojim-nvp is moving from jimtcl to openocd
Steve Bennett [Thu, 29 Sep 2011 06:12:41 +0000 (16:12 +1000)]
jim-nvp is moving from jimtcl to openocd

The jim-nvp code is specific to openocd, so it belongs in openocd,
not in the core jimtcl.

Signed-off-by: Steve Bennett <steveb@workware.net.au>
7 years agoAM/DM37x: add ES1.2 silicon type into account
Vladimir Zapolskiy [Wed, 28 Sep 2011 16:41:23 +0000 (19:41 +0300)]
AM/DM37x: add ES1.2 silicon type into account

The missing value for ES1.2 silicon revision is mentioned in
sprugn4m.pdf, and the recent TI Beagleboard XM is powered by it,
so let support the revision.

7 years agoadd target events, run algorithm and default r/w buffer api
Mathias K [Wed, 21 Sep 2011 17:18:26 +0000 (19:18 +0200)]
add target events, run algorithm and default r/w buffer api

Target events are added to get better gdb support. The run
algorithm functionality are implemented to support feature
fast flash write functionality. The new r/w buffer api is now
used to support the special memory address handling. The output
of the md command was fixed.

7 years agokinetis : fix deadlock on device having hasidcode false.
Michel Jaouen [Tue, 20 Sep 2011 07:37:52 +0000 (09:37 +0200)]
kinetis : fix deadlock on device having hasidcode false.

7 years agokinetis cpu flash driver
Mathias K [Sat, 17 Sep 2011 08:09:50 +0000 (10:09 +0200)]
kinetis cpu flash driver

Initial release of the freescale kinetis cpu flash driver.

7 years agocontrib: fix udev rules for tty based adaptors
Luca Bruno [Tue, 13 Sep 2011 13:11:01 +0000 (15:11 +0200)]
contrib: fix udev rules for tty based adaptors

Most serial adaptors are identified by udev with SUBSYSTEM=tty and
without DEVTYPE. This patch fix udev rules to work with any listed
tty-based adaptor. It has been tested with a FTDI-based Bus Pirate.

Signed-off-by: Luca Bruno <lucab@debian.org>
7 years agokinetis auto mass erase on secured devices
Mathias K [Mon, 12 Sep 2011 19:24:17 +0000 (21:24 +0200)]
kinetis auto mass erase on secured devices

This is a proof of concept to get access to the debug port of a
secured kinetis cpu. On full flash erase the cpu is automatically
secured and the debug port is not accessible.
To get this to work the srst line is needed and the necessary
configuration should be added to the configuration file.

7 years agoFixes and spellchecks for various Buspirate output messages
Luca Bruno [Sat, 10 Sep 2011 15:01:46 +0000 (17:01 +0200)]
Fixes and spellchecks for various Buspirate output messages

Signed-off-by: Luca Bruno <lucab@debian.org>
7 years agoAdd definition for the STEVAL-PCC010 board with the STM32F207
Uwe Bonnes [Thu, 1 Sep 2011 15:14:35 +0000 (17:14 +0200)]
Add definition for the STEVAL-PCC010 board with the STM32F207

7 years agoImplementation of a new jtag remote_bitbang driver.
Richard Uhler [Thu, 25 Aug 2011 20:29:33 +0000 (13:29 -0700)]
Implementation of a new jtag remote_bitbang driver.

The driver sends ascii encoded bitbang commands over unix sockets or TCP to
another process. This driver is useful for debugging software running on
processors which are being simulated.

7 years agoULINK driver: Remove typedefs in ulink.c
Martin Schmölzer [Wed, 31 Aug 2011 15:22:21 +0000 (17:22 +0200)]
ULINK driver: Remove typedefs in ulink.c

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Remove typedefs in OpenULINK firmware: Use typedefs from stdint.h ...
Martin Schmölzer [Wed, 31 Aug 2011 14:51:41 +0000 (16:51 +0200)]
ULINK driver: Remove typedefs in OpenULINK firmware: Use typedefs from stdint.h (uint8_t, uint16_t) instead of custom typedefs in shorttypes.h (u8, u16, ...)

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Remove typedefs in OpenULINK firmware USB descriptor structures
Martin Schmölzer [Tue, 30 Aug 2011 22:20:35 +0000 (00:20 +0200)]
ULINK driver: Remove typedefs in OpenULINK firmware USB descriptor structures

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agousleep to jtag_sleep
Rodrigo L. Rosa [Wed, 31 Aug 2011 22:43:11 +0000 (15:43 -0700)]
usleep to jtag_sleep

this will help avoid platform specific timing issues

7 years agostatic for some functions
Rodrigo L. Rosa [Wed, 31 Aug 2011 19:37:20 +0000 (12:37 -0700)]
static for some functions

made two functions into static, since they are not required by anything external

7 years agospeed up, relocate function
Rodrigo L. Rosa [Wed, 31 Aug 2011 19:32:14 +0000 (12:32 -0700)]
speed up, relocate function

added an attempt to use the non-reseting halting sequence. if it fails, then the full sequence will be attempted. this makes things a bit faster most of the time.
changed the location of a function, avoiding a forward def

7 years agoMerge branch 'dsp5680xx_cherry' of git://repo.or.cz/openocd/dsp568013 into fix
Øyvind Harboe [Wed, 31 Aug 2011 14:27:09 +0000 (16:27 +0200)]
Merge branch 'dsp5680xx_cherry' of git://repo.or.cz/openocd/dsp568013 into fix

7 years agoULINK driver: Update firmware image to reflect the latest changes in source code.
Martin Schmoelzer [Tue, 23 Aug 2011 15:22:53 +0000 (17:22 +0200)]
ULINK driver: Update firmware image to reflect the latest changes in source code.

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Add '-lm' linker flag when building this driver (required for correct...
Martin Schmoelzer [Thu, 4 Aug 2011 20:30:25 +0000 (22:30 +0200)]
ULINK driver: Add '-lm' linker flag when building this driver (required for correct calculation of JTAG TCK speed setting)

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Implement variable TCK frequency in OpenOCD driver
Martin Schmoelzer [Thu, 4 Aug 2011 17:03:59 +0000 (19:03 +0200)]
ULINK driver: Implement variable TCK frequency in OpenOCD driver

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Implement variable TCK frequency in OpenULINK firmware
Martin Schmölzer [Mon, 4 Jul 2011 17:03:29 +0000 (19:03 +0200)]
ULINK driver: Implement variable TCK frequency in OpenULINK firmware

Also, speed up jtag_clock_tck() significantly (150 kHz -> 375 kHz)

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Fix whitespace in OpenULINK firmware usb.c module (trivial)
Martin Schmoelzer [Tue, 23 Aug 2011 12:21:56 +0000 (14:21 +0200)]
ULINK driver: Fix whitespace in OpenULINK firmware usb.c module (trivial)

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Implement JTAG_PATHMOVE command
Martin Schmoelzer [Tue, 23 Aug 2011 14:53:03 +0000 (16:53 +0200)]
ULINK driver: Implement JTAG_PATHMOVE command

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Implement JTAG_STABLECLOCKS command
Martin Schmölzer [Mon, 4 Jul 2011 10:29:02 +0000 (12:29 +0200)]
ULINK driver: Implement JTAG_STABLECLOCKS command

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Implement command to manually force downloading firmware image from...
Martin Schmölzer [Mon, 4 Jul 2011 17:50:46 +0000 (19:50 +0200)]
ULINK driver: Implement command to manually force downloading firmware image from arbitrary location

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Re-order queue functions to reflect the order in commands.h
Martin Schmölzer [Mon, 4 Jul 2011 10:38:47 +0000 (12:38 +0200)]
ULINK driver: Re-order queue functions to reflect the order in commands.h

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Properly propagate return values in ulink_execute_queue()
Martin Schmölzer [Mon, 4 Jul 2011 10:30:13 +0000 (12:30 +0200)]
ULINK driver: Properly propagate return values in ulink_execute_queue()

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agoULINK driver: Update some comments, fix some coding mistakes
Martin Schmölzer [Sun, 26 Jun 2011 23:00:15 +0000 (01:00 +0200)]
ULINK driver: Update some comments, fix some coding mistakes

Signed-off-by: Martin Schmölzer <martin.schmoelzer@student.tuwien.ac.at>
7 years agovsllink driver compile fails with'vsllink_debug_buffer' defined but not used
simonqian.openocd [Tue, 30 Aug 2011 17:52:20 +0000 (01:52 +0800)]
vsllink driver compile fails with'vsllink_debug_buffer' defined but not used

USB communication is handled by code under versaloon directory.
So _DEBUG_USB_COMMS_  should not be used in vsllink.c.
Attachment is the patch.

7 years agoremoved trailing whitespaces
Rodrigo L. Rosa [Wed, 31 Aug 2011 04:14:33 +0000 (21:14 -0700)]
removed trailing whitespaces

emacs is awesome.
replace-regexp RET [ ]+$ RET RET
and it's done

7 years agofix enter debug mode for locking
Rodrigo L. Rosa [Wed, 31 Aug 2011 04:08:59 +0000 (21:08 -0700)]
fix enter debug mode for locking

added an alternative way to enter debug mode, which does not require restarting the chip.
this will not always work, but in general it will (failure 0.3%), and failure is not a dramatic issue, simply have to use the full sequence.
the user can only access "halt", which uses the full sequence, so the user should not have any problems.
restarting the chip requires reconfiguring the flash module. the doc is very poor, so i'd rather have the two methods, and live with the 0.3%.