openocd.git
13 years agotypes: write memory now uses const
Øyvind Harboe [Thu, 31 Mar 2011 16:37:19 +0000 (18:37 +0200)]
types: write memory now uses const

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomips: delete kludgy code that modifies data sent to write_memory()
Øyvind Harboe [Thu, 31 Mar 2011 16:42:10 +0000 (18:42 +0200)]
mips: delete kludgy code that modifies data sent to write_memory()

Could this cause confusion as data sent to write would be flipped
and then if the caller subsequently used the data, e.g. a
compare mismatch might happen?

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agostartup: fix bugs in cleanup upon errors during startup
Øyvind Harboe [Thu, 31 Mar 2011 11:32:28 +0000 (13:32 +0200)]
startup: fix bugs in cleanup upon errors during startup

Importantly adapter cleanup will now happen upon startup failure.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomips: mips32_pracc_exec error propagation fixes
Øyvind Harboe [Thu, 31 Mar 2011 21:46:32 +0000 (23:46 +0200)]
mips: mips32_pracc_exec error propagation fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomips: mips_ejtag_get_impcode error propagation added
Øyvind Harboe [Thu, 31 Mar 2011 21:39:10 +0000 (23:39 +0200)]
mips: mips_ejtag_get_impcode error propagation added

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomips: fix mips_ejtag_set_instr error handling
Øyvind Harboe [Thu, 31 Mar 2011 21:31:37 +0000 (23:31 +0200)]
mips: fix mips_ejtag_set_instr error handling

this fn does not fail, it queues data.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomips: fix error handling for jtag_execute_queue()
Øyvind Harboe [Thu, 31 Mar 2011 21:07:55 +0000 (23:07 +0200)]
mips: fix error handling for jtag_execute_queue()

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoxscale: fix gaffe in phys write
Øyvind Harboe [Thu, 31 Mar 2011 16:46:14 +0000 (18:46 +0200)]
xscale: fix gaffe in phys write

it would *read* instead of *write* to memory
when the MMU was disabled.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agocortex-a: use -dbgbase option
Øyvind Harboe [Wed, 30 Mar 2011 11:34:50 +0000 (13:34 +0200)]
cortex-a: use -dbgbase option

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agotarget: add -dbgbase option to target configuration
Øyvind Harboe [Wed, 30 Mar 2011 11:32:47 +0000 (13:32 +0200)]
target: add -dbgbase option to target configuration

Really a Cortex-A specific option, but there is no
system in place to support target specific options
currently and there has been no need for such a system
until now.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoat91sam3: Modified cidr comparisson to ignore version bits
Olivier Schonken [Mon, 28 Mar 2011 17:31:17 +0000 (19:31 +0200)]
at91sam3: Modified cidr comparisson to ignore version bits

production processor versions increment, thus the version
bits should be ignored for future proofing. e.g.
Engineering sample version == 0x00, production version 0x01

13 years agodocs: add HACKING file to help users get started with patches
Øyvind Harboe [Wed, 30 Mar 2011 11:08:39 +0000 (13:08 +0200)]
docs: add HACKING file to help users get started with patches

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoClarify LPC32XX address cycles message
Alexandre Pereira da Silva [Tue, 29 Mar 2011 19:19:47 +0000 (16:19 -0300)]
Clarify LPC32XX address cycles message

Hi,

This is a more descriptive message about LPC32XX error, when the nand
chip needs 5 address cycles.

Thanks.

13 years agoAdd Micron 2GiB nand
Alexandre Pereira da Silva [Tue, 29 Mar 2011 19:17:11 +0000 (16:17 -0300)]
Add Micron 2GiB nand

Hi,

This will add support for a new nand chip device.

Thanks.

13 years agobugfix for step <address> mips_m4k
Andrew Lyon [Mon, 28 Mar 2011 10:28:13 +0000 (11:28 +0100)]
bugfix for step <address> mips_m4k

The patch below fixes step <address> on mips_m4k.

Spencer Oliver <spen@spen-soft.co.uk>:

The current code is used on all other arch's - is
there a underlying issue with those aswell ?

13 years agocommand: fix leak when executing commands
Øyvind Harboe [Sun, 27 Mar 2011 21:50:53 +0000 (23:50 +0200)]
command: fix leak when executing commands

found via valgrind, not observed/reported.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agocortex_a: rename cortex_a8.c/h to cortex_a.c/h
Øyvind Harboe [Tue, 22 Mar 2011 10:29:10 +0000 (11:29 +0100)]
cortex_a: rename cortex_a8.c/h to cortex_a.c/h

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoomap4430: tried to add in workaround for broken dbgbase query
Øyvind Harboe [Tue, 22 Mar 2011 08:21:16 +0000 (09:21 +0100)]
omap4430: tried to add in workaround for broken dbgbase query

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agocortex a9: merge cortex a9 and a8 code
Øyvind Harboe [Mon, 21 Mar 2011 13:10:57 +0000 (14:10 +0100)]
cortex a9: merge cortex a9 and a8 code

better to keep this in a single file.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoomap4430: cortex a9 and a8 are now merged again
Øyvind Harboe [Mon, 21 Mar 2011 13:13:09 +0000 (14:13 +0100)]
omap4430: cortex a9 and a8 are now merged again

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: fix bug in ir scan handling
Øyvind Harboe [Mon, 21 Mar 2011 12:30:09 +0000 (13:30 +0100)]
zy1000: fix bug in ir scan handling

set cur_instr to BYPASS as optimisation code will
rely on checking the cached value.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: removed JTAG master TCP/IP server
Øyvind Harboe [Fri, 18 Mar 2011 12:47:17 +0000 (13:47 +0100)]
zy1000: removed JTAG master TCP/IP server

Move ZY1000 OpenOCD driver more in the direction of being
a client to simplify code.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agodsp563xx_once: fix warning and potential bug
Øyvind Harboe [Sun, 20 Mar 2011 18:44:48 +0000 (19:44 +0100)]
dsp563xx_once: fix warning and potential bug

I don't think dsp563xx_once_read_register() would ever
be called with len==0, but it would have been broken in
that case.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: add code to check that SRST asserts
Øyvind Harboe [Thu, 3 Mar 2011 10:00:14 +0000 (11:00 +0100)]
zy1000: add code to check that SRST asserts

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agotarget: allow targets to override memory alignment
Mathias K [Thu, 3 Mar 2011 10:01:46 +0000 (11:01 +0100)]
target: allow targets to override memory alignment

Targets can implement read/write_buffer to handle
alignment.

13 years agoSYS_WRITE0 fix
John and Tina Peterson [Thu, 17 Mar 2011 06:34:44 +0000 (07:34 +0100)]
SYS_WRITE0 fix

Problem is, trying to print "Hello, world!\n" just prints endless H's, because r1 is never incremented.

One way to fix it would be to add a "++" after "r1".

13 years agoFix a bunch of typos.
Uwe Hermann [Thu, 17 Mar 2011 02:22:12 +0000 (03:22 +0100)]
Fix a bunch of typos.

Fix a bunch of typos.

Most are in code comments, so nothing should break. UNKOWN_COMMAND and
CMD_UNKOWN are not used elsewhere, so correcting the spelling should
also not break anything.

13 years agodsp563xx: fix alignment warnings
Øyvind Harboe [Mon, 14 Mar 2011 14:32:14 +0000 (15:32 +0100)]
dsp563xx: fix alignment warnings

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agodsp563xx: fix bug in x buffer handling
Øyvind Harboe [Tue, 15 Mar 2011 09:43:45 +0000 (10:43 +0100)]
dsp563xx: fix bug in x buffer handling

found by inspection.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: switch to pthread
Øyvind Harboe [Thu, 3 Mar 2011 09:16:17 +0000 (10:16 +0100)]
zy1000: switch to pthread

pthreads work under Linux and eCos.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: fix JTAG over TCP/IP performance problem
Øyvind Harboe [Thu, 3 Mar 2011 08:22:25 +0000 (09:22 +0100)]
zy1000: fix JTAG over TCP/IP performance problem

only flush write queue just before waiting for more data,
rather than when fetching more data from the buffer.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: fix incorrect usage of jtag_sleep()
Øyvind Harboe [Thu, 3 Mar 2011 08:16:11 +0000 (09:16 +0100)]
zy1000: fix incorrect usage of jtag_sleep()

Found by inspection: the correct thing in the context is to use
usleep() rather than jtag_sleep(). Relates to JTAG over TCP/IP
only.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agojtag: clean up jtag_sleep, handle short sleeps correctly via usleep
Øyvind Harboe [Thu, 3 Mar 2011 08:14:30 +0000 (09:14 +0100)]
jtag: clean up jtag_sleep, handle short sleeps correctly via usleep

short sleeps are handled via usleep, longer sleeps we round up
to nearest ms.

There was a bug in jtag_sleep() in that it would round *down*
to nearest ms, thus making all <1ms sleeps 0. Found by inspection
rather than symptom.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agozy1000: reduce memory usage for fw upgrade fn
Øyvind Harboe [Tue, 15 Mar 2011 08:39:20 +0000 (09:39 +0100)]
zy1000: reduce memory usage for fw upgrade fn

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoomap4430: add Blaze config
Aaron Carroll [Wed, 9 Mar 2011 19:39:56 +0000 (06:39 +1100)]
omap4430: add Blaze config

Signed-off-by: Aaron Carroll <aaronc@ok-labs.com>
13 years agoomap4430: force hardware breakpoints for GDB
Aaron Carroll [Wed, 9 Mar 2011 19:39:55 +0000 (06:39 +1100)]
omap4430: force hardware breakpoints for GDB

Soft breakpoints are currently broken if the MMU is enabled due to incorrect
cache flushing.  Until this is fixed, force the use of hardware breakpoints.

Signed-off-by: Aaron Carroll <aaronc@ok-labs.com>
13 years agojlink: add Emulator configuration support
Jean-Christophe PLAGNIOL-VILLARD [Mon, 7 Mar 2011 14:11:29 +0000 (15:11 +0100)]
jlink: add Emulator configuration support

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agojlink: add detect hw type
Jean-Christophe PLAGNIOL-VILLARD [Mon, 7 Mar 2011 14:11:28 +0000 (15:11 +0100)]
jlink: add detect hw type

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agojlink: use tap buffer as 2k
Jean-Christophe PLAGNIOL-VILLARD [Mon, 7 Mar 2011 14:11:27 +0000 (15:11 +0100)]
jlink: use tap buffer as 2k

as said in the datasheet Section 3.3.2 Organization of buffers

All buffers are big enough to hold 2 KByte of data.

this will double the speed of download

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agojlink: add capability dumper and command
Jean-Christophe PLAGNIOL-VILLARD [Mon, 7 Mar 2011 14:11:26 +0000 (15:11 +0100)]
jlink: add capability dumper and command

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoft2232: fix log message and change log output to debug
Mathias K [Thu, 3 Mar 2011 09:28:21 +0000 (10:28 +0100)]
ft2232: fix log message and change log output to debug

13 years agoat91: add at91sam9g45 support
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:08 +0000 (12:57 +0100)]
at91: add at91sam9g45 support

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoat91: add at91sam9g10 support
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:07 +0000 (12:57 +0100)]
at91: add at91sam9g10 support

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoat91sam9260: update sram information
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:06 +0000 (12:57 +0100)]
at91sam9260: update sram information

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoat91: add at91sam9263 support
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:05 +0000 (12:57 +0100)]
at91: add at91sam9263 support

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoat91: add at91sam9261 support
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:04 +0000 (12:57 +0100)]
at91: add at91sam9261 support

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agoat91sam9: factorise cpu support
Jean-Christophe PLAGNIOL-VILLARD [Wed, 2 Mar 2011 11:57:03 +0000 (12:57 +0100)]
at91sam9: factorise cpu support

all at91sam9 are nearly the same except sram and soc name

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agojlink: add jlink_pid to specify the pid to use
Jean-Christophe PLAGNIOL-VILLARD [Mon, 28 Feb 2011 19:40:47 +0000 (20:40 +0100)]
jlink: add jlink_pid to specify the pid to use

this will allow us to use multiple jlink at the same time as when
the USB-Address is specified the PID change from 0x0101 to
(0x101 + usb_adress)

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
13 years agojlink: switch commands to subcommands
Jean-Christophe PLAGNIOL-VILLARD [Mon, 28 Feb 2011 19:40:46 +0000 (20:40 +0100)]
jlink: switch commands to subcommands

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
13 years agojlink: harmonise the device name to J-Link
Jean-Christophe PLAGNIOL-VILLARD [Mon, 28 Feb 2011 19:40:45 +0000 (20:40 +0100)]
jlink: harmonise the device name to J-Link

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
13 years agojlink: add new PID and VID
Jean-Christophe PLAGNIOL-VILLARD [Mon, 28 Feb 2011 19:40:44 +0000 (20:40 +0100)]
jlink: add new PID and VID

The default pid of the segger is 0x0101
But when you change the USB Address it will also

pid = ( usb_address > 0x4) ? 0x0101 : (0x101 + usb_address)

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
13 years agosvf: add nil option that just runs through the svf file
Øyvind Harboe [Fri, 25 Feb 2011 13:09:39 +0000 (14:09 +0100)]
svf: add nil option that just runs through the svf file

useful for debugging without access to hardware to e.g.
regression test, reproduce memory corruption problems,
etc.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agolog: debug level is between silent and debug output levels
Øyvind Harboe [Thu, 24 Feb 2011 14:37:03 +0000 (15:37 +0100)]
log: debug level is between silent and debug output levels

It wasn't previously possible to silence the output.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agojtag: add wait_srst_deassert command
Øyvind Harboe [Thu, 24 Feb 2011 14:19:27 +0000 (15:19 +0100)]
jtag: add wait_srst_deassert command

Useful to do something *real quick* after a SRST deassert.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoft2232: fix possible read buffer overflow
Mathias K [Thu, 24 Feb 2011 12:00:59 +0000 (13:00 +0100)]
ft2232: fix possible read buffer overflow

This patch fix a possible read buffer overflow in ft2232_execute_queue.
Also the correct read queue size for libftdi and libftd2xx was added and
and tested.
In function ft2232_write a uninitialized value was initialized because we
don't know if this value was set in the ftdi api call.

13 years agocortex_a8: remove dap_ap_sel calls
Luca Ellero [Tue, 22 Feb 2011 20:16:10 +0000 (20:16 +0000)]
cortex_a8: remove dap_ap_sel calls

add new mem_ap_sel_* functions (as was made for cortex_a9)
see commit: 779005f43dc372de937dfd4b445f31d882b98eca

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agoadd at91rm9200-ek board support
Jean-Christophe PLAGNIOL-VILLARD [Mon, 21 Feb 2011 17:59:50 +0000 (18:59 +0100)]
add at91rm9200-ek board support

tested with jlink sam-ice v5 while loading barebox

(gdb) load
Loading section .text, size 0x2f190 lma 0x21f00000
Loading section .rodata, size 0x931c lma 0x21f2f190
Loading section .data, size 0x29e8 lma 0x21f384ac
Loading section .barebox_cmd, size 0x78c lma 0x21f3ae94
Loading section .barebox_initcalls, size 0x80 lma 0x21f3b620
Start address 0x21f00000, load size 243360
Transfer rate: 26 KB/sec, 13520 bytes/write.

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agojlink: set the speed at JLINK_MAX_SPEED when an exceeded speed is requested
Jean-Christophe PLAGNIOL-VILLARD [Mon, 21 Feb 2011 17:59:49 +0000 (18:59 +0100)]
jlink: set the speed at JLINK_MAX_SPEED when an exceeded speed is requested

it will allow to be at the highest speed of the jlink without touching the
board or cpu config

tested on sam-ice v5 and at91rm9200-ek

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
13 years agodsp563xx: rudimentary gdb support
Mathias K [Sun, 20 Feb 2011 10:12:53 +0000 (11:12 +0100)]
dsp563xx: rudimentary gdb support

This patch add rudimentary gdb support. The gdb register list
order is corrected. All registers are now 32bit width. Events are
send to signalize gdb the current target status. Resume and step
function was corrected to consider a modified pc register. Read/write
memory now support L memory type, this means a memory with alternating
y/x memory words. The memspace variable, used by gdb, is now observed
before a default memory access is initiated. Dummy functions for breakpoint
and watchpoint are added.

13 years agogitmodules: use http protocol for git2cl module
Edgar Grimberg [Sun, 20 Feb 2011 23:07:39 +0000 (00:07 +0100)]
gitmodules: use http protocol for git2cl module

Use the http protocol for git2cl module, as it makes it easier for the
firewall safe mirror to keep all submodules firewall safe.

Signed-off-by: Edgar Grimberg <edgar.grimberg@gmail.com>
13 years agofix compile error under MinGW
SimonQian [Fri, 18 Feb 2011 12:39:55 +0000 (20:39 +0800)]
fix compile error under MinGW

13 years agostm32: add ID for medium density device Rev Z
Luca Ellero [Thu, 17 Feb 2011 20:51:32 +0000 (20:51 +0000)]
stm32: add ID for medium density device Rev Z

stm32-discovery evaluation board (STM32F100RBTB6):
reading device id register (0xE0042000) returns 0x10010420

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agoarm_adi_v5: add/move apsel member in struct adiv5_dap
Luca Ellero [Mon, 14 Feb 2011 21:46:53 +0000 (21:46 +0000)]
arm_adi_v5: add/move apsel member in struct adiv5_dap

This patch tries to make some order in "apsel" mess.
"dap apsel" command was quite useless (and broken) by itself.
With this patch we can use it to select between AHB or APB memory access
(previous patch 05ab8bdb813acdcd74afa71d6656c2df816cb230 was somehow broken).

- moves member apsel (in struct adiv5_dap) to ap_current
- adds apsel member

this strange choice is made trying to keep coherence in "dap apsel" command
 and to keep compatibility with other code (for example cortex_a8).

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agodsp563xx: minor fixes, code cleanup
Mathias K [Thu, 17 Feb 2011 08:11:25 +0000 (09:11 +0100)]
dsp563xx: minor fixes, code cleanup

This patch move the dsp563xx_target_create function to the
related code block. Also the target examine function was added
and the register cache is initialized in a separate function. The
missing functionality to invalidate the x memory context on memory
writes was also added.

13 years agodsp563xx_once: Correct wrong return value on jtag communication errors
Mathias K [Thu, 17 Feb 2011 08:05:42 +0000 (09:05 +0100)]
dsp563xx_once: Correct wrong return value on jtag communication errors

This patch change the return value on a jtag communication error
to TARGET_UNKNOWN because this function should return the current
target status and not a error code from the underlying api call.
Also the validity of the jtag_status is extended to all static
bits in this value.

13 years ago- remove pipeline context, use once register instead - fix wrong register write in...
Mathias K [Tue, 15 Feb 2011 19:17:10 +0000 (20:17 +0100)]
- remove pipeline context, use once register instead - fix wrong register write in resume and step function - add more conditional branch handling

13 years agolpc32xx: Flash driver
Bjarne Steinsbo [Tue, 15 Feb 2011 19:23:40 +0000 (20:23 +0100)]
lpc32xx: Flash driver

Based on the lpc3180 driver, but released as a separate driver for two reasons:
 1) I don't have an lpc3180 to test it against, so it might unintentionally break compatibility.
 2) It's using a different OOB layout than lpc3180.

Rewritten so that it no longer borrows code from the NXP CDL library.  Instead borrowing code from the u-boot port to lpc32xx, written by Kevin Wells.

Tested on lpc3250 (Hitex LPC3250-Stick).  OOB layout is compatible with LPCLinux.

13 years ago- add parameter flush to the once api to signalize if the jtag queue need to be flush...
Mathias K [Tue, 15 Feb 2011 16:25:10 +0000 (17:25 +0100)]
- add parameter flush to the once api to signalize if the jtag queue need to be flushed after the command

13 years ago- add bulk memory write function - execute jtag queue at the end of the memory transfer
Mathias K [Tue, 15 Feb 2011 15:59:23 +0000 (16:59 +0100)]
- add bulk memory write function - execute jtag queue at the end of the memory transfer

13 years agodsp563xx_once: Correct definition of JTAG_INSTR_CLAMP
Phil Fong [Tue, 15 Feb 2011 19:17:33 +0000 (20:17 +0100)]
dsp563xx_once: Correct definition of JTAG_INSTR_CLAMP

 I've been working on Rodrigo on adding support to flash
Freescale dsp56800e devices and have been looking at the
dsp563xx code.  I think the define for the JTAG CLAMP
instruction in dsp563xx_once.c is incorrect.  It should
be 0x05 according the Freescale AN2074 (and is also
0x05 in the dsp568xx according to AN1935).  It won't
actually change anything in OpenOCD since this define
is not used anywhere (as far as I can tell).

13 years agoft2232: add functions for ft2232 set data bits high/low byte command
Mathias K [Sun, 13 Feb 2011 12:21:42 +0000 (13:21 +0100)]
ft2232: add functions for ft2232 set data bits high/low byte command

reduce duplication. No change in behavior.

13 years agocortex_a9: move dap_ap_select to arm_avi_v5
Luca Ellero [Sat, 12 Feb 2011 11:54:42 +0000 (11:54 +0000)]
cortex_a9: move dap_ap_select to arm_avi_v5

dap_ap_select was used in the code at various points, but that can lead to
confusion, without any knowledge of what AP is really selected at some
points.
Some bugs derive from this (for example md/mw doesn't work well after
issueing "dap apsel" command).
Moving it to arm_adi_v5.c (using  mem_ap_sel* functions instead of mem_ap_*)
make the code more clear and more easier to maintain.
In the future it should be made "static" to avoid its use outside arm_adi_v5

One further benefit is the various goto has been removed as well

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agoarm_adi_v5: add wrapping transfer functions with selection of ap
Luca Ellero [Sat, 12 Feb 2011 11:54:41 +0000 (11:54 +0000)]
arm_adi_v5: add wrapping transfer functions with selection of ap

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agoarm_adi_v5: add transfer functions prototypes with selection of ap
Luca Ellero [Sat, 12 Feb 2011 11:54:40 +0000 (11:54 +0000)]
arm_adi_v5: add transfer functions prototypes with selection of ap

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agocortex_a9: check if MMU is enabled on APB read/write memory
Luca Ellero [Sat, 12 Feb 2011 11:54:39 +0000 (11:54 +0000)]
cortex_a9: check if MMU is enabled on APB read/write memory

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agocortex_a9: check target halted on APB read/write memory
Luca Ellero [Sat, 12 Feb 2011 11:54:38 +0000 (11:54 +0000)]
cortex_a9: check target halted on APB read/write memory

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agocortex_a9: trivial fixes
Luca Ellero [Sat, 12 Feb 2011 11:54:37 +0000 (11:54 +0000)]
cortex_a9: trivial fixes

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agobuikd: fix cygwin -mno-cygwin build error
Spencer Oliver [Thu, 10 Feb 2011 13:57:30 +0000 (13:57 +0000)]
buikd: fix cygwin -mno-cygwin build error

Remove duplicate inline that causes certain versions of gcc to choke.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
13 years agocortex_a9: implement read/write memory through APB-AP
Luca Ellero [Wed, 9 Feb 2011 20:36:14 +0000 (20:36 +0000)]
cortex_a9: implement read/write memory through APB-AP

This patch adds read/write capability to memory addresses not
accessible through AHB-AP (for example "boot ROM code").

To select AHB or APB, a "dap apsel" command must be issued:
dap apsel 0 -> following memory accesses are through AHB
dap apsel 1 -> following memory accesses are through APB

NOTE: at the moment APB memory accesses are very slow, compared
      to AHB accesses. Work has to be done to get it faster (for
      example LDR/STR instead od LDRB/STRB)

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agocortex_a9: fix dap_ap_select() usage
Aaron Carroll [Thu, 3 Feb 2011 01:06:14 +0000 (12:06 +1100)]
cortex_a9: fix dap_ap_select() usage

Save, select and restore AP in cortex_a9_step and cortex_a9_init_debug_access.
Fixes a bug where the wrong AP is selected after a reset.

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agobuspirate: Fix command parsing, fix errors to have more sense.
Michal Demin [Tue, 8 Feb 2011 10:59:01 +0000 (11:59 +0100)]
buspirate: Fix command parsing, fix errors to have more sense.

Signed-off-by: Michal Demin <michaldemin@gmail.com>
13 years agoperformance: committed wrong version of buf_set_buf optimization
Mathias K [Tue, 8 Feb 2011 10:06:56 +0000 (11:06 +0100)]
performance: committed wrong version of buf_set_buf optimization

oops...

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoomap4430: Add JRC TAPID for PandaBoard REV EA1 (PEAP platforms)
Luca Ellero [Mon, 7 Feb 2011 22:47:15 +0000 (22:47 +0000)]
omap4430: Add JRC TAPID for PandaBoard REV EA1 (PEAP platforms)

PandaBoard REV EA1 (Panda Early Adopter Program) has a different ID.
This patch add alternate REV EA1 TAP id to configuration file

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agodsp563xx: add x, y and p memory access
Mathias K [Thu, 3 Feb 2011 16:58:52 +0000 (17:58 +0100)]
dsp563xx: add x, y and p memory access

Hello,

this patch add commands to access to x,y and p memory. For run time optimization some local jtag
function was changed to static inline.

Regards,

Mathias

13 years agocortex_a8/a9: fix some comments
Luca Ellero [Tue, 8 Feb 2011 05:16:54 +0000 (05:16 +0000)]
cortex_a8/a9: fix some comments

Signed-off-by: Luca Ellero <lroluk@gmail.com>
13 years agobuf_set_buf around 30% speed increase
Mathias K [Fri, 4 Feb 2011 20:15:22 +0000 (21:15 +0100)]
buf_set_buf around 30% speed increase

Also i have checked the input of this function and in many cases
a simple byte copy is possible.

I have added this check now and is it possible the buffer is
copied byte by byte and not bit by bit.

With byte boundary input the test looks like this:

buf_set_buf 0x02000000 iteration test:
runtime (seconds): old: 6.828559 new: 0.436191 diff: 6.392368
runtime (seconds): old: 6.853636 new: 0.430389 diff: 6.423247
runtime (seconds): old: 6.794985 new: 0.423065 diff: 6.371920

Without:

buf_set_buf 0x02000000 iteration test:
runtime (seconds): old: 6.370869 new: 5.552624 diff: 0.818245
runtime (seconds): old: 6.420730 new: 5.665887 diff: 0.754843
runtime (seconds): old: 6.583306 new: 5.599021 diff: 0.984285

Regards,

Mathias

13 years agostm32x: add support for STM32F20x
Øyvind Harboe [Mon, 31 Jan 2011 11:32:07 +0000 (12:32 +0100)]
stm32x: add support for STM32F20x

ready for wider testing and comments on basic erase + programming.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agomore changes to dsp563xx code
Mathias K [Tue, 1 Feb 2011 12:00:59 +0000 (13:00 +0100)]
more changes to dsp563xx code

Hello,

this patch adds the missing cpu registers and the correct read/write register functions and fixed
most of the halt/step/resume issues. The complete missing error propagation was added.

+ fix tab/spaces

Regards,

Mathias

13 years ago24bit buffer support
Mathias K [Wed, 2 Feb 2011 16:38:38 +0000 (17:38 +0100)]
24bit buffer support

Hello,

this patch add 24bit support to the target buffer functions and little/big endian functions.

Regards,

Mathias

13 years agoomap4430: fix reset sequence
Aaron Carroll [Wed, 2 Feb 2011 07:16:26 +0000 (18:16 +1100)]
omap4430: fix reset sequence

* Write to the PRM reset control register should have been 'phys';
* Setup empty reset-assert handlers for the M3's, since the board-level reset
  takes care of them;
* Remove the dbginit cruft, because it gets called implicitly on reset.

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agocortex_m3: allow scripts to override reset
Aaron Carroll [Wed, 2 Feb 2011 07:16:25 +0000 (18:16 +1100)]
cortex_m3: allow scripts to override reset

If a handler for the reset-assert event it present, skip the usual reset
handling.  This is needed, for example, for board-level resets.

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoerror: remove debug output when reporting errors
Øyvind Harboe [Mon, 31 Jan 2011 11:09:46 +0000 (12:09 +0100)]
error: remove debug output when reporting errors

The user does not need to know or care about "command handlers".

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agocfi: use ARM32 machine code on all CPUs but Cortex M3
Øyvind Harboe [Mon, 31 Jan 2011 09:30:48 +0000 (10:30 +0100)]
cfi: use ARM32 machine code on all CPUs but Cortex M3

ARM11 broke with aa61a3b3d8b6acad19050987835ec05f3d298bdb
as the code only checked for arm 7/9.

CFI probably needs work for non-ARM targets but perhaps
not adding working area memory to e.g. MIPS will give
the default slow CFI support.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
13 years agoTCL configs for OMAP4430 and Pandaboard
Aaron Carroll [Mon, 24 Jan 2011 07:06:48 +0000 (18:06 +1100)]
TCL configs for OMAP4430 and Pandaboard

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agocortex_a9: add source files for Cortex A9 support.
Aaron Carroll [Mon, 24 Jan 2011 07:06:46 +0000 (18:06 +1100)]
cortex_a9: add source files for Cortex A9 support.

add target and build support for A9

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoarm_dpm: add some SCR/RCR macros
Aaron Carroll [Mon, 24 Jan 2011 07:06:45 +0000 (18:06 +1100)]
arm_dpm: add some SCR/RCR macros

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoAdd '-coreid' target option to support multiple cores per TAP.
Aaron Carroll [Mon, 24 Jan 2011 07:06:44 +0000 (18:06 +1100)]
Add '-coreid' target option to support multiple cores per TAP.

ARM Cortex-A9 multi-core chips expose a single TAP/DAP which connects
to both cores.  The '-coreid' option selects which core the target
should connect to.

Note that at present, OpenOCD can connect to either core, but not both
simulatenously, until ADI contexts can be shared.

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoAdd cscope to .gitignore
Aaron Carroll [Mon, 24 Jan 2011 07:06:43 +0000 (18:06 +1100)]
Add cscope to .gitignore

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoopenocd.texi: minor fixes in Reset Configuration
Aaron Carroll [Fri, 28 Jan 2011 06:20:24 +0000 (17:20 +1100)]
openocd.texi: minor fixes in Reset Configuration

Signed-off-by: Aaron Carroll <aaronc@cse.unsw.edu.au>
13 years agoadd cortex-r4 etm id to dap info
Mathias K [Thu, 27 Jan 2011 08:16:09 +0000 (09:16 +0100)]
add cortex-r4 etm id to dap info

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)