From: Freddie Chopin Date: Tue, 17 Jul 2012 07:49:37 +0000 (+0200) Subject: Update HACKING info X-Git-Tag: v0.7.0-rc1~74 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=refs%2Fchanges%2F47%2F747%2F4 Update HACKING info Inform about possibility of discarding negative review in Gerrit when specific conditions are met. Change-Id: I432b6c93cefc368fa22ce1096bea4cd174e03816 Signed-off-by: Freddie Chopin Reviewed-on: http://openocd.zylin.com/747 Reviewed-by: Øyvind Harboe Tested-by: Øyvind Harboe --- diff --git a/HACKING b/HACKING index 2bd3114275..d4f7a79f8c 100644 --- a/HACKING +++ b/HACKING @@ -152,6 +152,13 @@ master branch will be much reduced. If a contributor pushes a patch, it is considered good form if another contributor actually approves and submits that patch. +It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does +not have to) be disregarded if all conditions listed below are met: + +- the concerns raised in the review have been addressed (or explained), +- reviewer does not re-examine the change in a month, +- reviewer does not answer e-mails for another month. + @section browsing Browsing Patches All OpenOCD patches can be reviewed here. */