From: Stefan Mahr <stefan.mahr@sphairon.com>
Date: Tue, 12 Mar 2013 09:43:21 +0000 (+0100)
Subject: jtag: parport: avoid freeing read-only memory section
X-Git-Tag: v0.7.0-rc1~47
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=fac9057f022e5752fdfbe238ea69219d945d884e

jtag: parport: avoid freeing read-only memory section

If command parport_cable is not executed, parport_cable points to
const char array in read-only memory as default. On exit free()
will try to free this read-only memory. This patch uses strdup to
allocate memory when defining default setting.

Change-Id: I290e707ac6a37e9dc1b45c85ca51d8bd6aac6761
Signed-off-by: Stefan Mahr <stefan.mahr@sphairon.com>
Reviewed-on: http://openocd.zylin.com/1223
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
---

diff --git a/src/jtag/drivers/parport.c b/src/jtag/drivers/parport.c
index 3c07afb286..793b28f3b8 100644
--- a/src/jtag/drivers/parport.c
+++ b/src/jtag/drivers/parport.c
@@ -268,8 +268,8 @@ static int parport_init(void)
 
 	cur_cable = cables;
 
-	if ((parport_cable == NULL) || (parport_cable[0] == 0)) {
-		parport_cable = "wiggler";
+	if (parport_cable == NULL) {
+		parport_cable = strdup("wiggler");
 		LOG_WARNING("No parport cable specified, using default 'wiggler'");
 	}