From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Wed, 3 Apr 2019 08:14:29 +0000 (+0200)
Subject: target_request: replace command_print() with command_output_text()
X-Git-Tag: v0.11.0-rc1~712
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=ce6340d8ce76af4fdb0ce1011863f5312ae1d8ee

target_request: replace command_print() with command_output_text()

To prepare for handling TCL return values consistently, all calls
to command_print/command_print_sameline should be ready to switch
to CMD as first parameter.

When dumping traces or semihosting text, the command that enabled
it is already completed, so CMD is not a valid value.
Plus, we want the dump to be printed in the command context where
the enable command was executed.

Replace command_print() with command_output_text().

Change-Id: I297a2b799a914233499641062407cf6e8b9fe012
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5051
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
---

diff --git a/src/target/target_request.c b/src/target/target_request.c
index 6ca204b508..2df29587fc 100644
--- a/src/target/target_request.c
+++ b/src/target/target_request.c
@@ -56,7 +56,7 @@ static int target_asciimsg(struct target *target, uint32_t length)
 	LOG_DEBUG("%s", msg);
 
 	while (c) {
-		command_print(c->cmd_ctx, "%s", msg);
+		command_output_text(c->cmd_ctx, msg);
 		c = c->next;
 	}
 
@@ -100,7 +100,7 @@ static int target_hexmsg(struct target *target, int size, uint32_t length)
 			LOG_DEBUG("%s", line);
 
 			while (c) {
-				command_print(c->cmd_ctx, "%s", line);
+				command_output_text(c->cmd_ctx, line);
 				c = c->next;
 			}
 			c = target->dbgmsg;