From: Øyvind Harboe <oyvind.harboe@zylin.com>
Date: Mon, 2 Aug 2010 14:55:46 +0000 (+0200)
Subject: verify_image: print out a statement that there are no further errors
X-Git-Tag: v0.5.0-rc1~468
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=bfa34f88f8b77596d6f70be446708a3f5a604e9b;hp=c49d4c9f7f43979e3abf04067dc38535f7ebc45a

verify_image: print out a statement that there are no further errors

It is useful to know that the printed errors are *all* the
errors there were.

Added missing error handling(found by inspection).

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
---

diff --git a/src/target/target.c b/src/target/target.c
index 3bf6824be2..f178ae368c 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -2703,7 +2703,12 @@ static COMMAND_HELPER(handle_verify_image_command_internal, int verify)
 		if (verify)
 		{
 			/* calculate checksum of image */
-			image_calculate_checksum(buffer, buf_cnt, &checksum);
+			retval = image_calculate_checksum(buffer, buf_cnt, &checksum);
+			if (retval != ERROR_OK)
+			{
+				free(buffer);
+				break;
+			}
 
 			retval = target_checksum_memory(target, image.sections[i].base_address, buf_cnt, &mem_checksum);
 			if (retval != ERROR_OK)
@@ -2769,6 +2774,10 @@ static COMMAND_HELPER(handle_verify_image_command_internal, int verify)
 		free(buffer);
 		image_size += buf_cnt;
 	}
+	if (diffs > 0)
+	{
+		command_print(CMD_CTX, "No more differences found.");
+	}
 done:
 	if (diffs > 0)
 	{