From: Paul Fertser Date: Tue, 19 Aug 2014 07:44:42 +0000 (+0400) Subject: jtag: always configure enabled tap parameter appropriately X-Git-Tag: v0.9.0-rc1~294 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=bd0409aa938875ea5a8d8235f8996116be171b69 jtag: always configure enabled tap parameter appropriately Commit f701c0cb seems to have introduced a regression for non-JTAG transports as the newly created "tap" (DAP actually) ended up being disabled, thus resulting in total lack of functionality. This was exposed by a debug log demonstrating ftdi SWD transport connection to mdr32f9q2i, the target wasn't examined on init and couldn't be reset. Change-Id: If53cbe800d4adc177aa3ac3219860e7fa15b3e49 Reported-by: Хайруллин Эльдар Signed-off-by: Paul Fertser Reviewed-on: http://openocd.zylin.com/2261 Tested-by: jenkins Reviewed-by: Angus Gratton Reviewed-by: Nemui Trinomius Reviewed-by: Spencer Oliver --- diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index 647ac70c74..11687b9c1a 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -556,6 +556,7 @@ static int jim_newtap_cmd(Jim_GetOptInfo *goi) if (!transport_is_jtag()) { /* SWD or CMSIS-DAP (which is currently SWD-only) doesn't require any JTAG tap parameters */ + pTap->enabled = true; jtag_tap_init(pTap); return JIM_OK; }